2021-04-24 14:34:40

by Vitaly Rodionov

Subject: [PATCH v1 0/2] Fix couple of bugs reported by Canonical

CirrusLogic: Cracking noises appears in built-in speaker when output
volume is set >80%
BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1923557i

CirrusLogic: The default input volume is "0%"
BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1924997

Stefan Binding (2):
ALSA: hda/cirrus: Set Initial DMIC volume for Bullseye to 16%
ALSA: hda/cirrus: Use CS8409 Equalizer to fix abnormal sounds on
Bullseye

sound/pci/hda/patch_cirrus.c | 37 ++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)

--
2.25.1

2021-04-24 14:36:00

by Vitaly Rodionov

Subject: [PATCH v1 1/2] ALSA: hda/cirrus: Set Initial DMIC volume for Bullseye to 16%

From: Stefan Binding <[email protected]>

Tested on DELL Inspiron-3505, DELL Inspiron-3501, DELL Inspiron-3500

Signed-off-by: Stefan Binding <[email protected]>
Signed-off-by: Vitaly Rodionov <[email protected]>
BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1923557
Reported-and-tested-by: You-Sheng Yang <[email protected]>
---
sound/pci/hda/patch_cirrus.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/sound/pci/hda/patch_cirrus.c b/sound/pci/hda/patch_cirrus.c
index 5d57096b3a95..d6cf93b7483c 100644
--- a/sound/pci/hda/patch_cirrus.c
+++ b/sound/pci/hda/patch_cirrus.c
@@ -2172,6 +2172,10 @@ static void cs8409_cs42l42_fixups(struct hda_codec *codec,
(get_wcaps(codec, CS8409_CS42L42_AMIC_PIN_NID) | AC_WCAP_UNSOL_CAP));
break;
case HDA_FIXUP_ACT_PROBE:
+
+ if (codec->fixup_id == CS8409_BULLSEYE)
+ snd_hda_codec_amp_init_stereo(codec, CS8409_CS42L42_DMIC_ADC_PIN_NID,
+ HDA_INPUT, 0, 0xff, 0x19);
snd_hda_gen_add_kctl(&spec->gen,
NULL, &cs8409_cs42l42_hp_volume_mixer);
snd_hda_gen_add_kctl(&spec->gen,
--
2.25.1

2021-04-25 08:20:36

by Takashi Iwai

Subject: Re: [PATCH v1 1/2] ALSA: hda/cirrus: Set Initial DMIC volume for Bullseye to 16%

On Sat, 24 Apr 2021 16:32:43 +0200,
Vitaly Rodionov wrote:
>
> From: Stefan Binding <[email protected]>
>
> Tested on DELL Inspiron-3505, DELL Inspiron-3501, DELL Inspiron-3500

Could you give a bit more descriptions why this patch is needed?
And what do you mean 16%? The only meaningful measure is dB in the
h/w spec. Last but not least, why this value was chosen?


thanks,

Takashi

>
> Signed-off-by: Stefan Binding <[email protected]>
> Signed-off-by: Vitaly Rodionov <[email protected]>
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1923557
> Reported-and-tested-by: You-Sheng Yang <[email protected]>
> ---
> sound/pci/hda/patch_cirrus.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/sound/pci/hda/patch_cirrus.c b/sound/pci/hda/patch_cirrus.c
> index 5d57096b3a95..d6cf93b7483c 100644
> --- a/sound/pci/hda/patch_cirrus.c
> +++ b/sound/pci/hda/patch_cirrus.c
> @@ -2172,6 +2172,10 @@ static void cs8409_cs42l42_fixups(struct hda_codec *codec,
> (get_wcaps(codec, CS8409_CS42L42_AMIC_PIN_NID) | AC_WCAP_UNSOL_CAP));
> break;
> case HDA_FIXUP_ACT_PROBE:
> +
> + if (codec->fixup_id == CS8409_BULLSEYE)
> + snd_hda_codec_amp_init_stereo(codec, CS8409_CS42L42_DMIC_ADC_PIN_NID,
> + HDA_INPUT, 0, 0xff, 0x19);
> snd_hda_gen_add_kctl(&spec->gen,
> NULL, &cs8409_cs42l42_hp_volume_mixer);
> snd_hda_gen_add_kctl(&spec->gen,
> --
> 2.25.1
>