2012-10-22 13:07:29

by Denis Kirjanov

Subject: [PATCH] check for the kzalloc return value

Signed-off-by: Denis Kirjanov <[email protected]>
---
sound/pci/als300.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/sound/pci/als300.c b/sound/pci/als300.c
index 68c4469..e1f74d4 100644
--- a/sound/pci/als300.c
+++ b/sound/pci/als300.c
@@ -394,6 +394,8 @@ static int snd_als300_playback_open(struct snd_pcm_substream *substream)
struct snd_als300_substream_data *data = kzalloc(sizeof(*data),
GFP_KERNEL);

+ if (!data)
+ return -ENOMEM;
snd_als300_dbgcallenter();
chip->playback_substream = substream;
runtime->hw = snd_als300_playback_hw;
@@ -425,6 +427,8 @@ static int snd_als300_capture_open(struct snd_pcm_substream *substream)
struct snd_als300_substream_data *data = kzalloc(sizeof(*data),
GFP_KERNEL);

+ if (!data)
+ return -ENOMEM;
snd_als300_dbgcallenter();
chip->capture_substream = substream;
runtime->hw = snd_als300_capture_hw;
--
1.7.9.5

2012-10-22 14:33:11

by Takashi Iwai

Subject: Re: [PATCH] check for the kzalloc return value

At Mon, 22 Oct 2012 17:05:53 +0400,
Denis Kirjanov wrote:
>
>
> Signed-off-by: Denis Kirjanov <[email protected]>

Thanks, applied.


Takashi

> ---
> sound/pci/als300.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/sound/pci/als300.c b/sound/pci/als300.c
> index 68c4469..e1f74d4 100644
> --- a/sound/pci/als300.c
> +++ b/sound/pci/als300.c
> @@ -394,6 +394,8 @@ static int snd_als300_playback_open(struct snd_pcm_substream *substream)
> struct snd_als300_substream_data *data = kzalloc(sizeof(*data),
> GFP_KERNEL);
>
> + if (!data)
> + return -ENOMEM;
> snd_als300_dbgcallenter();
> chip->playback_substream = substream;
> runtime->hw = snd_als300_playback_hw;
> @@ -425,6 +427,8 @@ static int snd_als300_capture_open(struct snd_pcm_substream *substream)
> struct snd_als300_substream_data *data = kzalloc(sizeof(*data),
> GFP_KERNEL);
>
> + if (!data)
> + return -ENOMEM;
> snd_als300_dbgcallenter();
> chip->capture_substream = substream;
> runtime->hw = snd_als300_capture_hw;
> --
> 1.7.9.5
>