2012-10-19 14:32:39

by Joseph Salisbury

[permalink] [raw]
Subject: [PATCH 0/1] ALSA: hda - add quirk for Thinkpad T430

From: Joseph Salisbury <[email protected]>

BugLink: https://bugs.launchpad.net/bugs/1060372

This patch is to enable audio on T430 Thinkpads. There is no audo from the headphone jack without this patch. This patch adds a quirk for the T430 model.


== Test Case ==
A test kernel was built with this patch and tested by a bug reporter at the following bug:
BugLink: https://bugs.launchpad.net/bugs/1060372



Joseph Salisbury (1):
ALSA: hda - add quirk for Thinkpad T430

sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)

--
1.7.9.5


2012-10-19 14:32:41

by Joseph Salisbury

[permalink] [raw]
Subject: [PATCH 1/1] ALSA: hda - add quirk for Thinkpad T430

From: Joseph Salisbury <[email protected]>


Signed-off-by: Joseph Salisbury <[email protected]>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 739f968..18fce01 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6172,6 +6172,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x21e9, "Thinkpad Edge 15", ALC269_FIXUP_SKU_IGNORE),
SND_PCI_QUIRK(0x17aa, 0x21f6, "Thinkpad T530", ALC269_FIXUP_LENOVO_DOCK),
SND_PCI_QUIRK(0x17aa, 0x21fa, "Thinkpad X230", ALC269_FIXUP_LENOVO_DOCK),
+ SND_PCI_QUIRK(0x17aa, 0x21f3, "Thinkpad T430", ALC269_FIXUP_LENOVO_DOCK),
SND_PCI_QUIRK(0x17aa, 0x21fb, "Thinkpad T430s", ALC269_FIXUP_LENOVO_DOCK),
SND_PCI_QUIRK(0x17aa, 0x2203, "Thinkpad X230 Tablet", ALC269_FIXUP_LENOVO_DOCK),
SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K),
--
1.7.9.5

2012-10-19 17:00:59

by Jonathan Nieder

[permalink] [raw]
Subject: Re: [PATCH 0/1] ALSA: hda - add quirk for Thinkpad T430

Hi Joseph,

[email protected] wrote:

> [Subject: [PATCH 0/1] ALSA: hda - add quirk for Thinkpad T430]]
[...]
> This patch is to enable audio on T430 Thinkpads. There is no audo
> from the headphone jack without this patch. This patch adds a quirk
> for the T430 model.

Please don't do this cover-letter thing. A cover letter can be a
good way to *summarize* a long patch series so readers are less
daunted, but any information that was needed to know in order to
evaluate a patch, briefly stated, should be in the commit message that
actually gets committed.

Thanks and hope that helps,
Jonathan

2012-10-19 17:39:41

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 1/1] ALSA: hda - add quirk for Thinkpad T430

On Fri, Oct 19, 2012 at 10:32:30AM -0400, [email protected] wrote:
> From: Joseph Salisbury <[email protected]>
>
>
> Signed-off-by: Joseph Salisbury <[email protected]>
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

2012-10-19 19:54:30

by Jonathan Nieder

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] ALSA: hda - add quirk for Thinkpad T430

[email protected] wrote:

> This patch adds a quirk to enable headphone jack audio on T430 Thinkpads.
>
> Signed-off-by: Joseph Salisbury <[email protected]>
> Cc: <[email protected]>

Thanks --- this is a little better.

One more nit: it looks like this was reported, tested, and based on a
patch by Stefan Freyr. Takashi, could you amend the message to
reflect that, or should the patch be resent?

Something like

-- >8 --
From: Stefán Freyr <[email protected]>
Subject: ALSA: hda - add dock support for Thinkpad T430

I have a Lenovo ThinkPad T430 and an UltraBase Series 3 docking
station.

Without this patch, if I plug my headphones into the jack on the
computer, everything works fine. The computer speakers mute and the
audio is played in the headphones. However, if I plug into the docking
station headphone jack the computer speakers are muted but there is no
audio in the headphones.

Addresses https://bugs.launchpad.net/bugs/1060372

Signed-off-by: Joseph Salisbury <[email protected]>
Cc: [email protected]

2012-10-19 20:51:44

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] ALSA: hda - add quirk for Thinkpad T430

At Fri, 19 Oct 2012 12:54:21 -0700,
Jonathan Nieder wrote:
>
> [email protected] wrote:
>
> > This patch adds a quirk to enable headphone jack audio on T430 Thinkpads.
> >
> > Signed-off-by: Joseph Salisbury <[email protected]>
> > Cc: <[email protected]>
>
> Thanks --- this is a little better.
>
> One more nit: it looks like this was reported, tested, and based on a
> patch by Stefan Freyr. Takashi, could you amend the message to
> reflect that, or should the patch be resent?

Yes, applied now with the improved commit log.


thanks,

Takashi

>
> Something like
>
> -- >8 --
> From: Stefán Freyr <[email protected]>
> Subject: ALSA: hda - add dock support for Thinkpad T430
>
> I have a Lenovo ThinkPad T430 and an UltraBase Series 3 docking
> station.
>
> Without this patch, if I plug my headphones into the jack on the
> computer, everything works fine. The computer speakers mute and the
> audio is played in the headphones. However, if I plug into the docking
> station headphone jack the computer speakers are muted but there is no
> audio in the headphones.
>
> Addresses https://bugs.launchpad.net/bugs/1060372
>
> Signed-off-by: Joseph Salisbury <[email protected]>
> Cc: [email protected]
>