2022-03-11 14:45:29

by huangwenhui

Subject: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671

On a HP 288 Pro G8, the front mic could not be detected.In order to
get it working, the pin configuration needs to be set correctly, and
the ALC671_FIXUP_HP_HEADSET_MIC2 fixup needs to be applied.

Signed-off-by: huangwenhui <[email protected]>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 3a42457984e9..e9c9b1d1bf0d 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -11067,6 +11067,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = {
SND_PCI_QUIRK(0x1028, 0x069f, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x103c, 0x1632, "HP RP5800", ALC662_FIXUP_HP_RP5800),
SND_PCI_QUIRK(0x103c, 0x873e, "HP", ALC671_FIXUP_HP_HEADSET_MIC2),
+ SND_PCI_QUIRK(0x103c, 0x885f, "HP 288 Pro G8", ALC671_FIXUP_HP_HEADSET_MIC2),
SND_PCI_QUIRK(0x1043, 0x1080, "Asus UX501VW", ALC668_FIXUP_HEADSET_MODE),
SND_PCI_QUIRK(0x1043, 0x11cd, "Asus N550", ALC662_FIXUP_ASUS_Nx50),
SND_PCI_QUIRK(0x1043, 0x129d, "Asus N750", ALC662_FIXUP_ASUS_Nx50),
--
2.20.1

2022-03-11 22:04:35

by Takashi Iwai

Subject: Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671

On Fri, 11 Mar 2022 02:20:42 +0100,
huangwenhui wrote:
>
> Hi Takashi,
>
> if adjusting the mixer element or replugging the headset, the headphone would
> be unmuted.
> But most users hope that the default state is unmuted.
> Should this unconditional unmute be required?

It's the standard behavior for most of ALSA drivers.

The initial mute state is rather controlled via alsactl, restoring the
previous state. Also, the sound server like PulseAudio or pipewire
does unmute automatically. If this doesn't work as expected, that's a
more problem to diagnose.


Takashi

>
> Thanks.
>
> ------------------ Original ------------------
> From: "Takashi Iwai"<[email protected]>;
> Date: Thu, Mar 10, 2022 10:03 PM
> To: "黄文辉"<[email protected]>;
> Cc: "perex"<[email protected]>; "tiwai"<[email protected]>; "jeremy.szu"
> <[email protected]>; "hui.wang"<[email protected]>; "wse"
> <[email protected]>; "cam"<[email protected]>; "kailang"
> <[email protected]>; "tanureal"<[email protected]>; "sami"
> <[email protected]>; "alsa-devel"<[email protected]>; "linux-kernel"
> <[email protected]>;
> Subject: Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP
> machine with alc671
>
> On Thu, 10 Mar 2022 14:58:36 +0100,
> huangwenhui wrote:
> >
> > Hi Takashi,
> >
> > Thank you for your reply.
> >
> > When booting with plugged headset, the headphone will be muted.
>
> The muted state is the default behavior. Wouldn't it be unmuted if
> you adjust the corresponding mixer element?
>
> Takashi
>
> >
> > Thanks.
> >
> > ------------------ Original ------------------
> > From: "Takashi Iwai"<[email protected]>;
> > Date: Thu, Mar 10, 2022 09:29 PM
> > To: "huangwenhui"<[email protected]>;
> > Cc: "perex"<[email protected]>; "tiwai"<[email protected]>; "jeremy.szu"
> > <[email protected]>; "hui.wang"<[email protected]>; "wse"
> > <[email protected]>; "cam"<[email protected]>; "kailang"
> > <[email protected]>; "tanureal"<[email protected]>; "sami"
> > <[email protected]>; "alsa-devel"<[email protected]>; "linux-kernel"
> > <[email protected]>;
> > Subject: Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP
> > machine with alc671
> >
> > On Thu, 10 Mar 2022 14:03:01 +0100,
> > huangwenhui wrote:
> > >
> > > On a HP 288 Pro G8, the front Mic could not be detected.
> > >
> > > Signed-off-by: huangwenhui <[email protected]>
> >
> > Thanks for the patch. Most of the changes look OK, but one thing I
> > still don't get:
> >
> > > + case HDA_FIXUP_ACT_INIT:
> > > + alc_write_coef_idx(codec, 0x19, 0xa054);
> > > + msleep(80);
> > > + snd_hda_codec_write(codec, hp_pin, 0,
> > > + AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE);
> >
> > Why this unconditional unmute is required for fixing the mic problem?
> >
> > Takashi
> >
> >
>
>

2022-03-11 22:58:27

by Takashi Iwai

Subject: Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671

On Fri, 11 Mar 2022 10:38:36 +0100,
huangwenhui wrote:
>
> On a HP 288 Pro G8, the front mic could not be detected.In order to
> get it working, the pin configuration needs to be set correctly, and
> the ALC671_FIXUP_HP_HEADSET_MIC2 fixup needs to be applied.
>
> Signed-off-by: huangwenhui <[email protected]>

Thanks, applied now.


Takashi