2022-02-07 21:40:17

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH] ALSA: usb-audio: remove redundant assignment to variable c

On Mon, 07 Feb 2022 15:06:17 +0100,
Colin Ian King wrote:
>
> The variable c is being initialized in an outer for-loop and also
> re-initialized inside an inner for-loop. The first initialization
> is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <[email protected]>

The code change looks OK, but when I apply your patch now, git-am
converts the Author address to your new @intel.com, and this
mismatches with the address in Signed-off-by. Should I keep the
original gmail address, or would you fix up your Signed-off-by (and
From) for avoiding those inconsistency?


thanks,

Takashi