2021-01-15 15:44:30

by Colin King

[permalink] [raw]
Subject: [PATCH][next] ALSA: usb-audio: remove initialization of param_period_time_if_needed

From: Colin Ian King <[email protected]>

Variable param_period_time_if_needed is being initialized with a value
that is never read, the assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
sound/usb/pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index f71965bf815f..ed654338f6b7 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -934,7 +934,7 @@ static int setup_hw_info(struct snd_pcm_runtime *runtime, struct snd_usb_substre
{
const struct audioformat *fp;
unsigned int pt, ptmin;
- int param_period_time_if_needed = -1;
+ int param_period_time_if_needed;
int err;

runtime->hw.formats = subs->formats;
--
2.29.2


2021-01-15 15:56:20

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH][next] ALSA: usb-audio: remove initialization of param_period_time_if_needed

On Fri, 15 Jan 2021 16:41:51 +0100,
Colin King wrote:
>
> From: Colin Ian King <[email protected]>
>
> Variable param_period_time_if_needed is being initialized with a value
> that is never read, the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

This doesn't look applicable to the latest tree.
Could you check again?


thanks,

Takashi

> ---
> sound/usb/pcm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index f71965bf815f..ed654338f6b7 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -934,7 +934,7 @@ static int setup_hw_info(struct snd_pcm_runtime *runtime, struct snd_usb_substre
> {
> const struct audioformat *fp;
> unsigned int pt, ptmin;
> - int param_period_time_if_needed = -1;
> + int param_period_time_if_needed;
> int err;
>
> runtime->hw.formats = subs->formats;
> --
> 2.29.2
>