2024-05-25 17:44:13

by Bjorn Andersson

[permalink] [raw]
Subject: [PATCH 0/2] arm64: dts: qcom: sc8180x: Fix CPUfreq compatible

Signed-off-by: Bjorn Andersson <[email protected]>
---
Bjorn Andersson (2):
dt-bindings: cpufreq: cpufreq-qcom-hw: Add sc8180x compatible
arm64: dts: qcom: sc8180x: Correct cpufreq compatible

Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 1 +
arch/arm64/boot/dts/qcom/sc8180x.dtsi | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
---
base-commit: 3689b0ef08b70e4e03b82ebd37730a03a672853a
change-id: 20240525-sc8180x-cpufreq-compatible-633c45b93886

Best regards,
--
Bjorn Andersson <[email protected]>



2024-05-25 17:44:24

by Bjorn Andersson

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: cpufreq: cpufreq-qcom-hw: Add sc8180x compatible

From: Bjorn Andersson <[email protected]>

The SC8180X platform has a EPSS block, add a compatible for the SC8180X
platform.

Signed-off-by: Bjorn Andersson <[email protected]>
---
Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
index 1e9797f96410..24c02ee33266 100644
--- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
+++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
@@ -36,6 +36,7 @@ properties:
- qcom,qdu1000-cpufreq-epss
- qcom,sa8775p-cpufreq-epss
- qcom,sc7280-cpufreq-epss
+ - qcom,sc8180x-cpufreq-epss
- qcom,sc8280xp-cpufreq-epss
- qcom,sdx75-cpufreq-epss
- qcom,sm4450-cpufreq-epss

--
2.43.0


2024-05-25 17:44:37

by Bjorn Andersson

[permalink] [raw]
Subject: [PATCH 2/2] arm64: dts: qcom: sc8180x: Correct cpufreq compatible

From: Bjorn Andersson <[email protected]>

The Qualcomm EPSS CPUfreq binding requires a platform-specific
compatible, add this.

Signed-off-by: Bjorn Andersson <[email protected]>
---
arch/arm64/boot/dts/qcom/sc8180x.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
index 067712310560..1f103cb54f99 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
@@ -3733,7 +3733,7 @@ lmh@18358800 {
};

cpufreq_hw: cpufreq@18323000 {
- compatible = "qcom,cpufreq-hw";
+ compatible = "qcom,sc8180x-cpufreq-epss", "qcom,cpufreq-epss";
reg = <0 0x18323000 0 0x1400>, <0 0x18325800 0 0x1400>;
reg-names = "freq-domain0", "freq-domain1";


--
2.43.0


2024-05-25 20:11:29

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc8180x: Correct cpufreq compatible

On Sat, May 25, 2024 at 10:48:51AM -0700, Bjorn Andersson wrote:
> From: Bjorn Andersson <[email protected]>
>
> The Qualcomm EPSS CPUfreq binding requires a platform-specific
> compatible, add this.
>
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc8180x.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2024-05-26 18:23:59

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: cpufreq: cpufreq-qcom-hw: Add sc8180x compatible

On 25/05/2024 19:48, Bjorn Andersson wrote:
> From: Bjorn Andersson <[email protected]>
>
> The SC8180X platform has a EPSS block, add a compatible for the SC8180X
> platform.
>
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
> Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> index 1e9797f96410..24c02ee33266 100644
> --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> @@ -36,6 +36,7 @@ properties:
> - qcom,qdu1000-cpufreq-epss
> - qcom,sa8775p-cpufreq-epss
> - qcom,sc7280-cpufreq-epss
> + - qcom,sc8180x-cpufreq-epss

I think you forgot to update the allOf:if:then: entry.

Best regards,
Krzysztof


2024-05-26 20:35:19

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: cpufreq: cpufreq-qcom-hw: Add sc8180x compatible

On Sun, May 26, 2024 at 08:23:24PM GMT, Krzysztof Kozlowski wrote:
> On 25/05/2024 19:48, Bjorn Andersson wrote:
> > From: Bjorn Andersson <[email protected]>
> >
> > The SC8180X platform has a EPSS block, add a compatible for the SC8180X
> > platform.
> >
> > Signed-off-by: Bjorn Andersson <[email protected]>
> > ---
> > Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> > index 1e9797f96410..24c02ee33266 100644
> > --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> > +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> > @@ -36,6 +36,7 @@ properties:
> > - qcom,qdu1000-cpufreq-epss
> > - qcom,sa8775p-cpufreq-epss
> > - qcom,sc7280-cpufreq-epss
> > + - qcom,sc8180x-cpufreq-epss
>
> I think you forgot to update the allOf:if:then: entry.
>

Indeed, failed to spot that.

Thanks,
Bjorn