2004-06-28 17:38:12

by Andre Noll

Subject: nfsroot oops 2.6.7-current

Hi

Al's current changes to struct nameidata broke nfsroot for my discless
clients (oops in nfs_fill_super). The patch below fixes this problem
for me.

Andre

diff -u -r1.19 rpc_pipe.c
--- linux-2.5/net/sunrpc/rpc_pipe.c 31 May 2004 03:06:56 -0000 1.19
+++ linux-2.5/net/sunrpc/rpc_pipe.c 28 Jun 2004 17:10:51 -0000
@@ -433,6 +433,7 @@
nd->dentry = dget(rpc_mount->mnt_root);
nd->last_type = LAST_ROOT;
nd->flags = LOOKUP_PARENT;
+ nd->depth = 0;

if (path_walk(path, nd)) {
printk(KERN_WARNING "%s: %s failed to find path %s\n",
--
Andre Noll, http://www.mathematik.tu-darmstadt.de/~noll

2004-06-28 17:53:20

by Trond Myklebust

Subject: Re: nfsroot oops 2.6.7-current

Yep, and there's probably one missing in fs/nfsctl.c:do_open() too. Al?

Cheers,
Trond


P? m? , 28/06/2004 klokka 13:38, skreiv Andre Noll:
> Hi
>
> Al's current changes to struct nameidata broke nfsroot for my discless
> clients (oops in nfs_fill_super). The patch below fixes this problem
> for me.
>
> Andre
>
> diff -u -r1.19 rpc_pipe.c
> --- linux-2.5/net/sunrpc/rpc_pipe.c 31 May 2004 03:06:56 -0000 1.19
> +++ linux-2.5/net/sunrpc/rpc_pipe.c 28 Jun 2004 17:10:51 -0000
> @@ -433,6 +433,7 @@
> nd->dentry = dget(rpc_mount->mnt_root);
> nd->last_type = LAST_ROOT;
> nd->flags = LOOKUP_PARENT;
> + nd->depth = 0;
>
> if (path_walk(path, nd)) {
> printk(KERN_WARNING "%s: %s failed to find path %s\n",

2004-06-28 18:00:24

by Andrew Morton

Subject: Re: nfsroot oops 2.6.7-current

Andre Noll <[email protected]> wrote:
>
> --- linux-2.5/net/sunrpc/rpc_pipe.c 31 May 2004 03:06:56 -0000 1.19
> +++ linux-2.5/net/sunrpc/rpc_pipe.c 28 Jun 2004 17:10:51 -0000
> @@ -433,6 +433,7 @@
> nd->dentry = dget(rpc_mount->mnt_root);
> nd->last_type = LAST_ROOT;
> nd->flags = LOOKUP_PARENT;
> + nd->depth = 0;

Neat, thanks. Quite a few people have been hitting that.

2004-06-28 19:11:50

by Al Viro

Subject: Re: nfsroot oops 2.6.7-current

On Mon, Jun 28, 2004 at 01:53:13PM -0400, Trond Myklebust wrote:
> Yep, and there's probably one missing in fs/nfsctl.c:do_open() too. Al?

ACK