2022-01-27 09:13:47

by Xiaoke Wang

Subject: [PATCH v4] integrity: check the return value of audit_log_start()

From: Xiaoke Wang <[email protected]>

audit_log_start() returns audit_buffer pointer on success or NULL on
error, so it is better to check the return value of it.

Signed-off-by: Xiaoke Wang <[email protected]>
Reviewed-by: Paul Moore <[email protected]>
---
Changelogs:
V3 -> V4: update the mail list.
V2 -> V3: add the Reviewed-by tag.
V1 -> V2: simplify the patch.
security/integrity/integrity_audit.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/security/integrity/integrity_audit.c b/security/integrity/integrity_audit.c
index 2922005..0ec5e4c 100644
--- a/security/integrity/integrity_audit.c
+++ b/security/integrity/integrity_audit.c
@@ -45,6 +45,8 @@ void integrity_audit_message(int audit_msgno, struct inode *inode,
return;

ab = audit_log_start(audit_context(), GFP_KERNEL, audit_msgno);
+ if (!ab)
+ return;
audit_log_format(ab, "pid=%d uid=%u auid=%u ses=%u",
task_pid_nr(current),
from_kuid(&init_user_ns, current_uid()),
--

2022-01-27 09:14:43

by Mimi Zohar

Subject: Re: [PATCH v4] integrity: check the return value of audit_log_start()

Hi Xiaoke,

On Thu, 2022-01-27 at 09:59 +0800, Xiaoke Wang wrote:
> From: Xiaoke Wang <[email protected]>
>
> audit_log_start() returns audit_buffer pointer on success or NULL on
> error, so it is better to check the return value of it.
>
> Signed-off-by: Xiaoke Wang <[email protected]>
> Reviewed-by: Paul Moore <[email protected]>

Thanks, this patch is staged in the next-integrity-testing branch
https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git/

Mimi