2024-05-07 12:22:36

by Chen shuo

Subject: [PATCH] staging:rtl8192e:fixes unnecessary braces

This patch fixes the warnings reported by checkpatch.pl
for braces {} are not necessary for single statement blocks

Signed-off-by: Chen shuo <[email protected]>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index e3ed709a7674..1862a9899966 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1640,9 +1640,8 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats,
if (stats->Length < 24)
stats->bHwError |= 1;

- if (stats->bHwError) {
+ if (stats->bHwError)
return false;
- }

stats->RxDrvInfoSize = pdesc->RxDrvInfoSize;
stats->RxBufShift = (pdesc->Shift) & 0x03;
--
2.34.1

2024-05-07 17:51:36

by Philipp Hortmann

Subject: Re: [PATCH] staging:rtl8192e:fixes unnecessary braces

On 5/7/24 14:13, Chen shuo wrote:
> This patch fixes the warnings reported by checkpatch.pl
> for braces {} are not necessary for single statement blocks
>
> Signed-off-by: Chen shuo <[email protected]>
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index e3ed709a7674..1862a9899966 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -1640,9 +1640,8 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats,
> if (stats->Length < 24)
> stats->bHwError |= 1;
>
> - if (stats->bHwError) {
> + if (stats->bHwError)
> return false;
> - }
>
> stats->RxDrvInfoSize = pdesc->RxDrvInfoSize;
> stats->RxBufShift = (pdesc->Shift) & 0x03;


Hi Chen,

Please make your "Subject" line more unique. Consider that we may end up
with having dozen of commits like yours, all of them referring to
different removals and all without the necessary information to tell
what they differ in (except the driver/subsystem). So it would help if
you add the changed file or function to make it more unique.

Also typically we use space after : and driver name in the subject.

It is not required to add the name of the tool who found this. Much more
important is a good description __why__ this change makes sense...
For example:
.. to shorten code.
.. to improve readability.

If you send in a second version of this patch please use a change
history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

Feel free to contact me direct for further questions.

Thanks for your support.

Bye Philipp