2022-11-20 08:43:07

by Rong Tao

Subject: [PATCH bpf-next] docs/bpf: Update btf test programe code

From: Rong Tao <[email protected]>

commit c64779e24e88("selftests/bpf: Merge most of test_btf into
test_progs") rename selftests/bpf btf test from 'test_btf.c' to
'prog_tests/btf.c'.

Signed-off-by: Rong Tao <[email protected]>
---
Documentation/bpf/btf.rst | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/bpf/btf.rst b/Documentation/bpf/btf.rst
index cf8722f96090..59ccd9bad1e0 100644
--- a/Documentation/bpf/btf.rst
+++ b/Documentation/bpf/btf.rst
@@ -1062,4 +1062,5 @@ format.::
7. Testing
==========

-Kernel bpf selftest `test_btf.c` provides extensive set of BTF-related tests.
+Kernel bpf selftest `prog_tests/btf.c` provides extensive set of BTF-related
+tests.
--
2.38.1

2022-11-20 17:59:19

by David Vernet

Subject: Re: [PATCH bpf-next] docs/bpf: Update btf test programe code

On Sun, Nov 20, 2022 at 03:57:51PM +0800, Rong Tao wrote:
> From: Rong Tao <[email protected]>
>
> commit c64779e24e88("selftests/bpf: Merge most of test_btf into
> test_progs") rename selftests/bpf btf test from 'test_btf.c' to
> 'prog_tests/btf.c'.
>
> Signed-off-by: Rong Tao <[email protected]>
> ---
> Documentation/bpf/btf.rst | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/bpf/btf.rst b/Documentation/bpf/btf.rst
> index cf8722f96090..59ccd9bad1e0 100644
> --- a/Documentation/bpf/btf.rst
> +++ b/Documentation/bpf/btf.rst
> @@ -1062,4 +1062,5 @@ format.::
> 7. Testing
> ==========
>
> -Kernel bpf selftest `test_btf.c` provides extensive set of BTF-related tests.
> +Kernel bpf selftest `prog_tests/btf.c` provides extensive set of BTF-related

s/Kernel bpf selftest/The kernel BPF selftest

s/provide extensive/provides an extensive

> +tests.

Thanks for adjusting this. Could you please mirror what prog_lsm.rst
does [0], and add a link to the file in the linux.git repo?

[0]: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/tree/Documentation/bpf/prog_lsm.rst#n134

> --
> 2.38.1
>

2022-11-21 02:58:26

by Rong Tao

Subject: [PATCH bpf-next] docs/bpf: Update btf selftests program and add link

From: Rong Tao <[email protected]>

commit c64779e24e88("selftests/bpf: Merge most of test_btf into
test_progs") rename selftests/bpf btf test from 'test_btf.c' to
'prog_tests/btf.c'.

Signed-off-by: Rong Tao <[email protected]>
---
Documentation/bpf/btf.rst | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Documentation/bpf/btf.rst b/Documentation/bpf/btf.rst
index cf8722f96090..dca0b0e9dd35 100644
--- a/Documentation/bpf/btf.rst
+++ b/Documentation/bpf/btf.rst
@@ -1062,4 +1062,9 @@ format.::
7. Testing
==========

-Kernel bpf selftest `test_btf.c` provides extensive set of BTF-related tests.
+Kernel bpf selftest `tools/testing/selftests/bpf/prog_tests/btf.c`_ provides
+extensive set of BTF-related tests.
+
+.. Links
+.. _tools/testing/selftests/bpf/prog_tests/btf.c:
+ https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/tools/testing/selftests/bpf/prog_tests/btf.c
--
2.38.1

2022-11-21 07:54:03

by David Vernet

Subject: Re: [PATCH bpf-next] docs/bpf: Update btf selftests program and add link

On Mon, Nov 21, 2022 at 10:07:34AM +0800, Rong Tao wrote:
> From: Rong Tao <[email protected]>
>
> commit c64779e24e88("selftests/bpf: Merge most of test_btf into
> test_progs") rename selftests/bpf btf test from 'test_btf.c' to
> 'prog_tests/btf.c'.
>
> Signed-off-by: Rong Tao <[email protected]>
> ---

Please send this out as a v2 patch, as described in [0].

[0]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html

> Documentation/bpf/btf.rst | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/bpf/btf.rst b/Documentation/bpf/btf.rst
> index cf8722f96090..dca0b0e9dd35 100644
> --- a/Documentation/bpf/btf.rst
> +++ b/Documentation/bpf/btf.rst
> @@ -1062,4 +1062,9 @@ format.::
> 7. Testing
> ==========
>
> -Kernel bpf selftest `test_btf.c` provides extensive set of BTF-related tests.
> +Kernel bpf selftest `tools/testing/selftests/bpf/prog_tests/btf.c`_ provides

You added the hyperlink, but don't seem to have applied my other
suggestions. Please do so in v2.

> +extensive set of BTF-related tests.
> +
> +.. Links
> +.. _tools/testing/selftests/bpf/prog_tests/btf.c:
> + https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/tools/testing/selftests/bpf/prog_tests/btf.c
> --
> 2.38.1
>