2023-08-01 17:31:57

by Zhang Shurong

[permalink] [raw]
Subject: [PATCH v2] ASoC: rt5665: add missed regulator_bulk_disable

The driver forgets to call regulator_bulk_disable()

Add the missed call to fix it.

Fixes: 33ada14a26c8 ("ASoC: add rt5665 codec driver")
Signed-off-by: Zhang Shurong <[email protected]>
---
Changes in v2:
- move regulator_bulk_disable() in rt5665_remove()

sound/soc/codecs/rt5665.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/sound/soc/codecs/rt5665.c b/sound/soc/codecs/rt5665.c
index 83c367af91da..525713c33d71 100644
--- a/sound/soc/codecs/rt5665.c
+++ b/sound/soc/codecs/rt5665.c
@@ -4472,6 +4472,8 @@ static void rt5665_remove(struct snd_soc_component *component)
struct rt5665_priv *rt5665 = snd_soc_component_get_drvdata(component);

regmap_write(rt5665->regmap, RT5665_RESET, 0);
+
+ regulator_bulk_disable(ARRAY_SIZE(rt5665->supplies), rt5665->supplies);
}

#ifdef CONFIG_PM
--
2.30.2



2023-08-07 19:07:18

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v2] ASoC: rt5665: add missed regulator_bulk_disable

On Tue, 01 Aug 2023 23:59:11 +0800, Zhang Shurong wrote:
> The driver forgets to call regulator_bulk_disable()
>
> Add the missed call to fix it.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: rt5665: add missed regulator_bulk_disable
commit: c163108e706909570f8aa9aa5bcf6806e2b4c98c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark