2002-12-08 00:27:28

by Roger Luethi

[permalink] [raw]
Subject: [PATCH][2.5][Trivial] VIA Rhine Kconfig entry

Fix and update VIA Rhine description at least for 2.5 (I'll do 2.4, too, if
there's interest). Removed "experimental" flag for Rhine MMIO while I was
at it. Just barely resisted the temptation to make VIA Rhine conflict with
IO-APIC -- that seems to emerge as a fatal combo.

Please apply.

Roger


Attachments:
(No filename) (297.00 B)
Kconfig-via-rhine.diff (1.41 kB)
Download all attachments

2002-12-08 03:08:51

by Jeff Garzik

[permalink] [raw]
Subject: Re: [PATCH][2.5][Trivial] VIA Rhine Kconfig entry

Roger Luethi wrote:
> at it. Just barely resisted the temptation to make VIA Rhine conflict with
> IO-APIC -- that seems to emerge as a fatal combo.


Patch looks ok to me, I'll queue it.

I agree about IO-APIC -- though I also think the reports that replacing
via-rhine with linuxfet, and changing nothing else, helps the situation.

It might be something cosmetic like silly dev->tx_timeout handling, or
it might be something useful like a chip-specific patch [often happens
with on-mobo chips] or even a north/south-bridge-specific fixup.

Jeff



2002-12-10 13:20:47

by Roger Luethi

[permalink] [raw]
Subject: Re: [PATCH][2.5][Trivial] VIA Rhine Kconfig entry

On Sat, 07 Dec 2002 22:15:42 -0500, Jeff Garzik wrote:
> I agree about IO-APIC -- though I also think the reports that replacing
> via-rhine with linuxfet, and changing nothing else, helps the situation.
>
> It might be something cosmetic like silly dev->tx_timeout handling, or
> it might be something useful like a chip-specific patch [often happens
> with on-mobo chips] or even a north/south-bridge-specific fixup.

There are two different kinds of Rhine problems that are reportedly fixed
by turning apic support off:

a) No link, card's dead in the water
b) Netdev watchdog triggered despite recent Tx abort fix

No telling whether the cause is the same for both cases. I don't have
sufficient data on mobos or chip sets involved and where linuxfet helps. As
I am currently short on APIC hardware myself, I'll focus on clean ups and
improved diagnostics for now.

Roger

2002-12-10 19:11:41

by Steve Brueggeman

[permalink] [raw]
Subject: Re: [PATCH][2.5][Trivial] VIA Rhine Kconfig entry

Is it possible that this may be related to this thread???

To: Linus Torvalds <[email protected]>
Subject: Re: /proc/pci deprecation?
From: Alan Cox <[email protected]>
Date: 09 Dec 2002 14:11:07 +0000
Cc: Richard Henderson <[email protected]>,
Patrick Mochel <[email protected]>,
Willy Tarreau <[email protected]>,
Petr Vandrovec <[email protected]>,
Linux Kernel Mailing List <[email protected]>,
[email protected]

On Mon, 2002-12-09 at 01:54, Linus Torvalds wrote:
> - we should _never_ update the PCI_INTERRUPT_LINE register, because it
> destroys boot loader information (the same way we need to not overwrite
> BIOS extended areas and ACPI areas etc in order to be able to reboot
> cleanly)

I wonder if this is why we have all these problems with VIA chipset
interrupt handling. According to VIA docs they _do_ use
PCI_INTERRUPT_LINE on integrated devices to select the IRQ routing
between APIC and PCI/ISA etc, as well as 0 meaning "IRQ disabled"

Alan



On Tue, 10 Dec 2002 14:28:14 +0100, you wrote:

>On Sat, 07 Dec 2002 22:15:42 -0500, Jeff Garzik wrote:
>> I agree about IO-APIC -- though I also think the reports that replacing
>> via-rhine with linuxfet, and changing nothing else, helps the situation.
>>
>> It might be something cosmetic like silly dev->tx_timeout handling, or
>> it might be something useful like a chip-specific patch [often happens
>> with on-mobo chips] or even a north/south-bridge-specific fixup.
>
>There are two different kinds of Rhine problems that are reportedly fixed
>by turning apic support off:
>
>a) No link, card's dead in the water
>b) Netdev watchdog triggered despite recent Tx abort fix
>
>No telling whether the cause is the same for both cases. I don't have
>sufficient data on mobos or chip sets involved and where linuxfet helps. As
>I am currently short on APIC hardware myself, I'll focus on clean ups and
>improved diagnostics for now.
>
>Roger
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to [email protected]
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/

2002-12-10 22:20:52

by Alan

[permalink] [raw]
Subject: Re: [PATCH][2.5][Trivial] VIA Rhine Kconfig entry

On Tue, 2002-12-10 at 19:19, Steve Brueggeman wrote:
> Is it possible that this may be related to this thread???

I am sure it is