2014-10-17 20:02:07

by Fabian Frédérick

Subject: [PATCH 4/4 linux-next] x86, msr: use seek definitions instead of hard-coded values

Replace 0/1 by SEEK_SET/SEEK_CUR.

Signed-off-by: Fabian Frederick <[email protected]>
---
arch/x86/kernel/msr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c
index 1c66cd0..1ed1190 100644
--- a/arch/x86/kernel/msr.c
+++ b/arch/x86/kernel/msr.c
@@ -52,11 +52,11 @@ static loff_t msr_seek(struct file *file, loff_t offset, int orig)

mutex_lock(&inode->i_mutex);
switch (orig) {
- case 0:
+ case SEEK_SET:
file->f_pos = offset;
ret = file->f_pos;
break;
- case 1:
+ case SEEK_CUR:
file->f_pos += offset;
ret = file->f_pos;
break;
--
1.9.3

2014-10-17 20:47:39

by tip-bot for Vasyl Gomonovych

Subject: [tip:x86/cleanups] x86, msr: Use seek definitions instead of hard-coded values

Commit-ID: 03452d27c6cd9cebb59a6bb0fb6bd8557916c263
Gitweb: http://git.kernel.org/tip/03452d27c6cd9cebb59a6bb0fb6bd8557916c263
Author: Fabian Frederick <[email protected]>
AuthorDate: Fri, 17 Oct 2014 22:01:59 +0200
Committer: H. Peter Anvin <[email protected]>
CommitDate: Fri, 17 Oct 2014 13:40:55 -0700

x86, msr: Use seek definitions instead of hard-coded values

Replace 0/1 by SEEK_SET/SEEK_CUR.

Signed-off-by: Fabian Frederick <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: H. Peter Anvin <[email protected]>
---
arch/x86/kernel/msr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c
index 826c8b0..113e707 100644
--- a/arch/x86/kernel/msr.c
+++ b/arch/x86/kernel/msr.c
@@ -52,11 +52,11 @@ static loff_t msr_seek(struct file *file, loff_t offset, int orig)

mutex_lock(&inode->i_mutex);
switch (orig) {
- case 0:
+ case SEEK_SET:
file->f_pos = offset;
ret = file->f_pos;
break;
- case 1:
+ case SEEK_CUR:
file->f_pos += offset;
ret = file->f_pos;
break;