2012-08-05 16:45:30

by Namhyung Kim

[permalink] [raw]
Subject: [tip:perf/urgent] perf target: Fix check on buffer size

Commit-ID: 0ecf4f0c02b7802de5d1251e03e6eab360f158e1
Gitweb: http://git.kernel.org/tip/0ecf4f0c02b7802de5d1251e03e6eab360f158e1
Author: Namhyung Kim <[email protected]>
AuthorDate: Thu, 26 Jul 2012 10:50:10 +0900
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 1 Aug 2012 18:42:54 -0300

perf target: Fix check on buffer size

It was a mistake just replace assert to BUG_ON since its condition
should be negated. Fix it.

Signed-off-by: Namhyung Kim <[email protected]>
Cc: "Kirill A. Shutemov" <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Kirill A. Shutemov <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Ulrich Drepper <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/util/target.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/target.c b/tools/perf/util/target.c
index 3f59c49..051eaa6 100644
--- a/tools/perf/util/target.c
+++ b/tools/perf/util/target.c
@@ -110,7 +110,7 @@ int perf_target__strerror(struct perf_target *target, int errnum,
int idx;
const char *msg;

- BUG_ON(buflen > 0);
+ BUG_ON(buflen == 0);

if (errnum >= 0) {
const char *err = strerror_r(errnum, buf, buflen);