2009-12-21 09:58:15

by tip-bot for Wenji Huang

Subject: [PATCH] perf: fix typo in builtin-kmem.c

Replace bytes_req with bytes_alloc.

Signed-off-by: Wenji Huang <[email protected]>
---
tools/perf/builtin-kmem.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
index fc21ad7..7ceb741 100644
--- a/tools/perf/builtin-kmem.c
+++ b/tools/perf/builtin-kmem.c
@@ -137,7 +137,7 @@ static void insert_alloc_stat(unsigned long call_site, unsigned long ptr,
if (data && data->ptr == ptr) {
data->hit++;
data->bytes_req += bytes_req;
- data->bytes_alloc += bytes_req;
+ data->bytes_alloc += bytes_alloc;
} else {
data = malloc(sizeof(*data));
if (!data)
@@ -177,7 +177,7 @@ static void insert_caller_stat(unsigned long call_site,
if (data && data->call_site == call_site) {
data->hit++;
data->bytes_req += bytes_req;
- data->bytes_alloc += bytes_req;
+ data->bytes_alloc += bytes_alloc;
} else {
data = malloc(sizeof(*data));
if (!data)
--
1.5.6

2009-12-22 03:14:21

by Li Zefan

Subject: Re: [PATCH] perf: fix typo in builtin-kmem.c

Wenji Huang wrote:
> Replace bytes_req with bytes_alloc.
>

Thanks!

Reviewed-by: Li Zefan <[email protected]>

> Signed-off-by: Wenji Huang <[email protected]>
> ---
> tools/perf/builtin-kmem.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
> index fc21ad7..7ceb741 100644
> --- a/tools/perf/builtin-kmem.c
> +++ b/tools/perf/builtin-kmem.c
> @@ -137,7 +137,7 @@ static void insert_alloc_stat(unsigned long call_site, unsigned long ptr,
> if (data && data->ptr == ptr) {
> data->hit++;
> data->bytes_req += bytes_req;
> - data->bytes_alloc += bytes_req;
> + data->bytes_alloc += bytes_alloc;
> } else {
> data = malloc(sizeof(*data));
> if (!data)
> @@ -177,7 +177,7 @@ static void insert_caller_stat(unsigned long call_site,
> if (data && data->call_site == call_site) {
> data->hit++;
> data->bytes_req += bytes_req;
> - data->bytes_alloc += bytes_req;
> + data->bytes_alloc += bytes_alloc;
> } else {
> data = malloc(sizeof(*data));
> if (!data)

2009-12-28 10:09:34

by tip-bot for Wenji Huang

Subject: [tip:perf/urgent] perf kmem: Fix statistics typo

Commit-ID: 4efb5290ae187514bd31af8c2d7755e175245e19
Gitweb: http://git.kernel.org/tip/4efb5290ae187514bd31af8c2d7755e175245e19
Author: Wenji Huang <[email protected]>
AuthorDate: Mon, 21 Dec 2009 17:52:55 +0800
Committer: Ingo Molnar <[email protected]>
CommitDate: Mon, 28 Dec 2009 10:31:56 +0100

perf kmem: Fix statistics typo

Replace bytes_req with bytes_alloc.

Signed-off-by: Wenji Huang <[email protected]>
Reviewed-by: Li Zefan <[email protected]>
Cc: [email protected]
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
---
tools/perf/builtin-kmem.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
index fc21ad7..7ceb741 100644
--- a/tools/perf/builtin-kmem.c
+++ b/tools/perf/builtin-kmem.c
@@ -137,7 +137,7 @@ static void insert_alloc_stat(unsigned long call_site, unsigned long ptr,
if (data && data->ptr == ptr) {
data->hit++;
data->bytes_req += bytes_req;
- data->bytes_alloc += bytes_req;
+ data->bytes_alloc += bytes_alloc;
} else {
data = malloc(sizeof(*data));
if (!data)
@@ -177,7 +177,7 @@ static void insert_caller_stat(unsigned long call_site,
if (data && data->call_site == call_site) {
data->hit++;
data->bytes_req += bytes_req;
- data->bytes_alloc += bytes_req;
+ data->bytes_alloc += bytes_alloc;
} else {
data = malloc(sizeof(*data));
if (!data)