2009-07-01 14:24:58

by Jaswinder Singh Rajput

Subject: [PATCH -tip] x86: mm/init.c declare check_efer() before it get used

This sparse warning:

arch/x86/mm/init.c:83:16: warning: symbol 'check_efer' was not declared. Should it be static?

triggers because check_efer() is not decalared before using it.
asm/proto.h includes the declaration of check_efer(),
so including asm/proto.h to fix that - this also address the sparse warning.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/x86/mm/init.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
index 47ce9a2..0607119 100644
--- a/arch/x86/mm/init.c
+++ b/arch/x86/mm/init.c
@@ -12,6 +12,7 @@
#include <asm/system.h>
#include <asm/tlbflush.h>
#include <asm/tlb.h>
+#include <asm/proto.h>

DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);

--
1.6.0.6

2009-07-01 14:55:40

by Jaswinder Singh Rajput

Subject: [tip:x86/urgent] x86: Declare check_efer() before it gets used

Commit-ID: 76c06927f2a78143763dcff9b4c362d15eb29cc2
Gitweb: http://git.kernel.org/tip/76c06927f2a78143763dcff9b4c362d15eb29cc2
Author: Jaswinder Singh Rajput <[email protected]>
AuthorDate: Wed, 1 Jul 2009 19:54:23 +0530
Committer: Ingo Molnar <[email protected]>
CommitDate: Wed, 1 Jul 2009 16:52:54 +0200

x86: Declare check_efer() before it gets used

This sparse warning:

arch/x86/mm/init.c:83:16: warning: symbol 'check_efer' was not declared. Should it be static?

triggers because check_efer() is not decalared before using it.
asm/proto.h includes the declaration of check_efer(), so
including asm/proto.h to fix that - this also addresses the
sparse warning.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
Cc: Andrew Morton <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>


---
arch/x86/mm/init.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
index 47ce9a2..0607119 100644
--- a/arch/x86/mm/init.c
+++ b/arch/x86/mm/init.c
@@ -12,6 +12,7 @@
#include <asm/system.h>
#include <asm/tlbflush.h>
#include <asm/tlb.h>
+#include <asm/proto.h>

DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);