2009-06-14 06:53:09

by wu zhangjin

Subject: [PATCH] tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h

From: Wu Zhangjin <[email protected]>

when compiling linux-mips with kmemtrace enabled, there will be an
error:

include/linux/trace_seq.h:12: error: 'PAGE_SIZE' undeclared here (not in
a function)

I checked the source code and found trace_seq.h used PAGE_SIZE but not
included the relative header file, so, fix it via adding the header file
<asm/page.h>

Acked-by: Pekka Enberg <[email protected]>
Signed-off-by: Wu Zhangjin <[email protected]>
---
include/linux/trace_seq.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/trace_seq.h b/include/linux/trace_seq.h
index c68bccb..c134dd1 100644
--- a/include/linux/trace_seq.h
+++ b/include/linux/trace_seq.h
@@ -3,6 +3,8 @@

#include <linux/fs.h>

+#include <asm/page.h>
+
/*
* Trace sequences are used to allow a function to call several other functions
* to create a string of data to use (up to a max of PAGE_SIZE.
--
1.6.0.4

2009-06-14 12:35:30

by Frederic Weisbecker

Subject: Re: [PATCH] tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h

On Sun, Jun 14, 2009 at 02:52:30PM +0800, Wu Zhangjin wrote:
> From: Wu Zhangjin <[email protected]>
>
> when compiling linux-mips with kmemtrace enabled, there will be an
> error:
>
> include/linux/trace_seq.h:12: error: 'PAGE_SIZE' undeclared here (not in
> a function)
>
> I checked the source code and found trace_seq.h used PAGE_SIZE but not
> included the relative header file, so, fix it via adding the header file
> <asm/page.h>
>
> Acked-by: Pekka Enberg <[email protected]>
> Signed-off-by: Wu Zhangjin <[email protected]>


Acked-by: Frederic Weisbecker <[email protected]>


> ---
> include/linux/trace_seq.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/trace_seq.h b/include/linux/trace_seq.h
> index c68bccb..c134dd1 100644
> --- a/include/linux/trace_seq.h
> +++ b/include/linux/trace_seq.h
> @@ -3,6 +3,8 @@
>
> #include <linux/fs.h>
>
> +#include <asm/page.h>
> +
> /*
> * Trace sequences are used to allow a function to call several other functions
> * to create a string of data to use (up to a max of PAGE_SIZE.
> --
> 1.6.0.4
>

2009-06-15 18:13:48

by tip-bot for Wu Zhangjin

Subject: [tip:tracing/urgent] tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h

Commit-ID: 78be6914cb5c6d648617c51bb99bf81f28471d89
Gitweb: http://git.kernel.org/tip/78be6914cb5c6d648617c51bb99bf81f28471d89
Author: Wu Zhangjin <[email protected]>
AuthorDate: Sun, 14 Jun 2009 14:52:30 +0800
Committer: Steven Rostedt <[email protected]>
CommitDate: Mon, 15 Jun 2009 11:37:09 -0400

tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h

when compiling linux-mips with kmemtrace enabled, there will be an
error:

include/linux/trace_seq.h:12: error: 'PAGE_SIZE' undeclared here (not in
a function)

I checked the source code and found trace_seq.h used PAGE_SIZE but not
included the relative header file, so, fix it via adding the header file
<asm/page.h>

Acked-by: Frederic Weisbecker <[email protected]>
Acked-by: Pekka Enberg <[email protected]>
Signed-off-by: Wu Zhangjin <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by: Steven Rostedt <[email protected]>


---
include/linux/trace_seq.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/trace_seq.h b/include/linux/trace_seq.h
index c68bccb..c134dd1 100644
--- a/include/linux/trace_seq.h
+++ b/include/linux/trace_seq.h
@@ -3,6 +3,8 @@

#include <linux/fs.h>

+#include <asm/page.h>
+
/*
* Trace sequences are used to allow a function to call several other functions
* to create a string of data to use (up to a max of PAGE_SIZE.