2011-03-23 15:31:45

by Rakib Mullick

Subject: [PATCH] x86, mpparse: Reduce memory footprint

Reduce extra memory footprint overhead. ret isn't used by check_slot,
gets initialized but no real use, so remove it.

Signed-off-by: Rakib Mullick <[email protected]>
---

diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c
index 6f789a8..ef32d4c 100644
--- a/arch/x86/kernel/mpparse.c
+++ b/arch/x86/kernel/mpparse.c
@@ -722,14 +722,12 @@ inline void __init check_irq_src(struct
mpc_intsrc *m, int *nr_m_spare) {}
static int
check_slot(unsigned long mpc_new_phys, unsigned long mpc_new_length, int count)
{
- int ret = 0;
-
if (!mpc_new_phys || count <= mpc_new_length) {
WARN(1, "update_mptable: No spare slots (length: %x)\n", count);
return -1;
}

- return ret;
+ return 0;
}

static int __init replace_intsrc_all(struct mpc_table *mpc,

2011-03-24 09:02:20

by Rakib Mullick

Subject: [tip:x86/cleanups] x86, mpparse: Remove unnecessary variable

Commit-ID: 9f1f1bfd8d7e579f07dbe56d6f93bd594da43b3d
Gitweb: http://git.kernel.org/tip/9f1f1bfd8d7e579f07dbe56d6f93bd594da43b3d
Author: Rakib Mullick <[email protected]>
AuthorDate: Wed, 23 Mar 2011 21:31:40 +0600
Committer: Ingo Molnar <[email protected]>
CommitDate: Thu, 24 Mar 2011 09:05:40 +0100

x86, mpparse: Remove unnecessary variable

'ret' isn't used by check_slot(), gets initialized but has no real use,
so remove it.

Signed-off-by: Rakib Mullick <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
---
arch/x86/kernel/mpparse.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c
index 6f789a8..ef32d4c 100644
--- a/arch/x86/kernel/mpparse.c
+++ b/arch/x86/kernel/mpparse.c
@@ -722,14 +722,12 @@ inline void __init check_irq_src(struct mpc_intsrc *m, int *nr_m_spare) {}
static int
check_slot(unsigned long mpc_new_phys, unsigned long mpc_new_length, int count)
{
- int ret = 0;
-
if (!mpc_new_phys || count <= mpc_new_length) {
WARN(1, "update_mptable: No spare slots (length: %x)\n", count);
return -1;
}

- return ret;
+ return 0;
}

static int __init replace_intsrc_all(struct mpc_table *mpc,