2010-12-22 11:29:24

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: [tip:perf/urgent] perf buildid-list: Fix error return for success

Commit-ID: bbde588bfacb990542eed043d89c8591d4ae9211
Gitweb: http://git.kernel.org/tip/bbde588bfacb990542eed043d89c8591d4ae9211
Author: Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Thu, 16 Dec 2010 09:43:47 -0200
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Thu, 16 Dec 2010 09:43:47 -0200

perf buildid-list: Fix error return for success

It was always returning -1 (255), confusing test scripts.

Reported-by: Han Pingtian <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Han Pingtian <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Mike Galbraith <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Stephane Eranian <[email protected]>
Cc: Tom Zanussi <[email protected]>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/builtin-buildid-list.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-buildid-list.c b/tools/perf/builtin-buildid-list.c
index 44a47e1..c49837d 100644
--- a/tools/perf/builtin-buildid-list.c
+++ b/tools/perf/builtin-buildid-list.c
@@ -36,7 +36,6 @@ static const struct option options[] = {

static int __cmd_buildid_list(void)
{
- int err = -1;
struct perf_session *session;

session = perf_session__new(input_name, O_RDONLY, force, false);
@@ -49,7 +48,7 @@ static int __cmd_buildid_list(void)
perf_session__fprintf_dsos_buildid(session, stdout, with_hits);

perf_session__delete(session);
- return err;
+ return 0;
}

int cmd_buildid_list(int argc, const char **argv, const char *prefix __used)