2009-10-05 07:00:09

by Jayson R. King

Subject: [PATCH] sched: Remove obsolete comment in sched_init()

Remove the comment about calling alloc_bootmem() as it is not called
here since commit 36b7b6d465489c4754c4fd66fcec6086eba87896.

Signed-off-by: Jayson R. King <[email protected]>
---
kernel/sched.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index 1535f38..d68ac0e 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -9334,10 +9334,6 @@ void __init sched_init(void)
#ifdef CONFIG_CPUMASK_OFFSTACK
alloc_size += num_possible_cpus() * cpumask_size();
#endif
- /*
- * As sched_init() is called before page_alloc is setup,
- * we use alloc_bootmem().
- */
if (alloc_size) {
ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);

2009-10-05 10:02:51

by Ingo Molnar

Subject: Re: [PATCH] sched: Remove obsolete comment in sched_init()

* Jayson R. King <[email protected]> wrote:

> Remove the comment about calling alloc_bootmem() as it is not called
> here since commit 36b7b6d465489c4754c4fd66fcec6086eba87896.
>
> Signed-off-by: Jayson R. King <[email protected]>
> ---
> kernel/sched.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/kernel/sched.c b/kernel/sched.c
> index 1535f38..d68ac0e 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -9334,10 +9334,6 @@ void __init sched_init(void)
> #ifdef CONFIG_CPUMASK_OFFSTACK
> alloc_size += num_possible_cpus() * cpumask_size();
> #endif
> - /*
> - * As sched_init() is called before page_alloc is setup,
> - * we use alloc_bootmem().
> - */
> if (alloc_size) {
> ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);

Looks good. The patch is whitespace damaged though (all tabs are spaces)
- please consult Documentation/email-clients.txt and resend the patch.

Thanks,

Ingo

2009-10-05 10:23:06

by Jayson R. King

Subject: [PATCH] sched: Remove obsolete comment in sched_init()

Remove the comment about calling alloc_bootmem() as it is not called
here since commit 36b7b6d465489c4754c4fd66fcec6086eba87896.

Signed-off-by: Jayson R. King <[email protected]>
---
sched.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index 1535f38..d68ac0e 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -9334,10 +9334,6 @@ void __init sched_init(void)
#ifdef CONFIG_CPUMASK_OFFSTACK
alloc_size += num_possible_cpus() * cpumask_size();
#endif
- /*
- * As sched_init() is called before page_alloc is setup,
- * we use alloc_bootmem().
- */
if (alloc_size) {
ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);

2009-10-05 19:28:56

by Jayson R. King

Subject: Re: [PATCH] sched: Remove obsolete comment in sched_init()

Did that take care of the mangling?

Jayson

2009-10-05 19:40:50

by Jayson R. King

Subject: [tip:sched/core] sched: Remove obsolete comment in sched_init()

Commit-ID: cf82ff7ea7695b0e82ba07bc5e9f1bd03a74e1aa
Gitweb: http://git.kernel.org/tip/cf82ff7ea7695b0e82ba07bc5e9f1bd03a74e1aa
Author: Jayson R. King <[email protected]>
AuthorDate: Mon, 5 Oct 2009 05:21:26 -0500
Committer: Ingo Molnar <[email protected]>
CommitDate: Mon, 5 Oct 2009 21:37:22 +0200

sched: Remove obsolete comment in sched_init()

Remove the comment about calling alloc_bootmem() as it is not
called here since commit 36b7b6d465489c4754c4fd66fcec6086eba87896.

Signed-off-by: Jayson R. King <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Jiri Kosina <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
---
kernel/sched.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index 830967e..a56446d 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -9322,10 +9322,6 @@ void __init sched_init(void)
#ifdef CONFIG_CPUMASK_OFFSTACK
alloc_size += num_possible_cpus() * cpumask_size();
#endif
- /*
- * As sched_init() is called before page_alloc is setup,
- * we use alloc_bootmem().
- */
if (alloc_size) {
ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);