2009-10-10 15:38:59

by Thomas Gleixner

Subject: [patch 20/28] input: Remove BKL from hp_sdc_rtc

cycle_kernel_lock() was added during the big BKL pushdown. It should
ensure the serializiation against driver init code. In this case there
is nothing to serialize. Remove it.

Signed-off-by: Thomas Gleixner <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Dmitry Torokhov <[email protected]>
---
drivers/input/misc/hp_sdc_rtc.c | 2 --
1 file changed, 2 deletions(-)

Index: linux-2.6-tip/drivers/input/misc/hp_sdc_rtc.c
===================================================================
--- linux-2.6-tip.orig/drivers/input/misc/hp_sdc_rtc.c
+++ linux-2.6-tip/drivers/input/misc/hp_sdc_rtc.c
@@ -35,7 +35,6 @@

#include <linux/hp_sdc.h>
#include <linux/errno.h>
-#include <linux/smp_lock.h>
#include <linux/types.h>
#include <linux/init.h>
#include <linux/module.h>
@@ -409,7 +408,6 @@ static unsigned int hp_sdc_rtc_poll(stru

static int hp_sdc_rtc_open(struct inode *inode, struct file *file)
{
- cycle_kernel_lock();
return 0;
}

2009-10-11 19:48:41

by Arnd Bergmann

Subject: Re: [patch 20/28] input: Remove BKL from hp_sdc_rtc

On Saturday 10 October 2009, Thomas Gleixner wrote:
> cycle_kernel_lock() was added during the big BKL pushdown. It should
> ensure the serializiation against driver init code. In this case there
> is nothing to serialize. Remove it.

The driver still holds the BKL in its ioctl method, which should be removed
as well if the above is true.

Arnd <><

2009-10-11 19:56:08

by Thomas Gleixner

Subject: Re: [patch 20/28] input: Remove BKL from hp_sdc_rtc

On Sun, 11 Oct 2009, Arnd Bergmann wrote:

> On Saturday 10 October 2009, Thomas Gleixner wrote:
> > cycle_kernel_lock() was added during the big BKL pushdown. It should
> > ensure the serializiation against driver init code. In this case there
> > is nothing to serialize. Remove it.
>
> The driver still holds the BKL in its ioctl method, which should be removed
> as well if the above is true.

On my list already :)

2009-10-14 15:51:09

by Thomas Gleixner

Subject: [tip:bkl/drivers] input: Remove BKL from hp_sdc_rtc

Commit-ID: d2d23559857e5f34762c61487f8ffb2fa4d7442d
Gitweb: http://git.kernel.org/tip/d2d23559857e5f34762c61487f8ffb2fa4d7442d
Author: Thomas Gleixner <[email protected]>
AuthorDate: Sat, 10 Oct 2009 12:41:43 +0200
Committer: Thomas Gleixner <[email protected]>
CommitDate: Wed, 14 Oct 2009 17:36:51 +0200

input: Remove BKL from hp_sdc_rtc

cycle_kernel_lock() was added during the big BKL pushdown. It should
ensure the serializiation against driver init code. In this case there
is nothing to serialize. Remove it.

Signed-off-by: Thomas Gleixner <[email protected]>
LKML-Reference: <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Dmitry Torokhov <[email protected]>
---
drivers/input/misc/hp_sdc_rtc.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/input/misc/hp_sdc_rtc.c b/drivers/input/misc/hp_sdc_rtc.c
index 216a559..4d1aa9a 100644
--- a/drivers/input/misc/hp_sdc_rtc.c
+++ b/drivers/input/misc/hp_sdc_rtc.c
@@ -35,7 +35,6 @@

#include <linux/hp_sdc.h>
#include <linux/errno.h>
-#include <linux/smp_lock.h>
#include <linux/types.h>
#include <linux/init.h>
#include <linux/module.h>
@@ -409,7 +408,6 @@ static unsigned int hp_sdc_rtc_poll(struct file *file, poll_table *wait)

static int hp_sdc_rtc_open(struct inode *inode, struct file *file)
{
- cycle_kernel_lock();
return 0;
}