2012-02-16 13:54:41

by Danny Kukawka

[permalink] [raw]
Subject: [PATCH] tools/perf/util/probe-event.c included string.h twice

tools/perf/util/probe-event.c included 'string.h' twice,
remove the duplicate.

Signed-off-by: Danny Kukawka <[email protected]>
---
tools/perf/util/probe-event.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 29cb654..8ce8356 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -34,7 +34,6 @@

#include "util.h"
#include "event.h"
-#include "string.h"
#include "strlist.h"
#include "debug.h"
#include "cache.h"
--
1.7.8.3


Subject: Re: [PATCH] tools/perf/util/probe-event.c included string.h twice

(2012/02/16 22:54), Danny Kukawka wrote:
> tools/perf/util/probe-event.c included 'string.h' twice,
> remove the duplicate.

Right, since perf-defined string util functions(in util/string.c)
are declared in util.h, not string.h.

>
> Signed-off-by: Danny Kukawka <[email protected]>

Acked-by: Masami Hiramatsu <[email protected]>

Thank you!

> ---
> tools/perf/util/probe-event.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 29cb654..8ce8356 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -34,7 +34,6 @@
>
> #include "util.h"
> #include "event.h"
> -#include "string.h"
> #include "strlist.h"
> #include "debug.h"
> #include "cache.h"


--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: [email protected]

2012-02-22 16:03:59

by Danny Kukawka

[permalink] [raw]
Subject: [tip:perf/core] perf tools: Remove duplicated string.h includes

Commit-ID: dfd3b1e3e8a580bcbf854d46ae0f22c8333e82d8
Gitweb: http://git.kernel.org/tip/dfd3b1e3e8a580bcbf854d46ae0f22c8333e82d8
Author: Danny Kukawka <[email protected]>
AuthorDate: Thu, 16 Feb 2012 14:54:19 +0100
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Fri, 17 Feb 2012 16:34:09 -0200

perf tools: Remove duplicated string.h includes

tools/perf/util/probe-event.c included 'string.h' twice, remove the
duplicate.

Acked-by: Masami Hiramatsu <[email protected]>
Cc: Danny Kukawka <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Jovi Zhang <[email protected]>
Cc: Masami Hiramatsu <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Steven Rostedt <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Danny Kukawka <[email protected]>
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/util/probe-event.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index c1a513e..8379252 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -34,7 +34,6 @@

#include "util.h"
#include "event.h"
-#include "string.h"
#include "strlist.h"
#include "debug.h"
#include "cache.h"