2010-01-13 09:06:42

by tip-bot for Wenji Huang

Subject: [PATCH] perf: make cmd_to_page function compact

Remove branch for is_perf_command

Signed-off-by: Wenji Huang <[email protected]>
---
tools/perf/builtin-help.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
index 9f810b1..65e2691 100644
--- a/tools/perf/builtin-help.c
+++ b/tools/perf/builtin-help.c
@@ -314,8 +314,6 @@ static const char *cmd_to_page(const char *perf_cmd)
return "perf";
else if (!prefixcmp(perf_cmd, "perf"))
return perf_cmd;
- else if (is_perf_command(perf_cmd))
- return prepend("perf-", perf_cmd);
else
return prepend("perf-", perf_cmd);
}
--
1.5.6

2010-01-13 10:38:28

by tip-bot for Wenji Huang

Subject: [tip:perf/core] perf: Make cmd_to_page() function more compact

Commit-ID: ff314d3903c2843de65c2148f66f277f2440ed26
Gitweb: http://git.kernel.org/tip/ff314d3903c2843de65c2148f66f277f2440ed26
Author: Wenji Huang <[email protected]>
AuthorDate: Wed, 13 Jan 2010 17:01:38 +0800
Committer: Ingo Molnar <[email protected]>
CommitDate: Wed, 13 Jan 2010 10:53:51 +0100

perf: Make cmd_to_page() function more compact

Remove branch for is_perf_command.

Signed-off-by: Wenji Huang <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
---
tools/perf/builtin-help.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
index e427d69..215b584 100644
--- a/tools/perf/builtin-help.c
+++ b/tools/perf/builtin-help.c
@@ -313,8 +313,6 @@ static const char *cmd_to_page(const char *perf_cmd)
return "perf";
else if (!prefixcmp(perf_cmd, "perf"))
return perf_cmd;
- else if (is_perf_command(perf_cmd))
- return prepend("perf-", perf_cmd);
else
return prepend("perf-", perf_cmd);
}

2010-01-13 13:29:07

by John Kacur

Subject: Re: [PATCH] perf: make cmd_to_page function compact

----- "Wenji Huang" <[email protected]> wrote:

> Remove branch for is_perf_command
>
> Signed-off-by: Wenji Huang <[email protected]>
> ---
> tools/perf/builtin-help.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
> index 9f810b1..65e2691 100644
> --- a/tools/perf/builtin-help.c
> +++ b/tools/perf/builtin-help.c
> @@ -314,8 +314,6 @@ static const char *cmd_to_page(const char
> *perf_cmd)
> return "perf";
> else if (!prefixcmp(perf_cmd, "perf"))
> return perf_cmd;
> - else if (is_perf_command(perf_cmd))
> - return prepend("perf-", perf_cmd);
> else
> return prepend("perf-", perf_cmd);
> }
> --
> 1.5.6


Thanks, Wenji, I tested your change, and it works find.
Acked-by: John Kacur <[email protected]>