2012-05-08 15:10:47

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: [tip:perf/core] perf annotate browser: Don' t change the asm line color when toggling source

Commit-ID: 64aa17ca5a4e428fcb6d0806823a99a18c548506
Gitweb: http://git.kernel.org/tip/64aa17ca5a4e428fcb6d0806823a99a18c548506
Author: Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Thu, 3 May 2012 13:23:00 -0300
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Thu, 3 May 2012 13:23:00 -0300

perf annotate browser: Don't change the asm line color when toggling source

Gets confusing. Remains to be chosen an appropriate different color for
source code.

This effectively reverts 58e817d997d1 ("perf annotate: Print asm code as
blue when source code is displayed")

Requested-by: Peter Zijlstra <[email protected]>
Cc: David Ahern <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Mike Galbraith <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Stephane Eranian <[email protected]>
Link: http://lkml.kernel.org/n/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/ui/browsers/annotate.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index 74104a4..b94da57 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -81,9 +81,6 @@ static void annotate_browser__write(struct ui_browser *self, void *entry, int ro
if (!self->navkeypressed)
width += 1;

- if (dl->offset != -1 && change_color)
- ui_browser__set_color(self, HE_COLORSET_CODE);
-
if (!*dl->line)
slsmg_write_nstring(" ", width - 7);
else if (dl->offset == -1) {