2009-09-06 17:34:05

by Stefan Richter

[permalink] [raw]
Subject: [PATCH] firewire: sbp2: remove a workaround for Momobay FX-3A

The inquiry delay does more harm than good in tests on a recent kernel.

Signed-off-by: Stefan Richter <[email protected]>
---
drivers/firewire/sbp2.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-2.6.31-rc9/drivers/firewire/sbp2.c
===================================================================
--- linux-2.6.31-rc9.orig/drivers/firewire/sbp2.c
+++ linux-2.6.31-rc9/drivers/firewire/sbp2.c
@@ -354,8 +354,7 @@ static const struct {
/* DViCO Momobay FX-3A with TSB42AA9A bridge */ {
.firmware_revision = 0x002800,
.model = 0x000000,
- .workarounds = SBP2_WORKAROUND_DELAY_INQUIRY |
- SBP2_WORKAROUND_POWER_CONDITION,
+ .workarounds = SBP2_WORKAROUND_POWER_CONDITION,
},
/* Initio bridges, actually only needed for some older ones */ {
.firmware_revision = 0x000200,

--
Stefan Richter
-=====-==--= =--= --==-
http://arcgraph.de/sr/


2009-09-06 17:34:30

by Stefan Richter

[permalink] [raw]
Subject: [PATCH] ieee1394: sbp2: remove a workaround for Momobay FX-3A

The inquiry delay is not necessary anymore in tests on a recent kernel.

Signed-off-by: Stefan Richter <[email protected]>
---
drivers/ieee1394/sbp2.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-2.6.31-rc9/drivers/ieee1394/sbp2.c
===================================================================
--- linux-2.6.31-rc9.orig/drivers/ieee1394/sbp2.c
+++ linux-2.6.31-rc9/drivers/ieee1394/sbp2.c
@@ -372,8 +372,7 @@ static const struct {
/* DViCO Momobay FX-3A with TSB42AA9A bridge */ {
.firmware_revision = 0x002800,
.model = 0x000000,
- .workarounds = SBP2_WORKAROUND_DELAY_INQUIRY |
- SBP2_WORKAROUND_POWER_CONDITION,
+ .workarounds = SBP2_WORKAROUND_POWER_CONDITION,
},
/* Initio bridges, actually only needed for some older ones */ {
.firmware_revision = 0x000200,

--
Stefan Richter
-=====-==--= =--= --==-
http://arcgraph.de/sr/