From: Frank Wunderlich <[email protected]>
Infracfg on mt7988 supports reset controller function which is
needed to get lvts thermal working.
Patches are based on clk-next due to recently added mt7988 clock driver:
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git
changes:
v2:
- change value of constant to 0 from 9
- add missing SoB and commit-message for binding-patch
Frank Wunderlich (2):
dt-bindings: reset: mediatek: add MT7988 LVTS reset ID
clk: mediatek: add infracfg reset controller for mt7988
drivers/clk/mediatek/clk-mt7988-infracfg.c | 20 +++++++++++++++++++
.../reset/mediatek,mt7988-resets.h | 4 ++++
2 files changed, 24 insertions(+)
--
2.34.1
From: Frank Wunderlich <[email protected]>
Add reset constant for using as index in driver and dts.
Signed-off-by: Frank Wunderlich <[email protected]>
---
v2:
- add missing commit message and SoB
- change value of infrareset to 0
---
include/dt-bindings/reset/mediatek,mt7988-resets.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/dt-bindings/reset/mediatek,mt7988-resets.h b/include/dt-bindings/reset/mediatek,mt7988-resets.h
index 493301971367..0216eeb249c7 100644
--- a/include/dt-bindings/reset/mediatek,mt7988-resets.h
+++ b/include/dt-bindings/reset/mediatek,mt7988-resets.h
@@ -10,4 +10,8 @@
/* ETHWARP resets */
#define MT7988_ETHWARP_RST_SWITCH 0
+/* INFRA resets */
+#define MT7988_INFRA_RST0_THERM_CTRL_SWRST 0
+
#endif /* _DT_BINDINGS_RESET_CONTROLLER_MT7988 */
+
--
2.34.1
From: Frank Wunderlich <[email protected]>
Infracfg can also operate as reset controller, add support for it.
Signed-off-by: Frank Wunderlich <[email protected]>
---
drivers/clk/mediatek/clk-mt7988-infracfg.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/clk/mediatek/clk-mt7988-infracfg.c b/drivers/clk/mediatek/clk-mt7988-infracfg.c
index 8011ef278bea..1660a45349ff 100644
--- a/drivers/clk/mediatek/clk-mt7988-infracfg.c
+++ b/drivers/clk/mediatek/clk-mt7988-infracfg.c
@@ -14,6 +14,9 @@
#include "clk-gate.h"
#include "clk-mux.h"
#include <dt-bindings/clock/mediatek,mt7988-clk.h>
+#include <dt-bindings/reset/mediatek,mt7988-resets.h>
+
+#define INFRA_RST_SET_OFFSET 0x80
static DEFINE_SPINLOCK(mt7988_clk_lock);
@@ -249,12 +252,29 @@ static const struct mtk_gate infra_clks[] = {
GATE_INFRA3(CLK_INFRA_133M_PCIE_CK_P3, "infra_133m_pcie_ck_p3", "sysaxi_sel", 31),
};
+static u16 infra_rst_ofs[] = {
+ INFRA_RST_SET_OFFSET,
+};
+
+static u16 infra_idx_map[] = {
+ [MT7988_INFRA_RST0_THERM_CTRL_SWRST] = 0 * RST_NR_PER_BANK + 9,
+};
+
+static struct mtk_clk_rst_desc infra_rst_desc = {
+ .version = MTK_RST_SET_CLR,
+ .rst_bank_ofs = infra_rst_ofs,
+ .rst_bank_nr = ARRAY_SIZE(infra_rst_ofs),
+ .rst_idx_map = infra_idx_map,
+ .rst_idx_map_nr = ARRAY_SIZE(infra_idx_map),
+};
+
static const struct mtk_clk_desc infra_desc = {
.clks = infra_clks,
.num_clks = ARRAY_SIZE(infra_clks),
.mux_clks = infra_muxes,
.num_mux_clks = ARRAY_SIZE(infra_muxes),
.clk_lock = &mt7988_clk_lock,
+ .rst_desc = &infra_rst_desc,
};
static const struct of_device_id of_match_clk_mt7988_infracfg[] = {
--
2.34.1
On 05/01/2024 17:20, Frank Wunderlich wrote:
> From: Frank Wunderlich <[email protected]>
>
> Add reset constant for using as index in driver and dts.
>
> Signed-off-by: Frank Wunderlich <[email protected]>
> ---
> v2:
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
Il 05/01/24 17:20, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <[email protected]>
>
> Infracfg can also operate as reset controller, add support for it.
>
> Signed-off-by: Frank Wunderlich <[email protected]>
> ---
> drivers/clk/mediatek/clk-mt7988-infracfg.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/clk/mediatek/clk-mt7988-infracfg.c b/drivers/clk/mediatek/clk-mt7988-infracfg.c
> index 8011ef278bea..1660a45349ff 100644
> --- a/drivers/clk/mediatek/clk-mt7988-infracfg.c
> +++ b/drivers/clk/mediatek/clk-mt7988-infracfg.c
> @@ -14,6 +14,9 @@
> #include "clk-gate.h"
> #include "clk-mux.h"
> #include <dt-bindings/clock/mediatek,mt7988-clk.h>
> +#include <dt-bindings/reset/mediatek,mt7988-resets.h>
> +
> +#define INFRA_RST_SET_OFFSET 0x80
>
> static DEFINE_SPINLOCK(mt7988_clk_lock);
>
> @@ -249,12 +252,29 @@ static const struct mtk_gate infra_clks[] = {
> GATE_INFRA3(CLK_INFRA_133M_PCIE_CK_P3, "infra_133m_pcie_ck_p3", "sysaxi_sel", 31),
> };
>
> +static u16 infra_rst_ofs[] = {
> + INFRA_RST_SET_OFFSET,
> +};
> +
> +static u16 infra_idx_map[] = {
> + [MT7988_INFRA_RST0_THERM_CTRL_SWRST] = 0 * RST_NR_PER_BANK + 9,
The MT7988A datasheet says that INFRA_RST0 bit 9 is CONN2EMI_M0_GALS_SLV_SWRST, so
this is wrong: THERM_CTRL_SWRST is in the RST1 register, bit 9.
Also, I'm sure that you really want to add the PCIe MAC reset bit as well, to be
used with the PCIe driver...
[MT7988_INFRA_RST0_PEXTP_MAC_SWRST] = 0 * RST_NR_PER_BANK + 6,
[MT7988_INFRA_RST1_THERM_CTRL_SWRST] = 1 * RST_NR_PER_BANK + 9,
Enjoy... :-)
Cheers,
Angelo
Am 8. Januar 2024 11:12:26 MEZ schrieb AngeloGioacchino Del Regno <[email protected]>:
>Il 05/01/24 17:20, Frank Wunderlich ha scritto:
>> From: Frank Wunderlich <[email protected]>
>>
>> Infracfg can also operate as reset controller, add support for it.
>>
>> Signed-off-by: Frank Wunderlich <[email protected]>
>> ---
>> drivers/clk/mediatek/clk-mt7988-infracfg.c | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/drivers/clk/mediatek/clk-mt7988-infracfg.c b/drivers/clk/mediatek/clk-mt7988-infracfg.c
>> index 8011ef278bea..1660a45349ff 100644
>> --- a/drivers/clk/mediatek/clk-mt7988-infracfg.c
>> +++ b/drivers/clk/mediatek/clk-mt7988-infracfg.c
>> @@ -14,6 +14,9 @@
>> #include "clk-gate.h"
>> #include "clk-mux.h"
>> #include <dt-bindings/clock/mediatek,mt7988-clk.h>
>> +#include <dt-bindings/reset/mediatek,mt7988-resets.h>
>> +
>> +#define INFRA_RST_SET_OFFSET 0x80
>> static DEFINE_SPINLOCK(mt7988_clk_lock);
>> @@ -249,12 +252,29 @@ static const struct mtk_gate infra_clks[] = {
>> GATE_INFRA3(CLK_INFRA_133M_PCIE_CK_P3, "infra_133m_pcie_ck_p3", "sysaxi_sel", 31),
>> };
>> +static u16 infra_rst_ofs[] = {
>> + INFRA_RST_SET_OFFSET,
>> +};
>> +
>> +static u16 infra_idx_map[] = {
>> + [MT7988_INFRA_RST0_THERM_CTRL_SWRST] = 0 * RST_NR_PER_BANK + 9,
>
>The MT7988A datasheet says that INFRA_RST0 bit 9 is CONN2EMI_M0_GALS_SLV_SWRST, so
>this is wrong: THERM_CTRL_SWRST is in the RST1 register, bit 9.
>
>Also, I'm sure that you really want to add the PCIe MAC reset bit as well, to be
>used with the PCIe driver...
>
>[MT7988_INFRA_RST0_PEXTP_MAC_SWRST] = 0 * RST_NR_PER_BANK + 6,
>[MT7988_INFRA_RST1_THERM_CTRL_SWRST] = 1 * RST_NR_PER_BANK + 9,
Yes you are right...i have only rst1 as screenshot,need to get the full datasheet or can you tell me base address for rst0? Need to change value of INFRA_RST_SET_OFFSET then to rst0 and check RST_NR_PER_BANK to be correct.
>Enjoy... :-)
>
>Cheers,
>Angelo
>
regards Frank
Il 08/01/24 14:46, Frank Wunderlich ha scritto:
> Am 8. Januar 2024 11:12:26 MEZ schrieb AngeloGioacchino Del Regno <[email protected]>:
>> Il 05/01/24 17:20, Frank Wunderlich ha scritto:
>>> From: Frank Wunderlich <[email protected]>
>>>
>>> Infracfg can also operate as reset controller, add support for it.
>>>
>>> Signed-off-by: Frank Wunderlich <[email protected]>
>>> ---
>>> drivers/clk/mediatek/clk-mt7988-infracfg.c | 20 ++++++++++++++++++++
>>> 1 file changed, 20 insertions(+)
>>>
>>> diff --git a/drivers/clk/mediatek/clk-mt7988-infracfg.c b/drivers/clk/mediatek/clk-mt7988-infracfg.c
>>> index 8011ef278bea..1660a45349ff 100644
>>> --- a/drivers/clk/mediatek/clk-mt7988-infracfg.c
>>> +++ b/drivers/clk/mediatek/clk-mt7988-infracfg.c
>>> @@ -14,6 +14,9 @@
>>> #include "clk-gate.h"
>>> #include "clk-mux.h"
>>> #include <dt-bindings/clock/mediatek,mt7988-clk.h>
>>> +#include <dt-bindings/reset/mediatek,mt7988-resets.h>
>>> +
>>> +#define INFRA_RST_SET_OFFSET 0x80
>>> static DEFINE_SPINLOCK(mt7988_clk_lock);
>>> @@ -249,12 +252,29 @@ static const struct mtk_gate infra_clks[] = {
>>> GATE_INFRA3(CLK_INFRA_133M_PCIE_CK_P3, "infra_133m_pcie_ck_p3", "sysaxi_sel", 31),
>>> };
>>> +static u16 infra_rst_ofs[] = {
>>> + INFRA_RST_SET_OFFSET,
>>> +};
>>> +
>>> +static u16 infra_idx_map[] = {
>>> + [MT7988_INFRA_RST0_THERM_CTRL_SWRST] = 0 * RST_NR_PER_BANK + 9,
>>
>> The MT7988A datasheet says that INFRA_RST0 bit 9 is CONN2EMI_M0_GALS_SLV_SWRST, so
>> this is wrong: THERM_CTRL_SWRST is in the RST1 register, bit 9.
>>
>> Also, I'm sure that you really want to add the PCIe MAC reset bit as well, to be
>> used with the PCIe driver...
>>
>> [MT7988_INFRA_RST0_PEXTP_MAC_SWRST] = 0 * RST_NR_PER_BANK + 6,
>> [MT7988_INFRA_RST1_THERM_CTRL_SWRST] = 1 * RST_NR_PER_BANK + 9,
>
> Yes you are right...i have only rst1 as screenshot,need to get the full datasheet or can you tell me base address for rst0? Need to change value of INFRA_RST_SET_OFFSET then to rst0 and check RST_NR_PER_BANK to be correct.
The datasheet is public ... [1] has it in the Resources paragraph :-)
Anyway, since I already have it here in front of me...
10001070 INFRA_GLOBALCON_RST0_SET
10001080 INFRA_GLOBALCON_RST1_SET
[1]: https://wiki.banana-pi.org/Banana_Pi_BPI-R4
Cheers,
Angelo
On 05/01/2024 17:20, Frank Wunderlich wrote:
> From: Frank Wunderlich <[email protected]>
>
> Add reset constant for using as index in driver and dts.
>
> Signed-off-by: Frank Wunderlich <[email protected]>
Reviewed-by: Matthias Brugger <[email protected]>
> ---
> v2:
> - add missing commit message and SoB
> - change value of infrareset to 0
> ---
> include/dt-bindings/reset/mediatek,mt7988-resets.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/dt-bindings/reset/mediatek,mt7988-resets.h b/include/dt-bindings/reset/mediatek,mt7988-resets.h
> index 493301971367..0216eeb249c7 100644
> --- a/include/dt-bindings/reset/mediatek,mt7988-resets.h
> +++ b/include/dt-bindings/reset/mediatek,mt7988-resets.h
> @@ -10,4 +10,8 @@
> /* ETHWARP resets */
> #define MT7988_ETHWARP_RST_SWITCH 0
>
> +/* INFRA resets */
> +#define MT7988_INFRA_RST0_THERM_CTRL_SWRST 0
> +
> #endif /* _DT_BINDINGS_RESET_CONTROLLER_MT7988 */
> +
> Gesendet: Montag, 22. Januar 2024 um 09:57 Uhr
> Von: "Matthias Brugger" <[email protected]>
> On 05/01/2024 17:20, Frank Wunderlich wrote:
> > From: Frank Wunderlich <[email protected]>
> >
> > Add reset constant for using as index in driver and dts.
> >
> > Signed-off-by: Frank Wunderlich <[email protected]>
>
> Reviewed-by: Matthias Brugger <[email protected]>
Hi
good to hear again from you Matthias. unfortunately there is already a v3 out,
where i added multiple reset offsets/ids. Can you please review this one?
https://patchwork.kernel.org/project/linux-mediatek/list/?series=817619
and i also wait for 2 other patches to be reviewed before bpi-r4 dts patches can go in:
https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/
regards Frank