2021-06-08 16:04:58

by Frank Wunderlich

Subject: [PATCH v4] thermal: mediatek: add sensors-support

From: Frank Wunderlich <[email protected]>

add HWMON-support to mediateks thermal driver to allow lm-sensors
userspace tools read soc temperature

Signed-off-by: Frank Wunderlich <[email protected]>
---
v4: change message to dev_warn as suggested by matthias
v3: drop no_hwmon
v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
---
drivers/thermal/mtk_thermal.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
index 97e8678ccf0e..ede94eadddda 100644
--- a/drivers/thermal/mtk_thermal.c
+++ b/drivers/thermal/mtk_thermal.c
@@ -23,6 +23,8 @@
#include <linux/reset.h>
#include <linux/types.h>

+#include "thermal_hwmon.h"
+
/* AUXADC Registers */
#define AUXADC_CON1_SET_V 0x008
#define AUXADC_CON1_CLR_V 0x00c
@@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
goto err_disable_clk_peri_therm;
}

+ ret = devm_thermal_add_hwmon_sysfs(tzdev);
+ if (ret)
+ dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
+
return 0;

err_disable_clk_peri_therm:
--
2.25.1

2021-06-09 13:54:22

by Matthias Brugger

Subject: Re: [PATCH v4] thermal: mediatek: add sensors-support

On 08/06/2021 17:45, Frank Wunderlich wrote:
> From: Frank Wunderlich <[email protected]>
>
> add HWMON-support to mediateks thermal driver to allow lm-sensors
> userspace tools read soc temperature
>
> Signed-off-by: Frank Wunderlich <[email protected]>

Reviewed-by: Matthias Brugger <[email protected]>

> ---
> v4: change message to dev_warn as suggested by matthias
> v3: drop no_hwmon
> v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
> ---
> drivers/thermal/mtk_thermal.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 97e8678ccf0e..ede94eadddda 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -23,6 +23,8 @@
> #include <linux/reset.h>
> #include <linux/types.h>
>
> +#include "thermal_hwmon.h"
> +
> /* AUXADC Registers */
> #define AUXADC_CON1_SET_V 0x008
> #define AUXADC_CON1_CLR_V 0x00c
> @@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
> goto err_disable_clk_peri_therm;
> }
>
> + ret = devm_thermal_add_hwmon_sysfs(tzdev);
> + if (ret)
> + dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
> +
> return 0;
>
> err_disable_clk_peri_therm:
>

2021-06-28 10:08:01

by Frank Wunderlich

Subject: Aw: Re: [PATCH v4] thermal: mediatek: add sensors-support

Hi,

A gentle ping as it is reviewed but not yet visible in thermal tree [1] i guess it should do,right?

regards Frank

[1] https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/log/?h=thermal/next

> Gesendet: Mittwoch, 09. Juni 2021 um 10:09 Uhr
> Von: "Matthias Brugger" <[email protected]>
> An: "Frank Wunderlich" <[email protected]>, [email protected]
> Cc: "Frank Wunderlich" <[email protected]>, "Daniel Lezcano" <[email protected]>, "Amit Kucheria" <[email protected]>, [email protected], [email protected], [email protected]
> Betreff: Re: [PATCH v4] thermal: mediatek: add sensors-support
>
>
>
> On 08/06/2021 17:45, Frank Wunderlich wrote:
> > From: Frank Wunderlich <[email protected]>
> >
> > add HWMON-support to mediateks thermal driver to allow lm-sensors
> > userspace tools read soc temperature
> >
> > Signed-off-by: Frank Wunderlich <[email protected]>
>
> Reviewed-by: Matthias Brugger <[email protected]>
>
> > ---
> > v4: change message to dev_warn as suggested by matthias
> > v3: drop no_hwmon
> > v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
> > ---
> > drivers/thermal/mtk_thermal.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> > index 97e8678ccf0e..ede94eadddda 100644
> > --- a/drivers/thermal/mtk_thermal.c
> > +++ b/drivers/thermal/mtk_thermal.c
> > @@ -23,6 +23,8 @@
> > #include <linux/reset.h>
> > #include <linux/types.h>
> >
> > +#include "thermal_hwmon.h"
> > +
> > /* AUXADC Registers */
> > #define AUXADC_CON1_SET_V 0x008
> > #define AUXADC_CON1_CLR_V 0x00c
> > @@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
> > goto err_disable_clk_peri_therm;
> > }
> >
> > + ret = devm_thermal_add_hwmon_sysfs(tzdev);
> > + if (ret)
> > + dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
> > +
> > return 0;
> >
> > err_disable_clk_peri_therm:
> >
>

2021-06-28 15:55:42

by Daniel Lezcano

Subject: Re: Aw: Re: [PATCH v4] thermal: mediatek: add sensors-support

On 28/06/2021 12:05, Frank Wunderlich wrote:
> Hi,
>
> A gentle ping as it is reviewed but not yet visible in thermal tree [1] i guess it should do,right?
>

Right, I thought I took it.

Fixed, thanks for the heads up.


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog