2024-04-23 14:19:14

by Liam R. Howlett

Subject: Broken xarray testing in v6.9-rc1

Hello,

Testing of the xarray using the radix tree test suite is currently
broken in v6.9-rc1 and beyond. A bisect resulted in your commit failing
to build:

a60cc288a1a2604bd86d3df129f269887018c3cb is the first bad commit
commit a60cc288a1a2604bd86d3df129f269887018c3cb
Author: Luis Chamberlain <[email protected]>

..

Building in the test suite now fails in linux/tools/testing/radix-tree:

{bisect/bad(bisect)//radix-tree} $ make
cc -O2 -g -Wall -I. -I../../include -I../../../lib -g -Og -Wall -D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined -c -o xarray.o xarray.c
In file included from xarray.c:18:
./../../lib/test_xarray.c: In function ‘test_get_entry’:
./../../lib/test_xarray.c:750:17: warning: implicit declaration of function ‘schedule’ [-Wimplicit-function-declaration]
750 | schedule();
| ^~~~~~~~
./../../lib/test_xarray.c: In function ‘check_xa_multi_store_adv’:
./../../lib/test_xarray.c:767:24: error: ‘PAGE_SHIFT’ undeclared (first use in this function)
767 | index = pos >> PAGE_SHIFT;
| ^~~~~~~~~~
./../../lib/test_xarray.c:767:24: note: each undeclared identifier is reported only once for each function it appears in
make: *** [<builtin>: xarray.o] Error 1

Can you please have a look?

Thanks,
Liam

2024-04-23 19:54:46

by Luis Chamberlain

Subject: Re: Broken xarray testing in v6.9-rc1

On Tue, Apr 23, 2024 at 10:18:36AM -0400, Liam R. Howlett wrote:
> Hello,
>
> Testing of the xarray using the radix tree test suite is currently
> broken in v6.9-rc1 and beyond. A bisect resulted in your commit failing
> to build:
>
> a60cc288a1a2604bd86d3df129f269887018c3cb is the first bad commit
> commit a60cc288a1a2604bd86d3df129f269887018c3cb
> Author: Luis Chamberlain <[email protected]>
>
> ...
>
> Building in the test suite now fails in linux/tools/testing/radix-tree:
>
> {bisect/bad(bisect)//radix-tree} $ make
> cc -O2 -g -Wall -I. -I../../include -I../../../lib -g -Og -Wall -D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined -c -o xarray.o xarray.c
> In file included from xarray.c:18:
> ../../../lib/test_xarray.c: In function ‘test_get_entry’:
> ../../../lib/test_xarray.c:750:17: warning: implicit declaration of function ‘schedule’ [-Wimplicit-function-declaration]
> 750 | schedule();
> | ^~~~~~~~
> ../../../lib/test_xarray.c: In function ‘check_xa_multi_store_adv’:
> ../../../lib/test_xarray.c:767:24: error: ‘PAGE_SHIFT’ undeclared (first use in this function)
> 767 | index = pos >> PAGE_SHIFT;
> | ^~~~~~~~~~
> ../../../lib/test_xarray.c:767:24: note: each undeclared identifier is reported only once for each function it appears in
> make: *** [<builtin>: xarray.o] Error 1
>
> Can you please have a look?

Sure, I'll post patches right away, this also demonstrated an issue in
the test code too which I've fixed and will post a fix for too.

Thanks for reporting it.

Luis