2008-11-22 22:26:04

by Rafael J. Wysocki

[permalink] [raw]
Subject: 2.6.28-rc6-git1: Reported regressions from 2.6.27

This message contains a list of some regressions from 2.6.27, for which there
are no fixes in the mainline I know of. If any of them have been fixed already,
please let me know.

If you know of any other unresolved regressions from 2.6.27, please let me know
either and I'll add them to the list. Also, please let me know if any of the
entries below are invalid.

Each entry from the list will be sent additionally in an automatic reply to
this message with CCs to the people involved in reporting and handling the
issue.


Listed regressions statistics:

Date Total Pending Unresolved
----------------------------------------
2008-11-22 93 25 15
2008-11-16 89 32 18
2008-11-09 73 40 27
2008-11-02 55 41 29
2008-10-25 26 25 20


Unresolved regressions
----------------------

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12064
Subject : [regression] Measured 688 cycles TSC warp; marking TSC unstable
Submitter : Frans Pop <[email protected]>
Date : 2008-11-16 19:27:43 (7 days old)
References : http://marc.info/?l=linux-kernel&m=122686370308852&w=2


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12061
Subject : snd_hda_intel: power_save: sound cracks on powerdown
Submitter : Jens Weibler <[email protected]>
Date : 2008-11-18 12:07 (5 days old)
Handled-By : Takashi Iwai <[email protected]>


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12034
Subject : snd-hda-intel on Realtek ALC268 chip shows only Master volume (for playback)
Submitter : Sergey <[email protected]>
Date : 2008-11-15 04:20 (8 days old)


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12031
Subject : DRM enabled kernel hangs hard on resume on x60
Submitter : Jens Axboe <[email protected]>
Date : 2008-11-12 18:42 (11 days old)
References : http://marc.info/?l=linux-kernel&m=122651551216820&w=4
Handled-By : Jesse Barnes <[email protected]>


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12028
Subject : i915 DRM is broken in 2.6.28-rc4
Submitter : Adam Tkac <[email protected]>
Date : 2008-11-14 01:50 (9 days old)


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11996
Subject : Tracing framework regression in 2.6.28-rc3
Submitter : Pekka Paalanen <[email protected]>
Date : 2008-11-09 10:13 (14 days old)
References : http://marc.info/?l=linux-kernel&m=122624392229317&w=4
Handled-By : Steven Rostedt <[email protected]>


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11970
Subject : gettimeofday return a old time in mmbench
Submitter : alexs <[email protected]>
Date : 2008-11-06 23:57 (17 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=99ebcf8285df28f32fd2d1c19a7166e70f00309c
Handled-By : Ingo Molnar <[email protected]>
Thomas Gleixner <[email protected]>
Yanmin Zhang <[email protected]>


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11965
Subject : regression introduced by - timers: fix itimer/many thread hang
Submitter : Doug Chapman <[email protected]>
Date : 2008-11-06 11:03 (17 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f06febc96ba8e0af80bcc3eaec0a109e88275fac
References : http://marc.info/?l=linux-kernel&m=122596943416648&w=4
Handled-By : Frank Mayhar <[email protected]>
Peter Zijlstra <[email protected]>
Ingo Molnar <[email protected]>


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11958
Subject : [2.6.27.x =&gt; 2.6.28-rc3] Xorg crash with xf86MapVidMem error
Submitter : Tomasz Chmielewski <[email protected]>
Date : 2008-11-05 05:37 (18 days old)


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11947
Subject : 2.6.28-rc VC switching with Intel graphics broken
Submitter : Romano Giannetti <[email protected]>
Date : 2008-11-03 12:10 (20 days old)
Handled-By : Jesse Barnes <[email protected]>


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11913
Subject : USB/INPUT: slab error in cache_alloc_debugcheck_after(): double free?
Submitter : Helge Deller <[email protected]>
Date : 2008-10-30 23:11 (24 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=cb8f488c33539f096580e202f5438a809195008f
References : http://marc.info/?l=linux-kernel&m=122540833301394&w=4
Handled-By : Jiri Kosina <[email protected]>
Jiri Slaby <[email protected]>
Jiri Kosina <[email protected]>
Jiri Slaby <[email protected]>
Denys Vlasenko <[email protected]>


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11906
Subject : 2.6.28-rc2 seems to fail at powering down the monitor when it should
Submitter : Gene Heskett <[email protected]>
Date : 2008-10-30 6:39 (24 days old)
References : http://marc.info/?l=linux-kernel&m=122534879721424&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11858
Subject : Timeout regression introduced by 242f9dcb8ba6f68fcd217a119a7648a4f69290e9
Submitter : Tejun Heo <[email protected]>
Date : 2008-10-26 9:46 (28 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=242f9dcb8ba6f68fcd217a119a7648a4f69290e9
References : http://marc.info/?l=linux-kernel&m=122501447326698&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11849
Subject : default IRQ affinity change in v2.6.27 (breaking several SMP PPC based systems)
Submitter : Kumar Gala <[email protected]>
Date : 2008-10-24 12:45 (30 days old)
References : http://marc.info/?l=linux-kernel&m=122485245924125&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11828
Subject : Linux 2.6.27-git3: no SD card reader
Submitter : J.A. Magallón <[email protected]>
Date : 2008-10-14 0:54 (40 days old)
References : http://marc.info/?l=linux-kernel&m=122394573904699&w=4


Regressions with patches
------------------------

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12082
Subject : IRQ and MSI allocations broken without sparse irq
Submitter : Jesper Dangaard Brouer <[email protected]>
Date : 2008-11-20 19:48 (3 days old)
References : http://marc.info/?l=linux-kernel&m=122721060501073&w=4
Handled-By : Thomas Gleixner <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122722773824802&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12081
Subject : xen: pin correct PGD on suspend
Submitter : Ian Campbell <[email protected]>
Date : 2008-11-21 10:21 (2 days old)
References : http://marc.info/?l=linux-kernel&m=122726293324850&w=4
Handled-By : Ian Campbell <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122726293324850&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12047
Subject : ACPI toshiba: only register rfkill if bt is enabled
Submitter : Andrey Borzenkov <[email protected]>
Date : 2008-10-28 19:10 (26 days old)
References : http://marc.info/?l=linux-kernel&m=122522113619025&w=2
Handled-By : Frederik Deweerdt <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122526843117478&w=2


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12038
Subject : Suspend regression in stable kernel 2.6.27.4 on Mac mini Core Duo
Submitter : Tino Keitel <[email protected]>
Date : 2008-11-09 20:28 (14 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=66036f5862883fcc9f7ff8550685a5a3de1a57e4
References : http://marc.info/?l=linux-kernel&m=122626258429689&w=4
Handled-By : Rafael J. Wysocki <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122661443120581&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12020
Subject : scsi_times_out NULL pointer dereference
Submitter : Bernd Schubert <[email protected]>
Date : 2008-11-13 10:30 (10 days old)
Handled-By : James Bottomley <[email protected]>
Patch : http://bugzilla.kernel.org/show_bug.cgi?id=12020#c4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11982
Subject : Fan level 7 after resume wit 2.6.28-rc3
Submitter : Tino Keitel <[email protected]>
Date : 2008-11-05 7:33 (18 days old)
References : http://marc.info/?l=linux-kernel&m=122587043409186&w=4
Handled-By : Henrique de Moraes Holschuh <[email protected]>
Patch : http://bugzilla.kernel.org/attachment.cgi?id=18744&action=view


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11925
Subject : cdrom: missing compat ioctls
Submitter : Andreas Schwab <[email protected]>
Date : 2008-10-31 14:02 (23 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=33c2dca4957bd0da3e1af7b96d0758d97e708ef6
Handled-By : Andreas Schwab <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122548923531545&w=2


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11898
Subject : mke2fs hang on AIC79 device.
Submitter : alexs <[email protected]>
Date : 2008-10-30 01:17 (24 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f0c0a376d0fcd4c5579ecf5e95f88387cba85211
Handled-By : James Bottomley <[email protected]>
Mike Christie <[email protected]>
Patch : http://bugzilla.kernel.org/show_bug.cgi?id=11898#c28
http://bugzilla.kernel.org/show_bug.cgi?id=11898#c36


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11875
Subject : radeonfb lockup in .28-rc (bisected)
Submitter : James Cloos <[email protected]>
Date : 2008-10-28 0:00 (26 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b1ee26bab14886350ba12a5c10cbc0696ac679bf
References : http://marc.info/?l=linux-kernel&m=122515210200530&w=4
http://lkml.org/lkml/2008/11/10/12
Handled-By : Benjamin Herrenschmidt <[email protected]>
Patch : http://lkml.org/lkml/2008/11/10/12


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11822
Subject : ACPI Warning (nspredef-0858): _SB_.PCI0.LPC_.EC__.BAT0._BIF: Return Package type mismatch at index 9 - found Buffer, expected String [20080926]
Submitter : Len Brown <[email protected]>
Date : 2008-10-25 01:26 (29 days old)
Handled-By : Robert Moore <[email protected]>
Lin Ming <[email protected]>
Patch : http://bugzilla.kernel.org/attachment.cgi?id=18949&action=view


For details, please visit the bug entries and follow the links given in
references.

As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions from 2.6.27,
unresolved as well as resolved, at:

http://bugzilla.kernel.org/show_bug.cgi?id=11808

Please let me know if there are any Bugzilla entries that should be added to
the list in there.

Thanks,
Rafael


2008-11-22 22:25:48

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11822] ACPI Warning (nspredef-0858): _SB_.PCI0.LPC_.EC__.BAT0._BIF: Return Package type mismatch at index 9 - found Buffer, expected String [20080926]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11822
Subject : ACPI Warning (nspredef-0858): _SB_.PCI0.LPC_.EC__.BAT0._BIF: Return Package type mismatch at index 9 - found Buffer, expected String [20080926]
Submitter : Len Brown <[email protected]>
Date : 2008-10-25 01:26 (29 days old)
Handled-By : Robert Moore <[email protected]>
Lin Ming <[email protected]>
Patch : http://bugzilla.kernel.org/attachment.cgi?id=18949&action=view

2008-11-22 22:28:56

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11858] Timeout regression introduced by 242f9dcb8ba6f68fcd217a119a7648a4f69290e9

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11858
Subject : Timeout regression introduced by 242f9dcb8ba6f68fcd217a119a7648a4f69290e9
Submitter : Tejun Heo <[email protected]>
Date : 2008-10-26 9:46 (28 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=242f9dcb8ba6f68fcd217a119a7648a4f69290e9
References : http://marc.info/?l=linux-kernel&m=122501447326698&w=4

2008-11-22 22:29:17

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11849] default IRQ affinity change in v2.6.27 (breaking several SMP PPC based systems)

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11849
Subject : default IRQ affinity change in v2.6.27 (breaking several SMP PPC based systems)
Submitter : Kumar Gala <[email protected]>
Date : 2008-10-24 12:45 (30 days old)
References : http://marc.info/?l=linux-kernel&m=122485245924125&w=4

2008-11-22 22:29:40

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11828] Linux 2.6.27-git3: no SD card reader

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11828
Subject : Linux 2.6.27-git3: no SD card reader
Submitter : J.A. Magallón <[email protected]>
Date : 2008-10-14 0:54 (40 days old)
References : http://marc.info/?l=linux-kernel&m=122394573904699&w=4

2008-11-22 22:29:54

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11875] radeonfb lockup in .28-rc (bisected)

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11875
Subject : radeonfb lockup in .28-rc (bisected)
Submitter : James Cloos <[email protected]>
Date : 2008-10-28 0:00 (26 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b1ee26bab14886350ba12a5c10cbc0696ac679bf
References : http://marc.info/?l=linux-kernel&m=122515210200530&w=4
http://lkml.org/lkml/2008/11/10/12
Handled-By : Benjamin Herrenschmidt <[email protected]>
Patch : http://lkml.org/lkml/2008/11/10/12

2008-11-22 22:30:38

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11898] mke2fs hang on AIC79 device.

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11898
Subject : mke2fs hang on AIC79 device.
Submitter : alexs <[email protected]>
Date : 2008-10-30 01:17 (24 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f0c0a376d0fcd4c5579ecf5e95f88387cba85211
Handled-By : James Bottomley <[email protected]>
Mike Christie <[email protected]>
Patch : http://bugzilla.kernel.org/show_bug.cgi?id=11898#c28
http://bugzilla.kernel.org/show_bug.cgi?id=11898#c36

2008-11-22 22:30:59

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11996] Tracing framework regression in 2.6.28-rc3

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11996
Subject : Tracing framework regression in 2.6.28-rc3
Submitter : Pekka Paalanen <[email protected]>
Date : 2008-11-09 10:13 (14 days old)
References : http://marc.info/?l=linux-kernel&m=122624392229317&w=4
Handled-By : Steven Rostedt <[email protected]>

2008-11-22 22:31:21

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11906] 2.6.28-rc2 seems to fail at powering down the monitor when it should

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11906
Subject : 2.6.28-rc2 seems to fail at powering down the monitor when it should
Submitter : Gene Heskett <[email protected]>
Date : 2008-10-30 6:39 (24 days old)
References : http://marc.info/?l=linux-kernel&m=122534879721424&w=4

2008-11-22 22:31:37

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11913] USB/INPUT: slab error in cache_alloc_debugcheck_after(): double free?

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11913
Subject : USB/INPUT: slab error in cache_alloc_debugcheck_after(): double free?
Submitter : Helge Deller <[email protected]>
Date : 2008-10-30 23:11 (24 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=cb8f488c33539f096580e202f5438a809195008f
References : http://marc.info/?l=linux-kernel&m=122540833301394&w=4
Handled-By : Jiri Kosina <[email protected]>
Jiri Slaby <[email protected]>
Jiri Kosina <[email protected]>
Jiri Slaby <[email protected]>
Denys Vlasenko <[email protected]>

2008-11-22 22:31:52

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11958] [2.6.27.x =&gt; 2.6.28-rc3] Xorg crash with xf86MapVidMem error

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11958
Subject : [2.6.27.x =&gt; 2.6.28-rc3] Xorg crash with xf86MapVidMem error
Submitter : Tomasz Chmielewski <[email protected]>
Date : 2008-11-05 05:37 (18 days old)

2008-11-22 22:32:15

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11965] regression introduced by - timers: fix itimer/many thread hang

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11965
Subject : regression introduced by - timers: fix itimer/many thread hang
Submitter : Doug Chapman <[email protected]>
Date : 2008-11-06 11:03 (17 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f06febc96ba8e0af80bcc3eaec0a109e88275fac
References : http://marc.info/?l=linux-kernel&m=122596943416648&w=4
Handled-By : Frank Mayhar <[email protected]>
Peter Zijlstra <[email protected]>
Ingo Molnar <[email protected]>

2008-11-22 22:32:41

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11947
Subject : 2.6.28-rc VC switching with Intel graphics broken
Submitter : Romano Giannetti <[email protected]>
Date : 2008-11-03 12:10 (20 days old)
Handled-By : Jesse Barnes <[email protected]>

2008-11-22 22:32:59

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11982] Fan level 7 after resume wit 2.6.28-rc3

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11982
Subject : Fan level 7 after resume wit 2.6.28-rc3
Submitter : Tino Keitel <[email protected]>
Date : 2008-11-05 7:33 (18 days old)
References : http://marc.info/?l=linux-kernel&m=122587043409186&w=4
Handled-By : Henrique de Moraes Holschuh <[email protected]>
Patch : http://bugzilla.kernel.org/attachment.cgi?id=18744&action=view

2008-11-22 22:33:20

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11970] gettimeofday return a old time in mmbench

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11970
Subject : gettimeofday return a old time in mmbench
Submitter : alexs <[email protected]>
Date : 2008-11-06 23:57 (17 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=99ebcf8285df28f32fd2d1c19a7166e70f00309c
Handled-By : Ingo Molnar <[email protected]>
Thomas Gleixner <[email protected]>
Yanmin Zhang <[email protected]>

2008-11-22 22:33:39

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12020] scsi_times_out NULL pointer dereference

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12020
Subject : scsi_times_out NULL pointer dereference
Submitter : Bernd Schubert <[email protected]>
Date : 2008-11-13 10:30 (10 days old)
Handled-By : James Bottomley <[email protected]>
Patch : http://bugzilla.kernel.org/show_bug.cgi?id=12020#c4

2008-11-22 22:33:52

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11925] cdrom: missing compat ioctls

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11925
Subject : cdrom: missing compat ioctls
Submitter : Andreas Schwab <[email protected]>
Date : 2008-10-31 14:02 (23 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=33c2dca4957bd0da3e1af7b96d0758d97e708ef6
Handled-By : Andreas Schwab <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122548923531545&w=2

2008-11-22 22:34:18

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12028] i915 DRM is broken in 2.6.28-rc4

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12028
Subject : i915 DRM is broken in 2.6.28-rc4
Submitter : Adam Tkac <[email protected]>
Date : 2008-11-14 01:50 (9 days old)

2008-11-22 22:34:41

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12031] DRM enabled kernel hangs hard on resume on x60

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12031
Subject : DRM enabled kernel hangs hard on resume on x60
Submitter : Jens Axboe <[email protected]>
Date : 2008-11-12 18:42 (11 days old)
References : http://marc.info/?l=linux-kernel&m=122651551216820&w=4
Handled-By : Jesse Barnes <[email protected]>

2008-11-22 22:34:59

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12034] snd-hda-intel on Realtek ALC268 chip shows only Master volume (for playback)

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12034
Subject : snd-hda-intel on Realtek ALC268 chip shows only Master volume (for playback)
Submitter : Sergey <[email protected]>
Date : 2008-11-15 04:20 (8 days old)

2008-11-22 22:35:26

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12038] Suspend regression in stable kernel 2.6.27.4 on Mac mini Core Duo

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12038
Subject : Suspend regression in stable kernel 2.6.27.4 on Mac mini Core Duo
Submitter : Tino Keitel <[email protected]>
Date : 2008-11-09 20:28 (14 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=66036f5862883fcc9f7ff8550685a5a3de1a57e4
References : http://marc.info/?l=linux-kernel&m=122626258429689&w=4
Handled-By : Rafael J. Wysocki <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122661443120581&w=4

2008-11-22 22:35:48

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12047] ACPI toshiba: only register rfkill if bt is enabled

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12047
Subject : ACPI toshiba: only register rfkill if bt is enabled
Submitter : Andrey Borzenkov <[email protected]>
Date : 2008-10-28 19:10 (26 days old)
References : http://marc.info/?l=linux-kernel&m=122522113619025&w=2
Handled-By : Frederik Deweerdt <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122526843117478&w=2

2008-11-22 22:36:05

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12081] xen: pin correct PGD on suspend

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12081
Subject : xen: pin correct PGD on suspend
Submitter : Ian Campbell <[email protected]>
Date : 2008-11-21 10:21 (2 days old)
References : http://marc.info/?l=linux-kernel&m=122726293324850&w=4
Handled-By : Ian Campbell <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122726293324850&w=4

2008-11-22 22:36:31

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12064] [regression] Measured 688 cycles TSC warp; marking TSC unstable

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12064
Subject : [regression] Measured 688 cycles TSC warp; marking TSC unstable
Submitter : Frans Pop <[email protected]>
Date : 2008-11-16 19:27:43 (7 days old)
References : http://marc.info/?l=linux-kernel&m=122686370308852&w=2

2008-11-22 22:36:47

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12082] IRQ and MSI allocations broken without sparse irq

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12082
Subject : IRQ and MSI allocations broken without sparse irq
Submitter : Jesper Dangaard Brouer <[email protected]>
Date : 2008-11-20 19:48 (3 days old)
References : http://marc.info/?l=linux-kernel&m=122721060501073&w=4
Handled-By : Thomas Gleixner <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122722773824802&w=4

2008-11-22 22:37:06

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12061] snd_hda_intel: power_save: sound cracks on powerdown

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12061
Subject : snd_hda_intel: power_save: sound cracks on powerdown
Submitter : Jens Weibler <[email protected]>
Date : 2008-11-18 12:07 (5 days old)
Handled-By : Takashi Iwai <[email protected]>

2008-11-22 23:16:36

by Benjamin Herrenschmidt

[permalink] [raw]
Subject: Re: [Bug #11875] radeonfb lockup in .28-rc (bisected)

On Sat, 2008-11-22 at 21:28 +0100, Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.27. Please verify if it still should be listed and let me know
> (either way).

The patch should definitely be merged as it fixes a problem. Andrew,
will you send it to Linus ? There's no fbdev maintainer anymore...

Here's the up to date patch (same as previously posted minus a warning
that was due to a now unused variable that I removed in this one). It
doesn't fix -other- problems reported with suspend & shutdown that have
been elusive so far (I really haven't reproduced despite some serious
torturing) and could be X bugs in the first place. I'll continue
investigating them but in the meantime, this should go in.

radeonfb: Fix problem with color expansion & alignment

The engine on some radeon variants locks up if color expansion is
called for non aligned source data. This patch enables a feature of
the core fbdev to request aligned input pixmaps and uses the HW
clipping engine to clip the output to the requested size

Signed-off-by: Benjamin Herrenschmidt <[email protected]>
---

Index: linux-work/drivers/video/aty/radeon_accel.c
===================================================================
--- linux-work.orig/drivers/video/aty/radeon_accel.c 2008-11-23 10:10:16.000000000 +1100
+++ linux-work/drivers/video/aty/radeon_accel.c 2008-11-23 10:12:34.000000000 +1100
@@ -174,12 +174,12 @@ static void radeonfb_prim_imageblit(stru
const struct fb_image *image,
u32 fg, u32 bg)
{
- unsigned int src_bytes, dwords;
+ unsigned int dwords;
u32 *bits;

radeonfb_set_creg(rinfo, DP_GUI_MASTER_CNTL, &rinfo->dp_gui_mc_cache,
rinfo->dp_gui_mc_base |
- GMC_BRUSH_NONE |
+ GMC_BRUSH_NONE | GMC_DST_CLIP_LEAVE |
GMC_SRC_DATATYPE_MONO_FG_BG |
ROP3_S |
GMC_BYTE_ORDER_MSB_TO_LSB |
@@ -189,9 +189,6 @@ static void radeonfb_prim_imageblit(stru
radeonfb_set_creg(rinfo, DP_SRC_FRGD_CLR, &rinfo->dp_src_fg_cache, fg);
radeonfb_set_creg(rinfo, DP_SRC_BKGD_CLR, &rinfo->dp_src_bg_cache, bg);

- radeon_fifo_wait(rinfo, 1);
- OUTREG(DST_Y_X, (image->dy << 16) | image->dx);
-
/* Ensure the dst cache is flushed and the engine idle before
* issuing the operation.
*
@@ -205,13 +202,19 @@ static void radeonfb_prim_imageblit(stru

/* X here pads width to a multiple of 32 and uses the clipper to
* adjust the result. Is that really necessary ? Things seem to
- * work ok for me without that and the doco doesn't seem to imply
+ * work ok for me without that and the doco doesn't seem to imply]
* there is such a restriction.
*/
- OUTREG(DST_WIDTH_HEIGHT, (image->width << 16) | image->height);
+ radeon_fifo_wait(rinfo, 4);
+ OUTREG(SC_TOP_LEFT, (image->dy << 16) | image->dx);
+ OUTREG(SC_BOTTOM_RIGHT, ((image->dy + image->height) << 16) |
+ (image->dx + image->width));
+ OUTREG(DST_Y_X, (image->dy << 16) | image->dx);
+
+ OUTREG(DST_HEIGHT_WIDTH, (image->height << 16) | ((image->width + 31) & ~31));

- src_bytes = (((image->width * image->depth) + 7) / 8) * image->height;
- dwords = (src_bytes + 3) / 4;
+ dwords = (image->width + 31) >> 5;
+ dwords *= image->height;
bits = (u32*)(image->data);

while(dwords >= 8) {
Index: linux-work/drivers/video/aty/radeon_base.c
===================================================================
--- linux-work.orig/drivers/video/aty/radeon_base.c 2008-11-23 10:10:16.000000000 +1100
+++ linux-work/drivers/video/aty/radeon_base.c 2008-11-23 10:11:02.000000000 +1100
@@ -1875,6 +1875,7 @@ static int __devinit radeon_set_fbinfo (
info->fbops = &radeonfb_ops;
info->screen_base = rinfo->fb_base;
info->screen_size = rinfo->mapped_vram;
+
/* Fill fix common fields */
strlcpy(info->fix.id, rinfo->name, sizeof(info->fix.id));
info->fix.smem_start = rinfo->fb_base_phys;
@@ -1889,8 +1890,25 @@ static int __devinit radeon_set_fbinfo (
info->fix.mmio_len = RADEON_REGSIZE;
info->fix.accel = FB_ACCEL_ATI_RADEON;

+ /* Allocate colormap */
fb_alloc_cmap(&info->cmap, 256, 0);

+ /* Setup pixmap used for acceleration */
+#define PIXMAP_SIZE (2048 * 4)
+
+ info->pixmap.addr = kmalloc(PIXMAP_SIZE, GFP_KERNEL);
+ if (!info->pixmap.addr) {
+ printk(KERN_ERR "radeonfb: Failed to allocate pixmap !\n");
+ noaccel = 1;
+ goto bail;
+ }
+ info->pixmap.size = PIXMAP_SIZE;
+ info->pixmap.flags = FB_PIXMAP_SYSTEM;
+ info->pixmap.scan_align = 4;
+ info->pixmap.buf_align = 4;
+ info->pixmap.access_align = 32;
+
+bail:
if (noaccel)
info->flags |= FBINFO_HWACCEL_DISABLED;


2008-11-22 23:44:26

by Frederik Deweerdt

[permalink] [raw]
Subject: Re: [Bug #12047] ACPI toshiba: only register rfkill if bt is enabled

On Sat, Nov 22, 2008 at 09:28:19PM +0100, Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.27. Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12047
> Subject : ACPI toshiba: only register rfkill if bt is enabled
> Submitter : Andrey Borzenkov <[email protected]>
> Date : 2008-10-28 19:10 (26 days old)
> References : http://marc.info/?l=linux-kernel&m=122522113619025&w=2
> Handled-By : Frederik Deweerdt <[email protected]>
> Patch : http://marc.info/?l=linux-kernel&m=122526843117478&w=2
This went to -mm, I just mailed Andrew about this and should go to
mainline soon.
Regards,
Frederik

2008-11-23 07:40:22

by Ingo Molnar

[permalink] [raw]
Subject: Re: [Bug #11965] regression introduced by - timers: fix itimer/many thread hang


* Rafael J. Wysocki <[email protected]> wrote:

> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.27. Please verify if it still should be listed and let me
> know (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11965
> Subject : regression introduced by - timers: fix itimer/many thread hang
> Submitter : Doug Chapman <[email protected]>
> Date : 2008-11-06 11:03 (17 days old)
> First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f06febc96ba8e0af80bcc3eaec0a109e88275fac
> References : http://marc.info/?l=linux-kernel&m=122596943416648&w=4
> Handled-By : Frank Mayhar <[email protected]>
> Peter Zijlstra <[email protected]>
> Ingo Molnar <[email protected]>

the hang is fixed by:

commit ad474caca3e2a0550b7ce0706527ad5ab389a4d4
Author: Oleg Nesterov <[email protected]>
Date: Mon Nov 10 15:39:30 2008 +0100

fix for account_group_exec_runtime(), make sure ->signal can't be freed under rq->lock

Ingo

2008-11-23 12:44:51

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [Bug #11965] regression introduced by - timers: fix itimer/many thread hang

On Sunday, 23 of November 2008, Ingo Molnar wrote:
>
> * Rafael J. Wysocki <[email protected]> wrote:
>
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.27. Please verify if it still should be listed and let me
> > know (either way).
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11965
> > Subject : regression introduced by - timers: fix itimer/many thread hang
> > Submitter : Doug Chapman <[email protected]>
> > Date : 2008-11-06 11:03 (17 days old)
> > First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f06febc96ba8e0af80bcc3eaec0a109e88275fac
> > References : http://marc.info/?l=linux-kernel&m=122596943416648&w=4
> > Handled-By : Frank Mayhar <[email protected]>
> > Peter Zijlstra <[email protected]>
> > Ingo Molnar <[email protected]>
>
> the hang is fixed by:
>
> commit ad474caca3e2a0550b7ce0706527ad5ab389a4d4
> Author: Oleg Nesterov <[email protected]>
> Date: Mon Nov 10 15:39:30 2008 +0100
>
> fix for account_group_exec_runtime(), make sure ->signal can't be freed under rq->lock

Thanks for the info and thanks for closing the bug. :-)

Rafael

2008-11-23 13:13:20

by Pekka Paalanen

[permalink] [raw]
Subject: Re: [Bug #11996] Tracing framework regression in 2.6.28-rc3

On Sat, 22 Nov 2008 21:28:17 +0100 (CET)
"Rafael J. Wysocki" <[email protected]> wrote:

> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.27. Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11996
> Subject : Tracing framework regression in 2.6.28-rc3
> Submitter : Pekka Paalanen <[email protected]>
> Date : 2008-11-09 10:13 (14 days old)
> References : http://marc.info/?l=linux-kernel&m=122624392229317&w=4
> Handled-By : Steven Rostedt <[email protected]>

Tested 2.6.28-rc6, this bug is fixed.

--
Pekka Paalanen
http://www.iki.fi/pq/

2008-11-23 13:15:20

by Ingo Molnar

[permalink] [raw]
Subject: Re: [Bug #11996] Tracing framework regression in 2.6.28-rc3


* Pekka Paalanen <[email protected]> wrote:

> On Sat, 22 Nov 2008 21:28:17 +0100 (CET)
> "Rafael J. Wysocki" <[email protected]> wrote:
>
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.27. Please verify if it still should be listed and let me know
> > (either way).
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11996
> > Subject : Tracing framework regression in 2.6.28-rc3
> > Submitter : Pekka Paalanen <[email protected]>
> > Date : 2008-11-09 10:13 (14 days old)
> > References : http://marc.info/?l=linux-kernel&m=122624392229317&w=4
> > Handled-By : Steven Rostedt <[email protected]>
>
> Tested 2.6.28-rc6, this bug is fixed.

via:

commit ee51a1de7e3837577412be269e0100038068e691
Author: Ingo Molnar <[email protected]>
Date: Thu Nov 13 14:58:31 2008 +0100

tracing: fix mmiotrace resizing crash

Pekka reported a crash when resizing the mmiotrace tracer (if only
mmiotrace is enabled).

This happens because in that case we do not allocate the max buffer,
but we try to use it.

Make ring_buffer_resize() idempotent against NULL buffers.

Reported-by: Pekka Paalanen <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>

Ingo

2008-11-23 16:30:23

by Frans Pop

[permalink] [raw]
Subject: Re: [Bug #12064] [regression] Measured 688 cycles TSC warp; marking TSC unstable

On Saturday 22 November 2008, Rafael J. Wysocki wrote:
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12064
> Date : 2008-11-16 19:27:43 (7 days old)
> References : http://marc.info/?l=linux-kernel&m=122686370308852&w=2

Looks to be fixed in -rc6:

-Calibrating delay using timer specific routine.. 6198.05 BogoMIPS (lpj=12396107)
+Calibrating delay using timer specific routine.. 6399.82 BogoMIPS (lpj=12799647)
[...]
-checking TSC synchronization [CPU#0 -> CPU#1]:
-Measured 696 cycles TSC warp between CPUs, turning off TSC clock.
-Marking TSC unstable due to check_tsc_sync_source failed
+checking TSC synchronization [CPU#0 -> CPU#1]: passed.

So, BogoMIPS value on CPU#1 is in line with CPU#0 again and TSC passes.
No idea what commit would be responsible.

Cheers,
FJP

2008-11-23 16:33:05

by Ingo Molnar

[permalink] [raw]
Subject: Re: [Bug #12064] [regression] Measured 688 cycles TSC warp; marking TSC unstable


* Frans Pop <[email protected]> wrote:

> On Saturday 22 November 2008, Rafael J. Wysocki wrote:
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12064
> > Date : 2008-11-16 19:27:43 (7 days old)
> > References : http://marc.info/?l=linux-kernel&m=122686370308852&w=2
>
> Looks to be fixed in -rc6:
>
> -Calibrating delay using timer specific routine.. 6198.05 BogoMIPS (lpj=12396107)
> +Calibrating delay using timer specific routine.. 6399.82 BogoMIPS (lpj=12799647)
> [...]
> -checking TSC synchronization [CPU#0 -> CPU#1]:
> -Measured 696 cycles TSC warp between CPUs, turning off TSC clock.
> -Marking TSC unstable due to check_tsc_sync_source failed
> +checking TSC synchronization [CPU#0 -> CPU#1]: passed.
>
> So, BogoMIPS value on CPU#1 is in line with CPU#0 again and TSC passes.
> No idea what commit would be responsible.

this one from Venki fixed it:

| commit 93ce99e849433ede4ce8b410b749dc0cad1100b2
| Author: Venki Pallipadi <[email protected]>
| Date: Mon Nov 17 14:43:58 2008 -0800
|
| x86: add rdtsc barrier to TSC sync check

Ingo

2008-11-23 17:15:31

by Alan Stern

[permalink] [raw]
Subject: Re: [linux-pm] 2.6.28-rc6-git1: Reported regressions from 2.6.27

On Sat, 22 Nov 2008, Rafael J. Wysocki wrote:

> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11858
> Subject : Timeout regression introduced by 242f9dcb8ba6f68fcd217a119a7648a4f69290e9
> Submitter : Tejun Heo <[email protected]>
> Date : 2008-10-26 9:46 (28 days old)
> First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=242f9dcb8ba6f68fcd217a119a7648a4f69290e9
> References : http://marc.info/?l=linux-kernel&m=122501447326698&w=4

This has been fixed by commit 2920ebbd65f3e80c318adf5191ac0987142bda80.

Alan Stern

2008-11-24 07:26:16

by Tino Keitel

[permalink] [raw]
Subject: Re: [Bug #11982] Fan level 7 after resume wit 2.6.28-rc3

On Sat, Nov 22, 2008 at 21:28:17 +0100, Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.27. Please verify if it still should be listed and let me know
> (either way).

git log drivers/misc/thinkpad_acpi.c shows no changes since August 1st,
so I thing it's save to assume that the regression still exists.

Regards,
Tino

2008-11-24 08:03:46

by Tino Keitel

[permalink] [raw]
Subject: Re: [Bug #12038] Suspend regression in stable kernel 2.6.27.4 on Mac mini Core Duo

On Sat, Nov 22, 2008 at 21:28:19 +0100, Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.27. Please verify if it still should be listed and let me know
> (either way).

Hi,

2.6.28-rc6 (or more precisely:
ed313489badef16d700f5a3be50e8fd8f8294bc8) still hangs my Mac after
resume, and git log drivers/acpi/sleep/main.c shows no relevant commits.

Regards,
Tino

2008-11-24 08:32:58

by Justin P. Mattock

[permalink] [raw]
Subject: Re: [Bug #12038] Suspend regression in stable kernel 2.6.27.4 on Mac mini Core Duo

On Mon, 2008-11-24 at 09:03 +0100, Tino Keitel wrote:
> On Sat, Nov 22, 2008 at 21:28:19 +0100, Rafael J. Wysocki wrote:
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.27. Please verify if it still should be listed and let me know
> > (either way).
>
> Hi,
>
> 2.6.28-rc6 (or more precisely:
> ed313489badef16d700f5a3be50e8fd8f8294bc8) still hangs my Mac after
> resume, and git log drivers/acpi/sleep/main.c shows no relevant commits.
>
> Regards,
> Tino
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

I'm not getting a freeze here(was getting strange cpu frequencies
though); My setup here is the latest xserver from intrepid
readeon, and s2ram app. echo mem > /sys/power/state gives
me a black screen, then an instant reboot. s2ram recovers
as expected. Although I'm not sure what the setup is with macmini,
I've a macbook pro ati chipset.

regards;
--
Justin P. Mattock <[email protected]>

2008-11-24 08:47:42

by Romano Giannetti

[permalink] [raw]
Subject: Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken


Rafael J. Wysocki wrote:
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11947
> Subject : 2.6.28-rc VC switching with Intel graphics broken
> Submitter : Romano Giannetti <[email protected]>
> Date : 2008-11-03 12:10 (20 days old)
> Handled-By : Jesse Barnes <[email protected]>
>

Still with us on -rc6, nasty, reproducible, no clues on what can be.

VC switch locks or delay the systems minutes, resuming from suspend locks hard
the machine.

2.6.28-rc is unusable here.

Jesse, any hints? My suspicion that it can be the same thing happened with bug
10620 is wrong? (It was a very similar error about vblank...)

Romano

--
Sorry for the disclaimer --- ¡I cannot stop it!


--
La presente comunicación tiene carácter confidencial y es para el exclusivo uso del destinatario indicado en la misma. Si Ud. no es el destinatario indicado, le informamos que cualquier forma de distribución, reproducción o uso de esta comunicación y/o de la información contenida en la misma están estrictamente prohibidos por la ley. Si Ud. ha recibido esta comunicación por error, por favor, notifíquelo inmediatamente al remitente contestando a este mensaje y proceda a continuación a destruirlo. Gracias por su colaboración.

This communication contains confidential information. It is for the exclusive use of the intended addressee. If you are not the intended addressee, please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited by law. If you have received this communication in error, please immediately notify the sender by reply e-mail and destroy this message. Thank you for your cooperation.

2008-11-24 13:36:44

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [Bug #12031] DRM enabled kernel hangs hard on resume on x60

On Saturday, 22 of November 2008, Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.27. Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12031
> Subject : DRM enabled kernel hangs hard on resume on x60
> Submitter : Jens Axboe <[email protected]>
> Date : 2008-11-12 18:42 (11 days old)
> References : http://marc.info/?l=linux-kernel&m=122651551216820&w=4
> Handled-By : Jesse Barnes <[email protected]>

I can reproduce this problem on Toshiba Portege R500, with the same symptoms
(please see the bug entry for details).

Well, we have at lease three DRM-related regressions in 2.6.28-rc and no
visible reaction from the developers/maintainers of the code in question. :-(

Thanks,
Rafael

2008-11-24 17:50:56

by Jesse Barnes

[permalink] [raw]
Subject: Re: [Bug #12031] DRM enabled kernel hangs hard on resume on x60

On Monday, November 24, 2008 5:36 am Rafael J. Wysocki wrote:
> On Saturday, 22 of November 2008, Rafael J. Wysocki wrote:
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.27. Please verify if it still should be listed and let me know
> > (either way).
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12031
> > Subject : DRM enabled kernel hangs hard on resume on x60
> > Submitter : Jens Axboe <[email protected]>
> > Date : 2008-11-12 18:42 (11 days old)
> > References : http://marc.info/?l=linux-kernel&m=122651551216820&w=4
> > Handled-By : Jesse Barnes <[email protected]>
>
> I can reproduce this problem on Toshiba Portege R500, with the same
> symptoms (please see the bug entry for details).
>
> Well, we have at lease three DRM-related regressions in 2.6.28-rc and no
> visible reaction from the developers/maintainers of the code in question.
> :-(

Sorry, I've been away for awhile. I'll dig through the latest info on these
regressions today.

--
Jesse Barnes, Intel Open Source Technology Center

2008-11-24 19:02:20

by Jesse Barnes

[permalink] [raw]
Subject: Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

On Monday, November 24, 2008 12:47 am Romano Giannetti (lists) wrote:
> Rafael J. Wysocki wrote:
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11947
> > Subject : 2.6.28-rc VC switching with Intel graphics broken
> > Submitter : Romano Giannetti <[email protected]>
> > Date : 2008-11-03 12:10 (20 days old)
> > Handled-By : Jesse Barnes <[email protected]>
>
> Still with us on -rc6, nasty, reproducible, no clues on what can be.
>
> VC switch locks or delay the systems minutes, resuming from suspend locks
> hard the machine.
>
> 2.6.28-rc is unusable here.
>
> Jesse, any hints? My suspicion that it can be the same thing happened with
> bug 10620 is wrong? (It was a very similar error about vblank...)

Just added to the bug, it looks like a DUP of an issue Keith just fixed last
week (now to make sure the patch makes it upstream quickly).

--
Jesse Barnes, Intel Open Source Technology Center

2008-11-24 19:13:22

by Bernhard Schmidt

[permalink] [raw]
Subject: Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

Hello,

> On Monday, November 24, 2008 12:47 am Romano Giannetti (lists) wrote:
>> Rafael J. Wysocki wrote:
>>> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11947
>>> Subject : 2.6.28-rc VC switching with Intel graphics broken
>>> Submitter : Romano Giannetti <[email protected]>
>>> Date : 2008-11-03 12:10 (20 days old)
>>> Handled-By : Jesse Barnes <[email protected]>
>> Still with us on -rc6, nasty, reproducible, no clues on what can be.
>>
>> VC switch locks or delay the systems minutes, resuming from suspend locks
>> hard the machine.
>>
>> 2.6.28-rc is unusable here.
>>
>> Jesse, any hints? My suspicion that it can be the same thing happened with
>> bug 10620 is wrong? (It was a very similar error about vblank...)
>
> Just added to the bug, it looks like a DUP of an issue Keith just fixed last
> week (now to make sure the patch makes it upstream quickly).

I can confirm that, with the patch from
http://lists.freedesktop.org/archives/intel-gfx/2008-November/000614.html
applied on top of current git head (rejected hunk in
drivers/gpu/drm/i915/915_irq.c due to the additional
dev_priv->irq_mask_reg = ~0; in git between the removed lines, I kept
it) I can suspend/resume and do a VC switch again.

Big thanks!

Bernhard

2008-11-24 19:35:45

by Jesse Barnes

[permalink] [raw]
Subject: Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

On Monday, November 24, 2008 11:13 am Bernhard Schmidt wrote:
> Hello,
>
> > On Monday, November 24, 2008 12:47 am Romano Giannetti (lists) wrote:
> >> Rafael J. Wysocki wrote:
> >>> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11947
> >>> Subject : 2.6.28-rc VC switching with Intel graphics broken
> >>> Submitter : Romano Giannetti <[email protected]>
> >>> Date : 2008-11-03 12:10 (20 days old)
> >>> Handled-By : Jesse Barnes <[email protected]>
> >>
> >> Still with us on -rc6, nasty, reproducible, no clues on what can be.
> >>
> >> VC switch locks or delay the systems minutes, resuming from suspend
> >> locks hard the machine.
> >>
> >> 2.6.28-rc is unusable here.
> >>
> >> Jesse, any hints? My suspicion that it can be the same thing happened
> >> with bug 10620 is wrong? (It was a very similar error about vblank...)
> >
> > Just added to the bug, it looks like a DUP of an issue Keith just fixed
> > last week (now to make sure the patch makes it upstream quickly).
>
> I can confirm that, with the patch from
> http://lists.freedesktop.org/archives/intel-gfx/2008-November/000614.html
> applied on top of current git head (rejected hunk in
> drivers/gpu/drm/i915/915_irq.c due to the additional
> dev_priv->irq_mask_reg = ~0; in git between the removed lines, I kept
> it) I can suspend/resume and do a VC switch again.
>
> Big thanks!

Excellent, thanks for confirming. I just pinged the maintainer, hopefully we
can get this patch pushed quickly.

--
Jesse Barnes, Intel Open Source Technology Center

2008-11-25 11:01:43

by Romano Giannetti

[permalink] [raw]
Subject: Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken


[resent - sorry, LKML sent it back --- my bad]
Jesse Barnes wrote:
>
> Just added to the bug, it looks like a DUP of an issue Keith just fixed last
> week (now to make sure the patch makes it upstream quickly).
>
Tried the patch and tested, it works ok. VC switching and suspend/resume
fixed. More details on bugzilla.

Tested-by: Romano Giannetti <[email protected]>

Thanks to all!
Romano

--
Sorry for the disclaimer --- ¡I cannot stop it!


--
La presente comunicación tiene carácter confidencial y es para el exclusivo uso del destinatario indicado en la misma. Si Ud. no es el destinatario indicado, le informamos que cualquier forma de distribución, reproducción o uso de esta comunicación y/o de la información contenida en la misma están estrictamente prohibidos por la ley. Si Ud. ha recibido esta comunicación por error, por favor, notifíquelo inmediatamente al remitente contestando a este mensaje y proceda a continuación a destruirlo. Gracias por su colaboración.

This communication contains confidential information. It is for the exclusive use of the intended addressee. If you are not the intended addressee, please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited by law. If you have received this communication in error, please immediately notify the sender by reply e-mail and destroy this message. Thank you for your cooperation.

2008-11-26 08:36:25

by Ingo Molnar

[permalink] [raw]
Subject: Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken


* Bernhard Schmidt <[email protected]> wrote:

> Hello,
>
>> On Monday, November 24, 2008 12:47 am Romano Giannetti (lists) wrote:
>>> Rafael J. Wysocki wrote:
>>>> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11947
>>>> Subject : 2.6.28-rc VC switching with Intel graphics broken
>>>> Submitter : Romano Giannetti <[email protected]>
>>>> Date : 2008-11-03 12:10 (20 days old)
>>>> Handled-By : Jesse Barnes <[email protected]>
>>> Still with us on -rc6, nasty, reproducible, no clues on what can be.
>>>
>>> VC switch locks or delay the systems minutes, resuming from suspend locks
>>> hard the machine.
>>>
>>> 2.6.28-rc is unusable here.
>>>
>>> Jesse, any hints? My suspicion that it can be the same thing happened with
>>> bug 10620 is wrong? (It was a very similar error about vblank...)
>>
>> Just added to the bug, it looks like a DUP of an issue Keith just fixed
>> last week (now to make sure the patch makes it upstream quickly).
>
> I can confirm that, with the patch from
> http://lists.freedesktop.org/archives/intel-gfx/2008-November/000614.html
> applied on top of current git head (rejected hunk in
> drivers/gpu/drm/i915/915_irq.c due to the additional
> dev_priv->irq_mask_reg = ~0; in git between the removed lines, I kept
> it) I can suspend/resume and do a VC switch again.
>
> Big thanks!

here it is below plaintext as well, merged up to latest -git.

Ingo

------------------->
>From 60174462808051477793776c67282364bc94ded3 Mon Sep 17 00:00:00 2001
From: Keith Packard <[email protected]>
Date: Tue, 18 Nov 2008 09:30:25 -0800
Subject: [PATCH] drm: move drm vblank initialization/cleanup to driver load/unload

drm vblank initialization keeps track of the changes in driver-supplied
frame counts across vt switch and mode setting, but only if you let it by
not tearing down the drm vblank structure.

Signed-off-by: Keith Packard <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
---
drivers/gpu/drm/drm_drv.c | 2 ++
drivers/gpu/drm/drm_irq.c | 4 +---
drivers/gpu/drm/i915/i915_dma.c | 5 +++++
drivers/gpu/drm/i915/i915_drv.h | 2 ++
drivers/gpu/drm/i915/i915_irq.c | 5 -----
include/drm/drmP.h | 1 +
6 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index 3ab1e9c..996097a 100644
--- a/drivers/gpu/drm/drm_drv.c
+++ b/drivers/gpu/drm/drm_drv.c
@@ -305,6 +305,8 @@ static void drm_cleanup(struct drm_device * dev)
return;
}

+ drm_vblank_cleanup(dev);
+
drm_lastclose(dev);

if (drm_core_has_MTRR(dev) && drm_core_has_AGP(dev) &&
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
index 15c8dab..1e787f8 100644
--- a/drivers/gpu/drm/drm_irq.c
+++ b/drivers/gpu/drm/drm_irq.c
@@ -94,7 +94,7 @@ static void vblank_disable_fn(unsigned long arg)
}
}

-static void drm_vblank_cleanup(struct drm_device *dev)
+void drm_vblank_cleanup(struct drm_device *dev)
{
/* Bail if the driver didn't call drm_vblank_init() */
if (dev->num_crtcs == 0)
@@ -278,8 +278,6 @@ int drm_irq_uninstall(struct drm_device * dev)

free_irq(dev->pdev->irq, dev);

- drm_vblank_cleanup(dev);
-
return 0;
}
EXPORT_SYMBOL(drm_irq_uninstall);
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
index 0d215e3..9a1450e 100644
--- a/drivers/gpu/drm/i915/i915_dma.c
+++ b/drivers/gpu/drm/i915/i915_dma.c
@@ -856,6 +856,11 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags)

spin_lock_init(&dev_priv->user_irq_lock);

+ ret = drm_vblank_init(dev, I915_NUM_PIPE);
+
+ if (ret)
+ return ret;
+
return ret;
}

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index ef1c0b8..ec78190 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -47,6 +47,8 @@ enum pipe {
PIPE_B,
};

+#define I915_NUM_PIPE 2
+
/* Interface history:
*
* 1.1: Original.
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 82752d6..a60af31 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -483,14 +483,9 @@ void i915_driver_irq_preinstall(struct drm_device * dev)
int i915_driver_irq_postinstall(struct drm_device *dev)
{
drm_i915_private_t *dev_priv = (drm_i915_private_t *) dev->dev_private;
- int ret, num_pipes = 2;
-
/* Set initial unmasked IRQs to just the selected vblank pipes. */
dev_priv->irq_mask_reg = ~0;

- ret = drm_vblank_init(dev, num_pipes);
- if (ret)
- return ret;

dev_priv->vblank_pipe = DRM_I915_VBLANK_PIPE_A | DRM_I915_VBLANK_PIPE_B;
dev_priv->irq_mask_reg &= ~I915_DISPLAY_PIPE_A_VBLANK_INTERRUPT;
diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 28c7f16..d5e8e5c 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -1151,6 +1151,7 @@ extern u32 drm_vblank_count(struct drm_device *dev, int crtc);
extern void drm_handle_vblank(struct drm_device *dev, int crtc);
extern int drm_vblank_get(struct drm_device *dev, int crtc);
extern void drm_vblank_put(struct drm_device *dev, int crtc);
+extern void drm_vblank_cleanup(struct drm_device *dev);
/* Modesetting support */
extern int drm_modeset_ctl(struct drm_device *dev, void *data,
struct drm_file *file_priv);

2008-11-26 14:45:35

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

On Wednesday, 26 of November 2008, Ingo Molnar wrote:
>
> * Bernhard Schmidt <[email protected]> wrote:
>
> > Hello,
> >
> >> On Monday, November 24, 2008 12:47 am Romano Giannetti (lists) wrote:
> >>> Rafael J. Wysocki wrote:
> >>>> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11947
> >>>> Subject : 2.6.28-rc VC switching with Intel graphics broken
> >>>> Submitter : Romano Giannetti <[email protected]>
> >>>> Date : 2008-11-03 12:10 (20 days old)
> >>>> Handled-By : Jesse Barnes <[email protected]>
> >>> Still with us on -rc6, nasty, reproducible, no clues on what can be.
> >>>
> >>> VC switch locks or delay the systems minutes, resuming from suspend locks
> >>> hard the machine.
> >>>
> >>> 2.6.28-rc is unusable here.
> >>>
> >>> Jesse, any hints? My suspicion that it can be the same thing happened with
> >>> bug 10620 is wrong? (It was a very similar error about vblank...)
> >>
> >> Just added to the bug, it looks like a DUP of an issue Keith just fixed
> >> last week (now to make sure the patch makes it upstream quickly).
> >
> > I can confirm that, with the patch from
> > http://lists.freedesktop.org/archives/intel-gfx/2008-November/000614.html
> > applied on top of current git head (rejected hunk in
> > drivers/gpu/drm/i915/915_irq.c due to the additional
> > dev_priv->irq_mask_reg = ~0; in git between the removed lines, I kept
> > it) I can suspend/resume and do a VC switch again.
> >
> > Big thanks!
>
> here it is below plaintext as well, merged up to latest -git.

Well, I still have a resume issue with this patch applied on Toshiba Portege
R500 (please see http://bugzilla.kernel.org/show_bug.cgi?id=12031#c9 for
details).

Thanks,
Rafael


> ------------------->
> From 60174462808051477793776c67282364bc94ded3 Mon Sep 17 00:00:00 2001
> From: Keith Packard <[email protected]>
> Date: Tue, 18 Nov 2008 09:30:25 -0800
> Subject: [PATCH] drm: move drm vblank initialization/cleanup to driver load/unload
>
> drm vblank initialization keeps track of the changes in driver-supplied
> frame counts across vt switch and mode setting, but only if you let it by
> not tearing down the drm vblank structure.
>
> Signed-off-by: Keith Packard <[email protected]>
> Signed-off-by: Ingo Molnar <[email protected]>
> ---
> drivers/gpu/drm/drm_drv.c | 2 ++
> drivers/gpu/drm/drm_irq.c | 4 +---
> drivers/gpu/drm/i915/i915_dma.c | 5 +++++
> drivers/gpu/drm/i915/i915_drv.h | 2 ++
> drivers/gpu/drm/i915/i915_irq.c | 5 -----
> include/drm/drmP.h | 1 +
> 6 files changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
> index 3ab1e9c..996097a 100644
> --- a/drivers/gpu/drm/drm_drv.c
> +++ b/drivers/gpu/drm/drm_drv.c
> @@ -305,6 +305,8 @@ static void drm_cleanup(struct drm_device * dev)
> return;
> }
>
> + drm_vblank_cleanup(dev);
> +
> drm_lastclose(dev);
>
> if (drm_core_has_MTRR(dev) && drm_core_has_AGP(dev) &&
> diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
> index 15c8dab..1e787f8 100644
> --- a/drivers/gpu/drm/drm_irq.c
> +++ b/drivers/gpu/drm/drm_irq.c
> @@ -94,7 +94,7 @@ static void vblank_disable_fn(unsigned long arg)
> }
> }
>
> -static void drm_vblank_cleanup(struct drm_device *dev)
> +void drm_vblank_cleanup(struct drm_device *dev)
> {
> /* Bail if the driver didn't call drm_vblank_init() */
> if (dev->num_crtcs == 0)
> @@ -278,8 +278,6 @@ int drm_irq_uninstall(struct drm_device * dev)
>
> free_irq(dev->pdev->irq, dev);
>
> - drm_vblank_cleanup(dev);
> -
> return 0;
> }
> EXPORT_SYMBOL(drm_irq_uninstall);
> diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
> index 0d215e3..9a1450e 100644
> --- a/drivers/gpu/drm/i915/i915_dma.c
> +++ b/drivers/gpu/drm/i915/i915_dma.c
> @@ -856,6 +856,11 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags)
>
> spin_lock_init(&dev_priv->user_irq_lock);
>
> + ret = drm_vblank_init(dev, I915_NUM_PIPE);
> +
> + if (ret)
> + return ret;
> +
> return ret;
> }
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index ef1c0b8..ec78190 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -47,6 +47,8 @@ enum pipe {
> PIPE_B,
> };
>
> +#define I915_NUM_PIPE 2
> +
> /* Interface history:
> *
> * 1.1: Original.
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 82752d6..a60af31 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -483,14 +483,9 @@ void i915_driver_irq_preinstall(struct drm_device * dev)
> int i915_driver_irq_postinstall(struct drm_device *dev)
> {
> drm_i915_private_t *dev_priv = (drm_i915_private_t *) dev->dev_private;
> - int ret, num_pipes = 2;
> -
> /* Set initial unmasked IRQs to just the selected vblank pipes. */
> dev_priv->irq_mask_reg = ~0;
>
> - ret = drm_vblank_init(dev, num_pipes);
> - if (ret)
> - return ret;
>
> dev_priv->vblank_pipe = DRM_I915_VBLANK_PIPE_A | DRM_I915_VBLANK_PIPE_B;
> dev_priv->irq_mask_reg &= ~I915_DISPLAY_PIPE_A_VBLANK_INTERRUPT;
> diff --git a/include/drm/drmP.h b/include/drm/drmP.h
> index 28c7f16..d5e8e5c 100644
> --- a/include/drm/drmP.h
> +++ b/include/drm/drmP.h
> @@ -1151,6 +1151,7 @@ extern u32 drm_vblank_count(struct drm_device *dev, int crtc);
> extern void drm_handle_vblank(struct drm_device *dev, int crtc);
> extern int drm_vblank_get(struct drm_device *dev, int crtc);
> extern void drm_vblank_put(struct drm_device *dev, int crtc);
> +extern void drm_vblank_cleanup(struct drm_device *dev);
> /* Modesetting support */
> extern int drm_modeset_ctl(struct drm_device *dev, void *data,
> struct drm_file *file_priv);
>
>



--
Everyone knows that debugging is twice as hard as writing a program
in the first place. So if you're as clever as you can be when you write it,
how will you ever debug it? --- Brian Kernighan