2021-01-18 14:00:08

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

On Mon, Jan 18, 2021 at 11:12:34AM +0000, Barnabás Pőcze wrote:
> 2021. január 18., hétfő 1:34 keltezéssel, Daniel Scally írta:

> Have you considered putting the source (and header) files into a dedicated
> folder? I think it'd help manageability in the long run, and it'd be immediately
> obvious that these source files form a single "unit".

What would be the folder name? Because, for example, intel_cht_int33fe* have no
folder (yet?) and here it's kinda similar case when HID describes something
else than just one IP.

--
With Best Regards,
Andy Shevchenko



2021-01-19 04:36:23

by Barnabás Pőcze

[permalink] [raw]
Subject: Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021. január 18., hétfő 14:51 keltezéssel, Andy Shevchenko írta:

> On Mon, Jan 18, 2021 at 11:12:34AM +0000, Barnabás Pőcze wrote:
> > 2021. január 18., hétfő 1:34 keltezéssel, Daniel Scally írta:
>
> > Have you considered putting the source (and header) files into a dedicated
> > folder? I think it'd help manageability in the long run, and it'd be immediately
> > obvious that these source files form a single "unit".
>
> What would be the folder name? Because, for example, intel_cht_int33fe* have no
> folder (yet?) and here it's kinda similar case when HID describes something
> else than just one IP.

I think "intel_skl_int3472" would not be a bad name for the folder. And I believe
"intel_cht_int33fe" could be given its own folder as well.


Regards,
Barnabás Pőcze