2011-02-02 23:16:49

by Peter Chubb

[permalink] [raw]
Subject: tcp_ecn is an integer not a boolean


There was some confusion at LCA as to why the sysctl tcp_ecn took one
of three values when it was documented as a Boolean. This patch fixes
the documentation.

Signed-off-by: Peter Chubb <[email protected]>

diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index d99940d..ac3b4a7 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -187,7 +187,7 @@ tcp_cookie_size - INTEGER
tcp_dsack - BOOLEAN
Allows TCP to send "duplicate" SACKs.

-tcp_ecn - BOOLEAN
+tcp_ecn - INTEGER
Enable Explicit Congestion Notification (ECN) in TCP. ECN is only
used when both ends of the TCP flow support it. It is useful to
avoid losses due to congestion (when the bottleneck router supports

--
Dr Peter Chubb peter DOT chubb AT nicta.com.au
http://www.ertos.nicta.com.au ERTOS within National ICT Australia
All things shall perish from under the sky/Music alone shall live, never to die


2011-02-02 23:39:42

by David Miller

[permalink] [raw]
Subject: Re: tcp_ecn is an integer not a boolean

From: Peter Chubb <[email protected]>
Date: Thu, 03 Feb 2011 09:49:08 +1100

>
> There was some confusion at LCA as to why the sysctl tcp_ecn took one
> of three values when it was documented as a Boolean. This patch fixes
> the documentation.
>
> Signed-off-by: Peter Chubb <[email protected]>

Applied, thanks Peter.

2011-02-03 10:27:00

by Jiri Kosina

[permalink] [raw]
Subject: Re: tcp_ecn is an integer not a boolean

On Thu, 3 Feb 2011, Peter Chubb wrote:

>
> There was some confusion at LCA as to why the sysctl tcp_ecn took one
> of three values when it was documented as a Boolean. This patch fixes
> the documentation.
>
> Signed-off-by: Peter Chubb <[email protected]>
>
> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
> index d99940d..ac3b4a7 100644
> --- a/Documentation/networking/ip-sysctl.txt
> +++ b/Documentation/networking/ip-sysctl.txt
> @@ -187,7 +187,7 @@ tcp_cookie_size - INTEGER
> tcp_dsack - BOOLEAN
> Allows TCP to send "duplicate" SACKs.
>
> -tcp_ecn - BOOLEAN
> +tcp_ecn - INTEGER

Applied, thanks.

--
Jiri Kosina
SUSE Labs, Novell Inc.

2011-02-03 21:35:25

by David Miller

[permalink] [raw]
Subject: Re: tcp_ecn is an integer not a boolean

From: Jiri Kosina <[email protected]>
Date: Thu, 3 Feb 2011 11:26:57 +0100 (CET)

> On Thu, 3 Feb 2011, Peter Chubb wrote:
>
>>
>> There was some confusion at LCA as to why the sysctl tcp_ecn took one
>> of three values when it was documented as a Boolean. This patch fixes
>> the documentation.
>>
>> Signed-off-by: Peter Chubb <[email protected]>
>>
>> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
>> index d99940d..ac3b4a7 100644
>> --- a/Documentation/networking/ip-sysctl.txt
>> +++ b/Documentation/networking/ip-sysctl.txt
>> @@ -187,7 +187,7 @@ tcp_cookie_size - INTEGER
>> tcp_dsack - BOOLEAN
>> Allows TCP to send "duplicate" SACKs.
>>
>> -tcp_ecn - BOOLEAN
>> +tcp_ecn - INTEGER
>
> Applied, thanks.

There is no need, did you see my reply? I put it into the net-2.6
GIT tree already.

2011-02-03 21:45:27

by Jiri Kosina

[permalink] [raw]
Subject: Re: tcp_ecn is an integer not a boolean

On Thu, 3 Feb 2011, David Miller wrote:

> >> There was some confusion at LCA as to why the sysctl tcp_ecn took one
> >> of three values when it was documented as a Boolean. This patch fixes
> >> the documentation.
> >>
> >> Signed-off-by: Peter Chubb <[email protected]>
> >>
> >> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
> >> index d99940d..ac3b4a7 100644
> >> --- a/Documentation/networking/ip-sysctl.txt
> >> +++ b/Documentation/networking/ip-sysctl.txt
> >> @@ -187,7 +187,7 @@ tcp_cookie_size - INTEGER
> >> tcp_dsack - BOOLEAN
> >> Allows TCP to send "duplicate" SACKs.
> >>
> >> -tcp_ecn - BOOLEAN
> >> +tcp_ecn - INTEGER
> >
> > Applied, thanks.
>
> There is no need, did you see my reply? I put it into the net-2.6
> GIT tree already.

Ah, no, I haven't, because Peter apparently originaly sent it to ancient
[email protected] and only then bounced it to proper address, but
your followup went to the old one as well.

OK, I will drop it, thanks for letting me know.

--
Jiri Kosina
SUSE Labs, Novell Inc.