2001-10-30 22:49:35

by Shyouzou Sugitani

[permalink] [raw]
Subject: [PATCH] Intel 845 support for agpgart

Hi,

this patch for 2.4.14-pre5 adds support for the Intel i845 chipset to
the agpgart module.
It seems to work fine on my ASUS P4B with Matrox G450.

--
Regards,
Shyouzou Sugitani <[email protected]>


Attachments:
agp_i845.diff (5.43 kB)

2001-10-30 23:53:54

by GOTO Masanori

[permalink] [raw]
Subject: Re: [PATCH] Intel 845 support for agpgart

At Wed, 31 Oct 2001 07:49:18 +0900,
Shyouzou Sugitani <[email protected]> wrote:
> Hi,
>
> this patch for 2.4.14-pre5 adds support for the Intel i845 chipset to
> the agpgart module.
> It seems to work fine on my ASUS P4B with Matrox G450.

Aha, this patch already sent by me some hours before
and its function is totally same :-)

Alan, please apply our patch.

Thanks,
-- gotom

2001-10-31 02:30:06

by Shyouzou Sugitani

[permalink] [raw]
Subject: Re: [PATCH] Intel 845 support for agpgart

At Wed, 31 Oct 2001 08:54:06 +0900
GOTO Masanori <[email protected]> wrote:
> Aha, this patch already sent by me some hours before
> and its function is totally same :-)

OK, I read your patch which appeared in Linux-Kernel Archive and found
that its function is not totally same.

The MCHCFG register of i845 is only 8bits.

--
Regards,
Shyouzou Sugitani <[email protected]>

2001-10-31 04:21:24

by GOTO Masanori

[permalink] [raw]
Subject: Re: [PATCH] Intel 845 support for agpgart

At Wed, 31 Oct 2001 11:30:03 +0900,
Shyouzou Sugitani <[email protected]> wrote:
>
> At Wed, 31 Oct 2001 08:54:06 +0900
> GOTO Masanori <[email protected]> wrote:
> > Aha, this patch already sent by me some hours before
> > and its function is totally same :-)
>
> OK, I read your patch which appeared in Linux-Kernel Archive and found
> that its function is not totally same.
>
> The MCHCFG register of i845 is only 8bits.

Ahh, you're right, it's my mistake...
BTW, I've noticed trivial issue that INTEL_I845_MCHCFG is not appropriate name.
Changing INTEL_I845_MCHCFG -> INTEL_I845_AGPM or so is more
appropriate because MCHCFG indicates other register 0xC6.
The patch for -ac5 with yours and merging me drm is at:
http://www2.fe.dis.titech.ac.jp/~gotom/tmp/linux/patch.2.4.13-ac5.agp

Regards,
-- gotom