According to documentation, the current supplies for the USB1 SS0,
SS1 and SS2 both QMP combo PHYS and eUSB2 PHYs are all wrong. Fix
them accordingly.
Signed-off-by: Abel Vesa <[email protected]>
---
Abel Vesa (2):
arm64: dts: qcom: x1e80100-crd: Fix USB PHYs regulators
arm64: dts: qcom: x1e80100-qcp: Fix USB PHYs regulators
arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 15 ++++++++++++---
arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 15 ++++++++++++---
2 files changed, 24 insertions(+), 6 deletions(-)
---
base-commit: 9d99040b1bc8dbf385a8aa535e9efcdf94466e19
change-id: 20240530-x1e80100-dts-fix-usb-phy-supplies-c3cbc578a2f6
Best regards,
--
Abel Vesa <[email protected]>
The 1.2v HS PHY shared regulator is actually LDO2 from PM8550ve id J.
Also add the missing supplies to QMP PHYs.
Fixes: 22b82135c02d ("arm64: dts: qcom: x1e80100-qcp: Enable more support")
Signed-off-by: Abel Vesa <[email protected]>
---
arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
index 3de7565dda19..f4b47e6b3a2f 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
@@ -537,7 +537,7 @@ &uart21 {
&usb_1_ss0_hsphy {
vdd-supply = <&vreg_l2e_0p8>;
- vdda12-supply = <&vreg_l3e_1p2>;
+ vdda12-supply = <&vreg_l2j_1p2>;
phys = <&smb2360_0_eusb2_repeater>;
@@ -545,6 +545,9 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
+ vdda-phy-supply = <&vreg_l3e_1p2>;
+ vdda-pll-supply = <&vreg_l1j_0p8>;
+
status = "okay";
};
@@ -558,7 +561,7 @@ &usb_1_ss0_dwc3 {
&usb_1_ss1_hsphy {
vdd-supply = <&vreg_l2e_0p8>;
- vdda12-supply = <&vreg_l3e_1p2>;
+ vdda12-supply = <&vreg_l2j_1p2>;
phys = <&smb2360_1_eusb2_repeater>;
@@ -566,6 +569,9 @@ &usb_1_ss1_hsphy {
};
&usb_1_ss1_qmpphy {
+ vdda-phy-supply = <&vreg_l3e_1p2>;
+ vdda-pll-supply = <&vreg_l2d_0p9>;
+
status = "okay";
};
@@ -579,7 +585,7 @@ &usb_1_ss1_dwc3 {
&usb_1_ss2_hsphy {
vdd-supply = <&vreg_l2e_0p8>;
- vdda12-supply = <&vreg_l3e_1p2>;
+ vdda12-supply = <&vreg_l2j_1p2>;
phys = <&smb2360_2_eusb2_repeater>;
@@ -587,6 +593,9 @@ &usb_1_ss2_hsphy {
};
&usb_1_ss2_qmpphy {
+ vdda-phy-supply = <&vreg_l3e_1p2>;
+ vdda-pll-supply = <&vreg_l2d_0p9>;
+
status = "okay";
};
--
2.34.1
The 1.2v HS PHY shared regulator is actually LDO2 from PM8550ve id J.
Also add the missing supplies to QMP PHYs.
Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support")
Signed-off-by: Abel Vesa <[email protected]>
---
arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
index ed8b80627534..173a88b6b8b8 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
@@ -841,7 +841,7 @@ &uart21 {
&usb_1_ss0_hsphy {
vdd-supply = <&vreg_l2e_0p8>;
- vdda12-supply = <&vreg_l3e_1p2>;
+ vdda12-supply = <&vreg_l2j_1p2>;
phys = <&smb2360_0_eusb2_repeater>;
@@ -849,6 +849,9 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
+ vdda-phy-supply = <&vreg_l3e_1p2>;
+ vdda-pll-supply = <&vreg_l1j_0p8>;
+
status = "okay";
};
@@ -862,7 +865,7 @@ &usb_1_ss0_dwc3 {
&usb_1_ss1_hsphy {
vdd-supply = <&vreg_l2e_0p8>;
- vdda12-supply = <&vreg_l3e_1p2>;
+ vdda12-supply = <&vreg_l2j_1p2>;
phys = <&smb2360_1_eusb2_repeater>;
@@ -870,6 +873,9 @@ &usb_1_ss1_hsphy {
};
&usb_1_ss1_qmpphy {
+ vdda-phy-supply = <&vreg_l3e_1p2>;
+ vdda-pll-supply = <&vreg_l2d_0p9>;
+
status = "okay";
};
@@ -883,7 +889,7 @@ &usb_1_ss1_dwc3 {
&usb_1_ss2_hsphy {
vdd-supply = <&vreg_l2e_0p8>;
- vdda12-supply = <&vreg_l3e_1p2>;
+ vdda12-supply = <&vreg_l2j_1p2>;
phys = <&smb2360_2_eusb2_repeater>;
@@ -891,6 +897,9 @@ &usb_1_ss2_hsphy {
};
&usb_1_ss2_qmpphy {
+ vdda-phy-supply = <&vreg_l3e_1p2>;
+ vdda-pll-supply = <&vreg_l2d_0p9>;
+
status = "okay";
};
--
2.34.1
On Thu, May 30, 2024 at 07:35:45PM +0300, Abel Vesa wrote:
> The 1.2v HS PHY shared regulator is actually LDO2 from PM8550ve id J.
> Also add the missing supplies to QMP PHYs.
>
> Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support")
> Signed-off-by: Abel Vesa <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <[email protected]>
--
With best wishes
Dmitry
On Thu, May 30, 2024 at 07:35:46PM +0300, Abel Vesa wrote:
> The 1.2v HS PHY shared regulator is actually LDO2 from PM8550ve id J.
> Also add the missing supplies to QMP PHYs.
>
> Fixes: 22b82135c02d ("arm64: dts: qcom: x1e80100-qcp: Enable more support")
> Signed-off-by: Abel Vesa <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <[email protected]>
--
With best wishes
Dmitry
On Thu, May 30, 2024 at 07:35:45PM +0300, Abel Vesa wrote:
> The 1.2v HS PHY shared regulator is actually LDO2 from PM8550ve id J.
> Also add the missing supplies to QMP PHYs.
>
> Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support")
Same here, the CC stable tag is missing:
Cc: [email protected] # 6.9
> Signed-off-by: Abel Vesa <[email protected]>
Johan
On Thu, May 30, 2024 at 07:35:46PM GMT, Abel Vesa wrote:
> The 1.2v HS PHY shared regulator is actually LDO2 from PM8550ve id J.
> Also add the missing supplies to QMP PHYs.
>
> Fixes: 22b82135c02d ("arm64: dts: qcom: x1e80100-qcp: Enable more support")
This isn't the right hash. I'm fixing this one up, but please check make
sure your fixes are based on merged commits.
Regards,
Bjorn
On Thu, 30 May 2024 19:35:44 +0300, Abel Vesa wrote:
> According to documentation, the current supplies for the USB1 SS0,
> SS1 and SS2 both QMP combo PHYS and eUSB2 PHYs are all wrong. Fix
> them accordingly.
>
>
Applied, thanks!
[1/2] arm64: dts: qcom: x1e80100-crd: Fix USB PHYs regulators
commit: ae5cee8e7349d7e5deff4cf90a08cbd738287155
[2/2] arm64: dts: qcom: x1e80100-qcp: Fix USB PHYs regulators
commit: 20676f7819d7364b7e8bd437b212106faa893b49
Best regards,
--
Bjorn Andersson <[email protected]>
On 24-06-01 17:58:19, Bjorn Andersson wrote:
> On Thu, May 30, 2024 at 07:35:46PM GMT, Abel Vesa wrote:
> > The 1.2v HS PHY shared regulator is actually LDO2 from PM8550ve id J.
> > Also add the missing supplies to QMP PHYs.
> >
> > Fixes: 22b82135c02d ("arm64: dts: qcom: x1e80100-qcp: Enable more support")
>
> This isn't the right hash. I'm fixing this one up, but please check make
> sure your fixes are based on merged commits.
>
Sorry about that. Will double check next time.
Thanks for fixing it.
> Regards,
> Bjorn