2002-08-30 14:49:51

by Marc Zyngier

Subject: [Patch] Futex misses kill_sb

Hi all,

The enclosed patch fixes a missing .kill_sb in futexes' fs_type
declaration. Without this patch, kernel oopses if someone ever tries
to mount futexfs...

Thanks for any comments.

M.

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.542 -> 1.543
# kernel/futex.c 1.12 -> 1.13
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 02/08/30 [email protected] 1.543
# futex.c:
# Fixed missing .kill_sb
# --------------------------------------------
#
diff -Nru a/kernel/futex.c b/kernel/futex.c
--- a/kernel/futex.c Fri Aug 30 19:26:44 2002
+++ b/kernel/futex.c Fri Aug 30 19:26:44 2002
@@ -359,6 +359,7 @@
static struct file_system_type futex_fs_type = {
.name = "futexfs",
.get_sb = futexfs_get_sb,
+ .kill_sb = kill_anon_super,
};

static int __init init(void)

--
Places change, faces change. Life is so very strange.

2002-08-31 05:17:46

by Rusty Russell

Subject: Re: [Patch] Futex misses kill_sb

In message <[email protected]> you write:
> Hi all,
>
> The enclosed patch fixes a missing .kill_sb in futexes' fs_type
> declaration. Without this patch, kernel oopses if someone ever tries
> to mount futexfs...

<shrug>Viro ripped it out in 2.5.26. Al?

Rusty.

From: Marc Zyngier <[email protected]>
diff -Nru a/kernel/futex.c b/kernel/futex.c
--- a/kernel/futex.c Fri Aug 30 19:26:44 2002
+++ b/kernel/futex.c Fri Aug 30 19:26:44 2002
@@ -359,6 +359,7 @@
static struct file_system_type futex_fs_type = {
.name = "futexfs",
.get_sb = futexfs_get_sb,
+ .kill_sb = kill_anon_super,
};

static int __init init(void)

--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.