2024-06-04 00:10:02

by Jeff Johnson

[permalink] [raw]
Subject: [PATCH] soc: qcom: spm: add missing MODULE_DESCRIPTION()

make allmodconfig && make W=1 C=1 warns:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/qcom/spm.o

Add the missing MODULE_DESCRIPTION(), using the same description as
the underlying QCOM_SPM Kconfig item.

Signed-off-by: Jeff Johnson <[email protected]>
---
drivers/soc/qcom/spm.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/soc/qcom/spm.c b/drivers/soc/qcom/spm.c
index 06e2c4c2a4a8..f75659fff287 100644
--- a/drivers/soc/qcom/spm.c
+++ b/drivers/soc/qcom/spm.c
@@ -572,4 +572,5 @@ static int __init qcom_spm_init(void)
}
arch_initcall(qcom_spm_init);

+MODULE_DESCRIPTION("Qualcomm Subsystem Power Manager (SPM)");
MODULE_LICENSE("GPL v2");

---
base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
change-id: 20240530-md-soc-qcom-spm-622d3ccca90d



2024-06-04 07:45:05

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH] soc: qcom: spm: add missing MODULE_DESCRIPTION()

On Mon, Jun 03, 2024 at 05:09:34PM -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 warns:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/qcom/spm.o
>
> Add the missing MODULE_DESCRIPTION(), using the same description as
> the underlying QCOM_SPM Kconfig item.
>
> Signed-off-by: Jeff Johnson <[email protected]>
> ---
> drivers/soc/qcom/spm.c | 1 +
> 1 file changed, 1 insertion(+)
>

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2024-06-06 03:23:18

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] soc: qcom: spm: add missing MODULE_DESCRIPTION()


On Mon, 03 Jun 2024 17:09:34 -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 warns:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/qcom/spm.o
>
> Add the missing MODULE_DESCRIPTION(), using the same description as
> the underlying QCOM_SPM Kconfig item.
>
>
> [...]

Applied, thanks!

[1/1] soc: qcom: spm: add missing MODULE_DESCRIPTION()
commit: 1b503fa221d144fbb11e2591378429566564a6b8

Best regards,
--
Bjorn Andersson <[email protected]>