2010-12-16 09:09:35

by Namhyung Kim

Subject: [PATCH] aio: remove unnecessary check

'nr >= min_nr >= 0' always satisfies 'nr >= 0' so the check is unnecesary.

Signed-off-by: Namhyung Kim <[email protected]>
---
fs/aio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/aio.c b/fs/aio.c
index c56153f5f73e..45766460fa57 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -1839,7 +1839,7 @@ SYSCALL_DEFINE5(io_getevents, aio_context_t, ctx_id,
long ret = -EINVAL;

if (likely(ioctx)) {
- if (likely(min_nr <= nr && min_nr >= 0 && nr >= 0))
+ if (likely(min_nr <= nr && min_nr >= 0))
ret = read_events(ioctx, min_nr, nr, events, timeout);
put_ioctx(ioctx);
}
--
1.7.3.3.400.g93cef

2010-12-16 23:48:29

by Jeff Moyer

Subject: Re: [PATCH] aio: remove unnecessary check

Namhyung Kim <[email protected]> writes:

> 'nr >= min_nr >= 0' always satisfies 'nr >= 0' so the check is unnecesary.

Yeah, I don't see how the extra check helps.

Acked-by: Jeff Moyer <[email protected]>