2022-08-26 08:17:10

by Hui Su

Subject: [PATCH] sched: remove struct sg_lb_stats declaration

remove unnecessary struct sg_lb_stats declaration

Fixes: 57abff067a08 ("sched/fair: Rework find_idlest_group()")
Signed-off-by: Hui Su <[email protected]>
---
kernel/sched/fair.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 914096c5b1ae..54bacf635362 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -9050,9 +9050,6 @@ static inline enum fbq_type fbq_classify_rq(struct rq *rq)
}
#endif /* CONFIG_NUMA_BALANCING */

-
-struct sg_lb_stats;
-
/*
* task_running_on_cpu - return 1 if @p is running on @cpu.
*/
--
2.34.1

2022-09-23 16:17:27

by Valentin Schneider

Subject: Re: [PATCH] sched: remove struct sg_lb_stats declaration

On 26/08/22 15:57, Hui Su wrote:
> remove unnecessary struct sg_lb_stats declaration
>
> Fixes: 57abff067a08 ("sched/fair: Rework find_idlest_group()")
> Signed-off-by: Hui Su <[email protected]>

Reviewed-by: Valentin Schneider <[email protected]>

> ---
> kernel/sched/fair.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 914096c5b1ae..54bacf635362 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -9050,9 +9050,6 @@ static inline enum fbq_type fbq_classify_rq(struct rq *rq)
> }
> #endif /* CONFIG_NUMA_BALANCING */
>
> -
> -struct sg_lb_stats;
> -
> /*
> * task_running_on_cpu - return 1 if @p is running on @cpu.
> */
> --
> 2.34.1