2022-05-26 21:26:25

by Phil Auld

Subject: [PATCH v2 2/2] cpuhp: Set cpuhp target for boot cpu

Since the boot cpu does not go through the hotplug process it ends
up with state == CPUHP_ONLINE but target == CPUHP_OFFLINE.
Set the target to match in boot_cpu_hotplug_init().

Signed-off-by: Phil Auld <[email protected]>
---
kernel/cpu.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/kernel/cpu.c b/kernel/cpu.c
index cdb6ac10ad94..0bb8ad0fa2d9 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -2677,6 +2677,7 @@ void __init boot_cpu_hotplug_init(void)
cpumask_set_cpu(smp_processor_id(), &cpus_booted_once_mask);
#endif
this_cpu_write(cpuhp_state.state, CPUHP_ONLINE);
+ this_cpu_write(cpuhp_state.target, CPUHP_ONLINE);
}

/*
--
2.18.0

2022-05-28 19:59:30

by Valentin Schneider

Subject: Re: [PATCH v2 2/2] cpuhp: Set cpuhp target for boot cpu

On 26/05/22 12:06, Phil Auld wrote:
> Since the boot cpu does not go through the hotplug process it ends
> up with state == CPUHP_ONLINE but target == CPUHP_OFFLINE.
> Set the target to match in boot_cpu_hotplug_init().
>
> Signed-off-by: Phil Auld <[email protected]>

Reviewed-by: Valentin Schneider <[email protected]>

> ---
> kernel/cpu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index cdb6ac10ad94..0bb8ad0fa2d9 100644
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -2677,6 +2677,7 @@ void __init boot_cpu_hotplug_init(void)
> cpumask_set_cpu(smp_processor_id(), &cpus_booted_once_mask);
> #endif
> this_cpu_write(cpuhp_state.state, CPUHP_ONLINE);
> + this_cpu_write(cpuhp_state.target, CPUHP_ONLINE);
> }
>
> /*
> --
> 2.18.0