Commit 20c9819ccd9e ("dt-bindings: i2c: nxp,pnx-i2c: Convert to dtschema")
converts i2c-pnx.txt to nxp,pnx-i2c.yaml, but misses to adjust the file
entry in ARM/LPC32XX SOC SUPPORT.
Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
broken reference.
Adjust the file entry in ARM/LPC32XX SOC SUPPORT after this conversion.
Signed-off-by: Lukas Bulwahn <[email protected]>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 06d685a97b4b..edf6176a5530 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2360,7 +2360,7 @@ M: Vladimir Zapolskiy <[email protected]>
L: [email protected] (moderated for non-subscribers)
S: Maintained
T: git git://github.com/vzapolskiy/linux-lpc32xx.git
-F: Documentation/devicetree/bindings/i2c/i2c-pnx.txt
+F: Documentation/devicetree/bindings/i2c/nxp,pnx-i2c.yaml
F: arch/arm/boot/dts/nxp/lpc/lpc32*
F: arch/arm/mach-lpc32xx/
F: drivers/i2c/busses/i2c-pnx.c
--
2.44.0
Hi Lukas,
> -F: Documentation/devicetree/bindings/i2c/i2c-pnx.txt
> +F: Documentation/devicetree/bindings/i2c/nxp,pnx-i2c.yaml
Reviewed-by: Andi Shyti <[email protected]>
I guess this should go through the arm folks?
Thanks,
Andi
> > -F: Documentation/devicetree/bindings/i2c/i2c-pnx.txt
> > +F: Documentation/devicetree/bindings/i2c/nxp,pnx-i2c.yaml
>
> Reviewed-by: Andi Shyti <[email protected]>
>
> I guess this should go through the arm folks?
Could be argued, but I guess it is easier if you take it (because the
conversion patch also went through your tree). Just 2 cents...
On Fri, Apr 12, 2024 at 8:45 AM Wolfram Sang
<[email protected]> wrote:
>
>
> > > -F: Documentation/devicetree/bindings/i2c/i2c-pnx.txt
> > > +F: Documentation/devicetree/bindings/i2c/nxp,pnx-i2c.yaml
> >
> > Reviewed-by: Andi Shyti <[email protected]>
> >
> > I guess this should go through the arm folks?
>
> Could be argued, but I guess it is easier if you take it (because the
> conversion patch also went through your tree). Just 2 cents...
>
.. and I am creating my patches against some recent linux-next tag.
So, the commit could really only be in your tree and the arm folks
would not apply it because the referred commit is not in their tree
yet (until the next merge window closes and they reopen a new branch).
So, as Wolfram suggested: please take my patch in your tree on top of
the referred commit.
Lukas
Hi Lukas,
On Thu, Apr 11, 2024 at 07:02:57AM +0200, Lukas Bulwahn wrote:
> Commit 20c9819ccd9e ("dt-bindings: i2c: nxp,pnx-i2c: Convert to dtschema")
> converts i2c-pnx.txt to nxp,pnx-i2c.yaml, but misses to adjust the file
> entry in ARM/LPC32XX SOC SUPPORT.
>
> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
> broken reference.
>
> Adjust the file entry in ARM/LPC32XX SOC SUPPORT after this conversion.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
before taking this I just want to make sure the e-mail in the SoB
is correct as checkpatch is warning me about 'lbulwahn' and
'lukas.bulwahn'.
It's not about the warning, just double checking the e-mail
address as often to mix my addresses up and looks also your first
patch with the redhat e-mail.
Thanks,
Andi
On Fri, Apr 12, 2024 at 11:34 AM Andi Shyti <[email protected]> wrote:
>
> Hi Lukas,
>
> On Thu, Apr 11, 2024 at 07:02:57AM +0200, Lukas Bulwahn wrote:
> > Commit 20c9819ccd9e ("dt-bindings: i2c: nxp,pnx-i2c: Convert to dtschema")
> > converts i2c-pnx.txt to nxp,pnx-i2c.yaml, but misses to adjust the file
> > entry in ARM/LPC32XX SOC SUPPORT.
> >
> > Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
> > broken reference.
> >
> > Adjust the file entry in ARM/LPC32XX SOC SUPPORT after this conversion.
> >
> > Signed-off-by: Lukas Bulwahn <[email protected]>
>
> before taking this I just want to make sure the e-mail in the SoB
> is correct as checkpatch is warning me about 'lbulwahn' and
> 'lukas.bulwahn'.
>
> It's not about the warning, just double checking the e-mail
> address as often to mix my addresses up and looks also your first
> patch with the redhat e-mail.
>
Thanks for the hint. And yes, that is a stupid setup mistake from my
side or at least from the email server's side.
I joined Red Hat at the beginning of April and hence, it was my first
email with the redhat address.
lbulwahn is my 'official email address', lukas.bulwahn is an email
alias to the same mailbox. I actually want to have the commits in the
kernel carry '[email protected]' and not 'lbulwahn'.
I have sent them out with 'From: Lukas Bulwahn
<[email protected]>' in my patch file; so, checkpatch did not
complain locally.
The gmail server however turns this into:
From: Lukas Bulwahn <[email protected]>
X-Google-Original-From: Lukas Bulwahn <[email protected]>
I will see what I can do and send out a v2.
Thanks again for the hint!
Lukas
> On Fri, Apr 12, 2024 at 11:34 AM Andi Shyti <[email protected]> wrote:
> > On Thu, Apr 11, 2024 at 07:02:57AM +0200, Lukas Bulwahn wrote:
> > > Signed-off-by: Lukas Bulwahn <[email protected]>
> >
> > before taking this I just want to make sure the e-mail in the SoB
> > is correct as checkpatch is warning me about 'lbulwahn' and
> > 'lukas.bulwahn'.
> >
> > It's not about the warning, just double checking the e-mail
> > address as often to mix my addresses up and looks also your first
> > patch with the redhat e-mail.
> >
>
> Thanks for the hint. And yes, that is a stupid setup mistake from my
> side or at least from the email server's side.
>
> I joined Red Hat at the beginning of April and hence, it was my first
> email with the redhat address.
>
> lbulwahn is my 'official email address', lukas.bulwahn is an email
> alias to the same mailbox. I actually want to have the commits in the
> kernel carry '[email protected]' and not 'lbulwahn'.
>
> I have sent them out with 'From: Lukas Bulwahn
> <[email protected]>' in my patch file; so, checkpatch did not
> complain locally.
>
> The gmail server however turns this into:
>
> From: Lukas Bulwahn <[email protected]>
> X-Google-Original-From: Lukas Bulwahn <[email protected]>
>
> I will see what I can do and send out a v2.
no need... I will keep things as they are; as long as I know
these are the same mails I'm fine.
Thanks,
Andi