Hi Martin,
This series includes some updates as following:
- better management of freeing PCI vectors
- hopefully the following series can make it soon so we may remove this
new code:
https://lore.kernel.org/linux-pci/[email protected]/T/#md27a594ac53b8e05abb2f22ec350137b9023ff18
- Fix prot_mask module param permissions
- Change phyup timeout to handle some special SATA disks
- modify underflow handling to quickly identify faulty disks
- debugfs hardening
Please consider for 5.18 - hopefully not too late
Thanks!
Qi Liu (2):
scsi: hisi_sas: Free irq vectors in order for v3 HW
scsi: hisi_sas: Rename error labels in hisi_sas_v3_probe()
Xiang Chen (3):
scsi: hisi_sas: Change permission of parameter prot_mask
scsi: hisi_sas: Change hisi_sas_control_phy() phyup timeout
scsi: hisi_sas: Limit users changing debugfs BIST count value
Xingui Yang (1):
scsi: hisi_sas: Modify v3 HW SSP underflow error processing
drivers/scsi/hisi_sas/hisi_sas.h | 2 +-
drivers/scsi/hisi_sas/hisi_sas_main.c | 3 +-
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 127 +++++++++++++++++++------
3 files changed, 100 insertions(+), 32 deletions(-)
--
2.26.2
From: Xiang Chen <[email protected]>
Currently the permission of parameter prot_mask is 0x0, which means that
the member does not appear in sysfs. Change it as other module parameters
to 0444 for world-readable.
Reported-by: Yihang Li <[email protected]>
Signed-off-by: Xiang Chen <[email protected]>
Signed-off-by: John Garry <[email protected]>
Fixes: d6a9000b81be ("scsi: hisi_sas: Add support for DIF feature for v3 hw")
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
index a57f247481ed..29a566a19219 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
@@ -530,7 +530,7 @@ MODULE_PARM_DESC(intr_conv, "interrupt converge enable (0-1)");
/* permit overriding the host protection capabilities mask (EEDP/T10 PI) */
static int prot_mask;
-module_param(prot_mask, int, 0);
+module_param(prot_mask, int, 0444);
MODULE_PARM_DESC(prot_mask, " host protection capabilities mask, def=0x0 ");
static void debugfs_work_handler_v3_hw(struct work_struct *work);
--
2.26.2
John,
> This series includes some updates as following:
Applied to 5.18/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
On Thu, 24 Feb 2022 19:51:23 +0800, John Garry wrote:
> This series includes some updates as following:
> - better management of freeing PCI vectors
> - hopefully the following series can make it soon so we may remove this
> new code:
> https://lore.kernel.org/linux-pci/[email protected]/T/#md27a594ac53b8e05abb2f22ec350137b9023ff18
> - Fix prot_mask module param permissions
> - Change phyup timeout to handle some special SATA disks
> - modify underflow handling to quickly identify faulty disks
> - debugfs hardening
>
> [...]
Applied to 5.18/scsi-queue, thanks!
[1/6] scsi: hisi_sas: Change permission of parameter prot_mask
https://git.kernel.org/mkp/scsi/c/c4e070457a93
[2/6] scsi: hisi_sas: Change hisi_sas_control_phy() phyup timeout
https://git.kernel.org/mkp/scsi/c/512623de5239
[3/6] scsi: hisi_sas: Free irq vectors in order for v3 HW
https://git.kernel.org/mkp/scsi/c/554fb72ee34f
[4/6] scsi: hisi_sas: Rename error labels in hisi_sas_v3_probe()
https://git.kernel.org/mkp/scsi/c/86287065fac2
[5/6] scsi: hisi_sas: Limit users changing debugfs BIST count value
https://git.kernel.org/mkp/scsi/c/286ce4c65fbd
[6/6] scsi: hisi_sas: Modify v3 HW SSP underflow error processing
https://git.kernel.org/mkp/scsi/c/62413199cd6d
--
Martin K. Petersen Oracle Linux Engineering