2020-11-14 07:32:17

by Zou Wei

Subject: [PATCH -next] scsi: be2iscsi: Mark beiscsi_attrs with static keyword

Fix the following sparse warning:

./be_main.c:167:25: warning: symbol 'beiscsi_attrs' was not declared. Should it be static?

Signed-off-by: Zou Wei <[email protected]>
---
drivers/scsi/be2iscsi/be_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 202ba92..50e4642 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -164,7 +164,7 @@ DEVICE_ATTR(beiscsi_active_session_count, S_IRUGO,
beiscsi_active_session_disp, NULL);
DEVICE_ATTR(beiscsi_free_session_count, S_IRUGO,
beiscsi_free_session_disp, NULL);
-struct device_attribute *beiscsi_attrs[] = {
+static struct device_attribute *beiscsi_attrs[] = {
&dev_attr_beiscsi_log_enable,
&dev_attr_beiscsi_drvr_ver,
&dev_attr_beiscsi_adapter_family,
--
2.6.2

2020-11-17 04:43:33

by Martin K. Petersen

Subject: Re: [PATCH -next] scsi: be2iscsi: Mark beiscsi_attrs with static keyword

Zou,

> Fix the following sparse warning:
>
> ./be_main.c:167:25: warning: symbol 'beiscsi_attrs' was not declared. Should it be static?

Applied to 5.11/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2020-11-20 03:38:25

by Martin K. Petersen

Subject: Re: [PATCH -next] scsi: be2iscsi: Mark beiscsi_attrs with static keyword

On Sat, 14 Nov 2020 15:37:54 +0800, Zou Wei wrote:

> Fix the following sparse warning:
>
> ./be_main.c:167:25: warning: symbol 'beiscsi_attrs' was not declared. Should it be static?

Applied to 5.11/scsi-queue, thanks!

[1/1] scsi: be2iscsi: Mark beiscsi_attrs with static keyword
https://git.kernel.org/mkp/scsi/c/4ab2990a5ce1

--
Martin K. Petersen Oracle Linux Engineering