From: Colin Ian King <[email protected]>
The pointer req is being initialized with a value that is never read, it
is being updated later on. The assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/scsi/qla2xxx/qla_mbx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
index 7811c4952035..b5e21fad9551 100644
--- a/drivers/scsi/qla2xxx/qla_mbx.c
+++ b/drivers/scsi/qla2xxx/qla_mbx.c
@@ -3236,7 +3236,7 @@ qla24xx_abort_command(srb_t *sp)
fc_port_t *fcport = sp->fcport;
struct scsi_qla_host *vha = fcport->vha;
struct qla_hw_data *ha = vha->hw;
- struct req_que *req = vha->req;
+ struct req_que *req;
struct qla_qpair *qpair = sp->qpair;
ql_dbg(ql_dbg_mbx + ql_dbg_verbose, vha, 0x108c,
--
2.32.0
> On Sep 10, 2021, at 6:46 AM, Colin King <[email protected]> wrote:
>
> From: Colin Ian King <[email protected]>
>
> The pointer req is being initialized with a value that is never read, it
> is being updated later on. The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/scsi/qla2xxx/qla_mbx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
> index 7811c4952035..b5e21fad9551 100644
> --- a/drivers/scsi/qla2xxx/qla_mbx.c
> +++ b/drivers/scsi/qla2xxx/qla_mbx.c
> @@ -3236,7 +3236,7 @@ qla24xx_abort_command(srb_t *sp)
> fc_port_t *fcport = sp->fcport;
> struct scsi_qla_host *vha = fcport->vha;
> struct qla_hw_data *ha = vha->hw;
> - struct req_que *req = vha->req;
> + struct req_que *req;
> struct qla_qpair *qpair = sp->qpair;
>
> ql_dbg(ql_dbg_mbx + ql_dbg_verbose, vha, 0x108c,
> --
> 2.32.0
>
Reviewed-by: Himanshu Madhani <[email protected]>
--
Himanshu Madhani Oracle Linux Engineering
Colin,
> The pointer req is being initialized with a value that is never read,
> it is being updated later on. The assignment is redundant and can be
> removed.
Applied to 5.16/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
On Fri, 10 Sep 2021 12:46:10 +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The pointer req is being initialized with a value that is never read, it
> is being updated later on. The assignment is redundant and can be removed.
>
>
Applied to 5.16/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Remove redundant initialization of pointer req
https://git.kernel.org/mkp/scsi/c/914418f36901
--
Martin K. Petersen Oracle Linux Engineering