2023-03-28 00:42:45

by Tom Rix

Subject: [PATCH] scsi: snic: remove unused xfer_len variable

clang with W=1 reports
drivers/scsi/snic/snic_scsi.c:490:6: error: variable
'xfer_len' set but not used [-Werror,-Wunused-but-set-variable]
u64 xfer_len = 0;
^
This variable is not used so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/scsi/snic/snic_scsi.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/scsi/snic/snic_scsi.c b/drivers/scsi/snic/snic_scsi.c
index 961af6fc21bc..c50ede326cc4 100644
--- a/drivers/scsi/snic/snic_scsi.c
+++ b/drivers/scsi/snic/snic_scsi.c
@@ -487,7 +487,6 @@ snic_process_icmnd_cmpl_status(struct snic *snic,
struct scsi_cmnd *sc)
{
u8 scsi_stat = icmnd_cmpl->scsi_status;
- u64 xfer_len = 0;
int ret = 0;

/* Mark the IO as complete */
@@ -496,15 +495,11 @@ snic_process_icmnd_cmpl_status(struct snic *snic,
if (likely(cmpl_stat == SNIC_STAT_IO_SUCCESS)) {
sc->result = (DID_OK << 16) | scsi_stat;

- xfer_len = scsi_bufflen(sc);
-
/* Update SCSI Cmd with resid value */
scsi_set_resid(sc, le32_to_cpu(icmnd_cmpl->resid));

- if (icmnd_cmpl->flags & SNIC_ICMND_CMPL_UNDR_RUN) {
- xfer_len -= le32_to_cpu(icmnd_cmpl->resid);
+ if (icmnd_cmpl->flags & SNIC_ICMND_CMPL_UNDR_RUN)
atomic64_inc(&snic->s_stats.misc.io_under_run);
- }

if (icmnd_cmpl->scsi_status == SAM_STAT_TASK_SET_FULL)
atomic64_inc(&snic->s_stats.misc.qfull);
--
2.27.0

2023-04-03 02:03:41

by Martin K. Petersen

Subject: Re: [PATCH] scsi: snic: remove unused xfer_len variable

Tom,

> clang with W=1 reports
> drivers/scsi/snic/snic_scsi.c:490:6: error: variable
> 'xfer_len' set but not used [-Werror,-Wunused-but-set-variable]
> u64 xfer_len = 0;
> ^
> This variable is not used so remove it.

Applied to 6.4/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2023-04-12 02:18:30

by Martin K. Petersen

Subject: Re: [PATCH] scsi: snic: remove unused xfer_len variable

On Mon, 27 Mar 2023 20:16:47 -0400, Tom Rix wrote:

> clang with W=1 reports
> drivers/scsi/snic/snic_scsi.c:490:6: error: variable
> 'xfer_len' set but not used [-Werror,-Wunused-but-set-variable]
> u64 xfer_len = 0;
> ^
> This variable is not used so remove it.
>
> [...]

Applied to 6.4/scsi-queue, thanks!

[1/1] scsi: snic: remove unused xfer_len variable
https://git.kernel.org/mkp/scsi/c/4e0966a48291

--
Martin K. Petersen Oracle Linux Engineering