2023-02-07 05:22:53

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH] scsi: qla2xxx: Remove the unused variable wwn

Variable wwn is not effectively used, so delete it.

drivers/scsi/qla2xxx/qla_init.c:1657:6: warning: variable 'wwn' set but not used.

Reported-by: Abaci Robot <[email protected]>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3964
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/scsi/qla2xxx/qla_init.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index c5e73d5a26b1..1dbc1496ebed 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -1654,7 +1654,6 @@ static void qla_chk_n2n_b4_login(struct scsi_qla_host *vha, fc_port_t *fcport)
int qla24xx_fcport_handle_login(struct scsi_qla_host *vha, fc_port_t *fcport)
{
u16 data[2];
- u64 wwn;
u16 sec;

ql_dbg(ql_dbg_disc, vha, 0x20d8,
@@ -1694,7 +1693,6 @@ int qla24xx_fcport_handle_login(struct scsi_qla_host *vha, fc_port_t *fcport)

switch (fcport->disc_state) {
case DSC_DELETED:
- wwn = wwn_to_u64(fcport->node_name);
switch (vha->hw->current_topology) {
case ISP_CFG_N:
if (fcport_is_smaller(fcport)) {
--
2.20.1.7.g153144c



2023-02-09 00:00:00

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: qla2xxx: Remove the unused variable wwn


Jiapeng,

> Variable wwn is not effectively used, so delete it.

Applied to 6.3/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2023-02-14 16:58:03

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: qla2xxx: Remove the unused variable wwn

On Tue, 07 Feb 2023 13:22:34 +0800, Jiapeng Chong wrote:

> Variable wwn is not effectively used, so delete it.
>
> drivers/scsi/qla2xxx/qla_init.c:1657:6: warning: variable 'wwn' set but not used.
>
>

Applied to 6.3/scsi-queue, thanks!

[1/1] scsi: qla2xxx: Remove the unused variable wwn
https://git.kernel.org/mkp/scsi/c/d48a62381a73

--
Martin K. Petersen Oracle Linux Engineering