2019-04-17 15:08:15

by Yue Haibing

Subject: [PATCH -next] scsi: lpfc: Make lpfc_sli4_oas_verify static

From: YueHaibing <[email protected]>

Fix sparse warning:

drivers/scsi/lpfc/lpfc_init.c:13091:1: warning:
symbol 'lpfc_sli4_oas_verify' was not declared. Should it be static?

Signed-off-by: YueHaibing <[email protected]>
---
drivers/scsi/lpfc/lpfc_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 8e0de48..eaaef68 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -13087,7 +13087,7 @@ lpfc_io_resume(struct pci_dev *pdev)
* is destroyed.
*
**/
-void
+static void
lpfc_sli4_oas_verify(struct lpfc_hba *phba)
{

--
2.7.4

2019-04-18 15:53:35

by James Smart

Subject: Re: [PATCH -next] scsi: lpfc: Make lpfc_sli4_oas_verify static

On 4/17/2019 8:05 AM, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> Fix sparse warning:
>
> drivers/scsi/lpfc/lpfc_init.c:13091:1: warning:
> symbol 'lpfc_sli4_oas_verify' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/scsi/lpfc/lpfc_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index 8e0de48..eaaef68 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -13087,7 +13087,7 @@ lpfc_io_resume(struct pci_dev *pdev)
> * is destroyed.
> *
> **/
> -void
> +static void
> lpfc_sli4_oas_verify(struct lpfc_hba *phba)
> {
>

Looks good. Interesting as there's a prototype for the function earlier
which defines it as static.

Reviewed-by:  James Smart  <[email protected]>

-- james

2019-04-19 00:38:38

by Martin K. Petersen

Subject: Re: [PATCH -next] scsi: lpfc: Make lpfc_sli4_oas_verify static

Yue,

> Fix sparse warning:
>
> drivers/scsi/lpfc/lpfc_init.c:13091:1: warning:
> symbol 'lpfc_sli4_oas_verify' was not declared. Should it be static?

Applied to 5.2/scsi-queue, thanks.

--
Martin K. Petersen Oracle Linux Engineering