2024-02-15 15:38:24

by Colin Ian King

Subject: [PATCH][next] scsi: qla1280: remove redundant assignment to variable mr

The variable mr being assigned a value that is never read, the assignment
is redundant and can be removed.

Cleans up clang scan build warning:

drivers/scsi/qla1280.c:2481:2: warning: Value stored to 'mr' is never
read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/scsi/qla1280.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
index 27bce80262c2..8958547ac111 100644
--- a/drivers/scsi/qla1280.c
+++ b/drivers/scsi/qla1280.c
@@ -2478,7 +2478,6 @@ qla1280_mailbox_command(struct scsi_qla_host *ha, uint8_t mr, uint16_t *mb)
/* Load return mailbox registers. */
optr = mb;
iptr = (uint16_t *) &ha->mailbox_out[0];
- mr = MAILBOX_REGISTER_COUNT;
memcpy(optr, iptr, MAILBOX_REGISTER_COUNT * sizeof(uint16_t));

if (ha->flags.reset_marker)
--
2.39.2

2024-02-15 20:14:57

by Martin K. Petersen

Subject: Re: [PATCH][next] scsi: qla1280: remove redundant assignment to variable mr

Colin,

> The variable mr being assigned a value that is never read, the assignment
> is redundant and can be removed.

Applied to 6.9/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering