Hi all,
After merging the scsi-mkp tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/scsi/qla2xxx/tcm_qla2xxx.c: In function 'tcm_qla2xxx_init_lport':
drivers/scsi/qla2xxx/tcm_qla2xxx.c:1614:3: error: implicit declaration of function 'vzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
vzalloc(array_size(65536,
^~~~~~~
kvzalloc
drivers/scsi/qla2xxx/tcm_qla2xxx.c:1613:26: warning: assignment to 'struct tcm_qla2xxx_fc_loopid *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
lport->lport_loopid_map =
^
drivers/scsi/qla2xxx/tcm_qla2xxx.c: In function 'tcm_qla2xxx_make_lport':
drivers/scsi/qla2xxx/tcm_qla2xxx.c:1677:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
vfree(lport->lport_loopid_map);
^~~~~
kvfree
Caused by commit
523c106ad4b1 ("scsi: tcm_qla2xxx: Minimize #include directives")
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell
Hi all,
On Tue, 9 Apr 2019 16:27:49 +1000 Stephen Rothwell <[email protected]> wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/scsi/qla2xxx/tcm_qla2xxx.c: In function 'tcm_qla2xxx_init_lport':
> drivers/scsi/qla2xxx/tcm_qla2xxx.c:1614:3: error: implicit declaration of function 'vzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
> vzalloc(array_size(65536,
> ^~~~~~~
> kvzalloc
> drivers/scsi/qla2xxx/tcm_qla2xxx.c:1613:26: warning: assignment to 'struct tcm_qla2xxx_fc_loopid *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> lport->lport_loopid_map =
> ^
> drivers/scsi/qla2xxx/tcm_qla2xxx.c: In function 'tcm_qla2xxx_make_lport':
> drivers/scsi/qla2xxx/tcm_qla2xxx.c:1677:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
> vfree(lport->lport_loopid_map);
> ^~~~~
> kvfree
>
> Caused by commit
>
> 523c106ad4b1 ("scsi: tcm_qla2xxx: Minimize #include directives")
>
> I have reverted that commit for today.
This has now migrated to the scsi tree.
--
Cheers,
Stephen Rothwell
Stephen,
>> I have reverted that commit for today.
>
> This has now migrated to the scsi tree.
I have a fix in my tree but I haven't pushed it yet.
--
Martin K. Petersen Oracle Linux Engineering
On Tue, 2019-04-09 at 21:33 -0400, Martin K. Petersen wrote:
> Stephen,
>
> > > I have reverted that commit for today.
> >
> > This has now migrated to the scsi tree.
>
> I have a fix in my tree but I haven't pushed it yet.
It's upstream in both trees now.
James
Hi all,
On Wed, 10 Apr 2019 06:04:19 +0200 James Bottomley <[email protected]> wrote:
>
> On Tue, 2019-04-09 at 21:33 -0400, Martin K. Petersen wrote:
> >
> > > > I have reverted that commit for today.
> > >
> > > This has now migrated to the scsi tree.
> >
> > I have a fix in my tree but I haven't pushed it yet.
>
> It's upstream in both trees now.
Thanks, it'll be in -next tomorrow.
--
Cheers,
Stephen Rothwell