2020-09-16 02:31:54

by Liu Shixin

Subject: [PATCH -next] scsi: snic: convert to use DEFINE_SEQ_ATTRIBUTE macro

Use DEFINE_SEQ_ATTRIBUTE macro to simplify the code.

Signed-off-by: Liu Shixin <[email protected]>
---
drivers/scsi/snic/snic_debugfs.c | 16 ++--------------
1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/drivers/scsi/snic/snic_debugfs.c b/drivers/scsi/snic/snic_debugfs.c
index 2b349365592f..4471c4c8aafa 100644
--- a/drivers/scsi/snic/snic_debugfs.c
+++ b/drivers/scsi/snic/snic_debugfs.c
@@ -439,26 +439,14 @@ snic_trc_seq_show(struct seq_file *sfp, void *data)
return 0;
}

-static const struct seq_operations snic_trc_seq_ops = {
+static const struct seq_operations snic_trc_sops = {
.start = snic_trc_seq_start,
.next = snic_trc_seq_next,
.stop = snic_trc_seq_stop,
.show = snic_trc_seq_show,
};

-static int
-snic_trc_open(struct inode *inode, struct file *filp)
-{
- return seq_open(filp, &snic_trc_seq_ops);
-}
-
-static const struct file_operations snic_trc_fops = {
- .owner = THIS_MODULE,
- .open = snic_trc_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = seq_release,
-};
+DEFINE_SEQ_ATTRIBUTE(snic_trc);

/*
* snic_trc_debugfs_init : creates trace/tracing_enable files for trace
--
2.25.1

2020-10-03 02:09:21

by Martin K. Petersen

Subject: Re: [PATCH -next] scsi: snic: convert to use DEFINE_SEQ_ATTRIBUTE macro

Liu,

> Use DEFINE_SEQ_ATTRIBUTE macro to simplify the code.

Applied to 5.10/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2020-10-07 03:53:00

by Martin K. Petersen

Subject: Re: [PATCH -next] scsi: snic: convert to use DEFINE_SEQ_ATTRIBUTE macro

On Wed, 16 Sep 2020 10:50:30 +0800, Liu Shixin wrote:

> Use DEFINE_SEQ_ATTRIBUTE macro to simplify the code.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: snic: Convert to use DEFINE_SEQ_ATTRIBUTE macro
https://git.kernel.org/mkp/scsi/c/936dc95d09d8

--
Martin K. Petersen Oracle Linux Engineering