2019-02-28 12:17:32

by Måns Rullgård

[permalink] [raw]
Subject: [PATCH] usb: musb: sunxi: propagate devicetree node to glue pdev

In order for devicetree nodes to be correctly associated with attached
devices, the controller node needs to be propagated to the glue device.

Signed-off-by: Mans Rullgard <[email protected]>
---
This depends on 2c1ea6abde88 ("platform: set of_node in
platform_device_register_full()") which is currently winding its way
through the staging trees.
---
drivers/usb/musb/sunxi.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
index 832a41f9ee7d..a72665fbf111 100644
--- a/drivers/usb/musb/sunxi.c
+++ b/drivers/usb/musb/sunxi.c
@@ -781,6 +781,8 @@ static int sunxi_musb_probe(struct platform_device *pdev)
pinfo.name = "musb-hdrc";
pinfo.id = PLATFORM_DEVID_AUTO;
pinfo.parent = &pdev->dev;
+ pinfo.fwnode = of_fwnode_handle(pdev->dev.of_node);
+ pinfo.of_node_reused = true;
pinfo.res = pdev->resource;
pinfo.num_res = pdev->num_resources;
pinfo.data = &pdata;
--
2.20.1



2019-03-18 14:30:09

by Måns Rullgård

[permalink] [raw]
Subject: Re: [PATCH] usb: musb: sunxi: propagate devicetree node to glue pdev

Mans Rullgard <[email protected]> writes:

> In order for devicetree nodes to be correctly associated with attached
> devices, the controller node needs to be propagated to the glue device.
>
> Signed-off-by: Mans Rullgard <[email protected]>
> ---
> This depends on 2c1ea6abde88 ("platform: set of_node in
> platform_device_register_full()") which is currently winding its way
> through the staging trees.

That patch is now in next.

> ---
> drivers/usb/musb/sunxi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
> index 832a41f9ee7d..a72665fbf111 100644
> --- a/drivers/usb/musb/sunxi.c
> +++ b/drivers/usb/musb/sunxi.c
> @@ -781,6 +781,8 @@ static int sunxi_musb_probe(struct platform_device *pdev)
> pinfo.name = "musb-hdrc";
> pinfo.id = PLATFORM_DEVID_AUTO;
> pinfo.parent = &pdev->dev;
> + pinfo.fwnode = of_fwnode_handle(pdev->dev.of_node);
> + pinfo.of_node_reused = true;
> pinfo.res = pdev->resource;
> pinfo.num_res = pdev->num_resources;
> pinfo.data = &pdata;
> --
> 2.20.1
>

--
M?ns Rullg?rd

2019-06-27 09:56:28

by Måns Rullgård

[permalink] [raw]
Subject: Re: [PATCH] usb: musb: sunxi: propagate devicetree node to glue pdev

Mans Rullgard <[email protected]> writes:

> In order for devicetree nodes to be correctly associated with attached
> devices, the controller node needs to be propagated to the glue device.
>
> Signed-off-by: Mans Rullgard <[email protected]>
> ---
> This depends on 2c1ea6abde88 ("platform: set of_node in
> platform_device_register_full()") which is currently winding its way
> through the staging trees.

That patch is in v5.1, so this one can go ahead now. Assuming there are
no objections, of course.

> ---
> drivers/usb/musb/sunxi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
> index 832a41f9ee7d..a72665fbf111 100644
> --- a/drivers/usb/musb/sunxi.c
> +++ b/drivers/usb/musb/sunxi.c
> @@ -781,6 +781,8 @@ static int sunxi_musb_probe(struct platform_device *pdev)
> pinfo.name = "musb-hdrc";
> pinfo.id = PLATFORM_DEVID_AUTO;
> pinfo.parent = &pdev->dev;
> + pinfo.fwnode = of_fwnode_handle(pdev->dev.of_node);
> + pinfo.of_node_reused = true;
> pinfo.res = pdev->resource;
> pinfo.num_res = pdev->num_resources;
> pinfo.data = &pdata;
> --
> 2.20.1
>

--
M?ns Rullg?rd